From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5F04A0548; Thu, 1 Apr 2021 14:43:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A46E14127E; Thu, 1 Apr 2021 14:40:17 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 2F2C414126B for ; Thu, 1 Apr 2021 14:40:14 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B680F7F50E; Thu, 1 Apr 2021 15:40:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B680F7F50E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1617280813; bh=8fQlEjuX2bDEkbF0HBgptTcKM/OnpnUylw1PtXaC8oA=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=mX5s3+rwM6AE7zev3w4IL+0a1H5FbhwRYaEB5wOpzgU7QqwK5xG4+tLMg+42UJBXZ w4KqYAlcYVEzYTYr409thhtX/9gJaTgrhBOgo8CKo1chHCCJPb+l9TD/839ZTdjzch cqR6DRD49lz84sNdm8igW+/LzAmbznPrAbP11dlU= To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, bluca@debian.org References: <20210401115009.1063844-1-bruce.richardson@intel.com> <20210401115009.1063844-6-bruce.richardson@intel.com> <9911ffc6-e1d4-3411-896a-4cdcf452c1a2@oktetlabs.ru> <20210401123339.GB1627@bricha3-MOBL.ger.corp.intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <5cf02981-634a-bb08-8219-8aa67bec6e44@oktetlabs.ru> Date: Thu, 1 Apr 2021 15:40:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210401123339.GB1627@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [RFC PATCH 05/14] build: clean up driver list indentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/1/21 3:33 PM, Bruce Richardson wrote: > On Thu, Apr 01, 2021 at 03:14:40PM +0300, Andrew Rybchenko wrote: >> On 4/1/21 2:50 PM, Bruce Richardson wrote: >>> Ensure all lists of drivers are one-per-line and replace tabs with spaces >>> in each file to correspond to the new standard. >>> >>> Signed-off-by: Bruce Richardson >>> --- >>> drivers/baseband/meson.build | 8 ++- >>> drivers/bus/meson.build | 7 ++- >>> drivers/common/meson.build | 9 +++- >>> drivers/compress/meson.build | 7 ++- >>> drivers/crypto/meson.build | 38 ++++++------- >>> drivers/event/meson.build | 17 ++++-- >>> drivers/mempool/meson.build | 8 ++- >>> drivers/meson.build | 33 ++++++------ >>> drivers/net/meson.build | 102 +++++++++++++++++------------------ >>> drivers/raw/meson.build | 15 +++--- >>> drivers/regex/meson.build | 3 +- >>> drivers/vdpa/meson.build | 4 +- >>> 12 files changed, 142 insertions(+), 109 deletions(-) >>> >>> diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build >>> index 920e3b02ee..22d0036cd7 100644 >>> --- a/drivers/baseband/meson.build >>> +++ b/drivers/baseband/meson.build >>> @@ -2,7 +2,11 @@ >>> # Copyright(c) 2018 Luca Boccassi >>> >>> if is_windows >>> - subdir_done() >>> + subdir_done() >>> endif >>> >>> -drivers = ['null', 'turbo_sw', 'fpga_lte_fec', 'fpga_5gnr_fec', 'acc100'] >>> +drivers = ['null', >>> + 'turbo_sw', >>> + 'fpga_lte_fec', >>> + 'fpga_5gnr_fec', >>> + 'acc100'] >> It looks like it is more than 4 spaces here (and many similar >> cases below), but previous patch and longs lists below in the >> file use 4 spaces alignment. > Yes, for indenting line continuations, I've tended to prefer to use a > double-indent, and save single indent for new blocks of code. I see. May be it is better to put the first 'null' and the last 'acc100' on its own line with trailing comma? Also shouldn't the list be alpha-numerically sorted?