From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0072.outbound.protection.outlook.com [104.47.40.72]) by dpdk.org (Postfix) with ESMTP id C287D2BBE for ; Fri, 15 Sep 2017 14:32:39 +0200 (CEST) Received: from BLUPR0301CA0022.namprd03.prod.outlook.com (10.162.113.160) by CY1PR03MB2362.namprd03.prod.outlook.com (10.166.207.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Fri, 15 Sep 2017 12:32:38 +0000 Received: from BL2FFO11FD049.protection.gbl (2a01:111:f400:7c09::157) by BLUPR0301CA0022.outlook.office365.com (2a01:111:e400:5259::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11 via Frontend Transport; Fri, 15 Sep 2017 12:32:38 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD049.mail.protection.outlook.com (10.173.161.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.13.11 via Frontend Transport; Fri, 15 Sep 2017 12:32:37 +0000 Received: from [10.232.133.65] (B10814-12.ap.freescale.net [10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8FCWZBi030222; Fri, 15 Sep 2017 05:32:35 -0700 To: Ferruh Yigit , References: <1503658183-4078-1-git-send-email-hemant.agrawal@nxp.com> <1504860327-18451-1-git-send-email-hemant.agrawal@nxp.com> <1504860327-18451-6-git-send-email-hemant.agrawal@nxp.com> CC: From: Hemant Agrawal Message-ID: <5cfadffd-0370-412a-715e-f397e6714077@nxp.com> Date: Fri, 15 Sep 2017 18:02:34 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131499523577984890; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(376002)(39860400002)(346002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(189002)(377454003)(24454002)(199003)(305945005)(81156014)(81166006)(8936002)(106466001)(105606002)(85426001)(8676002)(83506001)(68736007)(47776003)(2950100002)(316002)(58126008)(229853002)(2906002)(356003)(189998001)(498600001)(65956001)(65806001)(86362001)(36756003)(4326008)(5660300001)(97736004)(31696002)(50466002)(65826007)(104016004)(8656003)(93886005)(31686004)(77096006)(230700001)(23676002)(33646002)(54356999)(64126003)(76176999)(53936002)(53546010)(6246003)(50986999)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2362; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD049; 1:zj56F1/qqDFItbhTtWPKegM0MyLVvzM2oyLKBCa8zPzFKJuNZ+RHqzJjh5cxjUoyUDAvC3UUAaFpKTSseSvm1ZlV4CYIyJIyYNqJBpgx1fIlIWADDmpCd0XZ6PXhN8AX X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 871ab4ab-e547-4e32-b77a-08d4fc35d976 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR03MB2362; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 3:AVpddO8kBad0BAx82PmHVlSl/g5RkDsTiiig3MK3hzSt7apy7v7O96iKbc5ajzBnYr44cw9hv2ADwTw2BY/dKk5QfnbQ2MUz0aRfxZncsD+VUOYFtNkqVjWz7MKtQuz7Fb5OEBLNMPDgYyG9m+LcDiA856OiGTWEGvYxAebzc9wAev/weiUVmiQZhYl1bJAyStULN0xX160fpj0PIgntoXiMeZ/2mWHGQVQzo2MK2Z8bpNg5GtZMZfRMRdisXvB6Cl3eN8WQVKU9RTV2+7890VcBejVjUaa0tYpNoFZOtvsBnTw4vcl9mOVNfYZpsLYMRHlmb+6AKgNc0xf5vjPBDgVEsFQiVU0dct/1Xp0OpiA=; 25:KdH2NLB/Z+dKh/0BtOEOxXFUqiXxGDEzy8E5a700YIq5joWkwWLMF2ZrcsYpPwEk/nqCPqx9aV7ghsDxWrUWSHYGPeLyCdezMzPu2+lqTdnfU8gqrWFSSI7x8OHyw/C5aBZhgWtNzcLVOlIaVyADFXuhC2ZGeO7FtTYUZOM3uzgEkA6bIqCULLKZQL/9BUfMK8tiZNyeWvFB5SFnIsD0n3GIm6ZCoY1en7MAPibS+rdzbuf8ctsav4UalLz0a5ftLLggZdZgw/LfRyq3XZG0cyvsXFYJ5DyScIrNm86UrjINyC4Xais3WqwcUQVqxn54MXpVAgEGzJzljLBzkLXE4A== X-MS-TrafficTypeDiagnostic: CY1PR03MB2362: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 31:B6Su7z/uVUkOPMLrzljL1NUpn5Um/Qyv3tanAJsjoKdDbuS+oQEu7y2dPxM4cjKjUKmLVztH45/m4CygnPseahE8Z/7Y350W3SjMut3uopE23QpIT4D/FgWj1kGqUCWoTfPTOkxvCm1IJKvfOv4XpIpds2jOwFDjqwNEoZXhARUqIikzyYZmOaKdVmjJZlE1h1DHl2gnwJI35OoHh2N8xxNV4YjVXcJkrrRl8QDan+g=; 4:o5KB94KxH7j/OXr5FNqStxWbMpOCIjUNGtzSStAGEgl50Z/3BIucR5yUBPpd5ZWptuAxabOhXHT6t1xbARMoB/pmdaUyd0mgGnfF2Rc+8GSoclmTqAJMRg36GeW5fx+Vg1xXrd96seeQgcieJjEwTPkrL9+X22ErnRcTYbmT9j+cCTjR7u2rP/Cg4bqELzlBPvhVDpQp6HVwEgGbmGheCqo/U34BZshwfljQGrqKMo+WJN47urkl6FpLJ6oa1+Hq268KcYmCYOXoJpTOXYNKKJGef/zJtoomnn8+WjQU8uE= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123559100)(20161123561025)(20161123556025)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123563025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2362; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2362; X-Forefront-PRVS: 0431F981D8 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzYyOzIzOittSlhlTnVqcm9vT3pOM3N3V2pGd20zOE4x?= =?utf-8?B?OHNxQnpsTWFlSm9LMjRZbFFkRVZGNStYV3VBSCtFRUVkMGY3KzB0RHFUWnV6?= =?utf-8?B?YVNtditmOVNXSm1ySml2WkhHVTlldkhIWVFGU1FRMTBKZCtmdFJINW12VnFC?= =?utf-8?B?SWtmU20zTm5SOWxwVE9qYjRFSHZ5UWtNNkhqZ3dXbjFSZFpUMVRrRmI4bUpX?= =?utf-8?B?cjYza2RSbXdJRTMwQXlDWHc5ZGtCYVFFTnFLUkhhVHJKWGh1bTNOMy9jTXU5?= =?utf-8?B?UFNlWmhOVFlTZWtkaTFGTVlhbVdRZTR3aHhra0hqUXlweEtvUW1YYXhUMWJ5?= =?utf-8?B?WkpxMWNvZ1luT3dLVEVwVnNRN3JzQTZDMmJPYjgwNHFQcVFRMXE3VVM3K3h0?= =?utf-8?B?V2t6aThnVUlRc1NoWjBYMnlxL25MSVZrOEsxUTV1RnRQV0MyaFcvOC9GWHlj?= =?utf-8?B?dVVjRC9VbzJJNG9SRFloaWYrYUgrMGgydXUzaHB4N1ZFNzlsSitKUTBhZlov?= =?utf-8?B?TWIrbGJOOVpNbjNXMUhEalNBRjV5V3VzZWJFdmFaZDJkRkNpaUF0clpDSEQ1?= =?utf-8?B?RXl3ZUZydEdpeDB2U1RadlZvb25jeUJTS2cwRHBQOThSTjlLbXNOaXhmWWkx?= =?utf-8?B?OVQyeG1mU0huZURqa3pVWnU5YWZuRlNzRzl1UEx0Z0RBblpidkI5NnNvUElH?= =?utf-8?B?QndIcFJlRU5sNlhzQjVMcUFzT3p2aEdFRnB6c0l2ZzFHYkxLWE9tRkJLeklk?= =?utf-8?B?eDl0VEdmb2ZlNU5LK2IyR3JwdmpnSFVHVUNGYVFGOWVvV3BLT3lnVi9EQkJu?= =?utf-8?B?bmdCL1hYQ1k4aC83VGRwSng5TmFQREFFbHdkUklnUHBiTlFHcTRJSkYzWGs5?= =?utf-8?B?R0xXbklQbkg1TS9xUXozMDFKdGxUd2N5MEhzR2RTRTkxUXBNd1ppNm04V0l0?= =?utf-8?B?ZHJHMnRwbFRORkt6ZnlFTjNOYnpYM2FSdTZ5bGUyTEVkQzJMRzNTNW52VXZu?= =?utf-8?B?Q0lBOTFTRCtzK0k4ZHZzM1lzQUpkMlg5OURtaEFlTENBRDVENUJya1dpZ1d0?= =?utf-8?B?U2wyVmQyQWtKbVlxMlB2Q3BCMlA0RFJRL3J6YXhEMUFzVGhYU2hqTncwWFc2?= =?utf-8?B?T1QrbWM3dGxLdDMzQWxtbE5aSlBGMFF1TWQybm10ZHRiRGxDK1U2VDRZaENn?= =?utf-8?B?bDkyb2x1ZTFMZ1VTa01rK2FIOWh4QTl0ZnhnOHM1K3haU2IwbEg3YkVOK0g3?= =?utf-8?B?bGZDT25vK053ZlMxbml0c0dwSUJhcEoyWDNCaU1xazYxVlZhb1pNcy80cEY5?= =?utf-8?B?T1FTRE9HT0puSkhlQ0FYTi8zR0pCaWZrR1VHdlZXL1IzeGJPb0hZNnhXdEN6?= =?utf-8?B?cFVlaHMvZ0pnVmFRS0hjd2Vwd0N5RjlSampXd24vZDZ6R2FUcjUrQTNvUmpE?= =?utf-8?B?bk5FY2ZWUHZodFVQNW1RTUIzcnRmbEQvWFVxRkpBRzNETVhoc3VpbnNzRVFC?= =?utf-8?B?clVzclFsMk1rQUdmL0Rmc0FKblFMUHVBQXZab3UveHJVNWRmTmdDVU5aRzlz?= =?utf-8?B?Rk9oMUI0dnpxVFVQUCtJMC9lRmluc2lDTSsvMjNSZ01OT09qMGZjSlpUa2pq?= =?utf-8?B?aVFyL1lxNmp0Ykh3NlBLZW0ySDhpN3loZ1hSemNUUEZRbUdHN21LazNBZE9u?= =?utf-8?B?WmhhOXdXZnpXRVI3ZHRNTkVyVGwraDJSN1kwVngzVlJmT1FZSTgycjFmcmZ0?= =?utf-8?B?MmcxL3d4RGZCKzB3bjB6dXdDQWhNWFN2REtzWVBMMm9nSjcySFdFUWdkZGw4?= =?utf-8?B?cWM1ZENuUDl2WVJXM0w2TGtWRVN4NVZBVU13NDhiVGVlc25SU2ZhL2xoMkJv?= =?utf-8?Q?dbhEzAacUusYNmdx7i9fWtYHPd5t7Na/?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2362; 6:gZ50gwirhq2eMJwjTYBSQwHb0n6ukFn0Riu5ff6OhZCPIBDPY4dTydU1Cn4fpw8F6SWNZYYOuHl3qplIl1B3i41ftwtM6qOIl/8RuDrvrjORpaR78me+34zju8ywcxqDIdaPiZ0UPAZbUEfT+qZWK95Hc6ggvOk7nLpWSpNExzS6T/x5pAdZjkF5dfmR6CNJNKy1LqUpYmQfXVJJsHhUP1BNEyrU4jpiwurgiV6WX+GuFw1iZ7jgR8LTGyCm83pAsaPMnHpZNBU6u7XDkNUCO7D1bTn3kaT7PEln+/Kf3HD2S+YHt4zZsv5Zt6sue97M0qocuKuvNX75mcEjb1QISQ==; 5:6rFaF+YgrPJa4CboaLU+s+WQcafu5RPF1bo9R7uG0TY89v+X1Hx10uj91JUoINB0GRrRxTTZU2fXwvRT6FckvJcIVqTMGPIwPezO/49l3yftu4H+8Du+qeqiuh/OvLlluzpKcjlyZ7U5e5yK87DEpP6i914eHUR9V5A1JFZ9MDI=; 24:VMDIubQl8BNtxfx8zaWwagacH1w6r4o/VSN3vrpBVIg8NOISlIXStZHsvfxOh2+ukpDcf7XPloOWr8kLZ81itGn3Mak0jf+zFCk7Nde90nM=; 7:9WrlBLvkn7lsr/GPDPpy0cxL39WdiJ3BIt4q3Hq86JR0yOkfPmZEDV9YEJmxVmhtxZq/ZOjIiEFDBpS2cr4XLY9HZ7dQuu61PsZRcbx0UWZa4+7aZkXvP5LR1XKvRngWx6B+6/UalA3gmw9j+S0Fl3iU76EoDkcfqSdQi3hAg8LmHDC0fPj6wbaO2iK7lCVV+zaxG3ZWlUs25obaUKLKpD1NTmUSc7T1QuBMY0m7UAo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2017 12:32:37.6268 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2362 Subject: Re: [dpdk-dev] [PATCH v2 05/30] bus/fslmc: enhance the QBMAN CENA mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 12:32:40 -0000 On 9/15/2017 5:56 PM, Ferruh Yigit wrote: > On 9/8/2017 9:45 AM, Hemant Agrawal wrote: >> From: Haiying Wang >> >> Signed-off-by: Haiying Wang >> Signed-off-by: Hemant Agrawal >> --- >> drivers/bus/fslmc/qbman/qbman_sys.h | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/drivers/bus/fslmc/qbman/qbman_sys.h b/drivers/bus/fslmc/qbman/qbman_sys.h >> index 9ea55de..47da595 100644 >> --- a/drivers/bus/fslmc/qbman/qbman_sys.h >> +++ b/drivers/bus/fslmc/qbman/qbman_sys.h >> @@ -217,7 +217,6 @@ static inline void qbman_cena_write_complete_wo_shadow(struct qbman_swp_sys *s, >> #ifdef QBMAN_CENA_TRACE >> pr_info("qbman_cena_write_complete(%p:%d:0x%03x)\n", >> s->addr_cena, s->idx, offset); >> - hexdump(cmd, 64); >> #endif >> dcbf(s->addr_cena + offset); >> } >> @@ -251,11 +250,7 @@ static inline void *qbman_cena_read_wo_shadow(struct qbman_swp_sys *s, >> { >> #ifdef QBMAN_CENA_TRACE >> pr_info("qbman_cena_read(%p:%d:0x%03x) %p\n", >> - s->addr_cena, s->idx, offset, shadow); >> -#endif >> - >> -#ifdef QBMAN_CENA_TRACE >> - hexdump(shadow, 64); >> + s->addr_cena, s->idx, offset); > > Isn't this missing one parameter, previous "shadow" one? > shadow is not existing any more. We should remove the last %p from pr_info. >> #endif >> return s->addr_cena + offset; >> } >> > >