From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 976E737B4 for ; Mon, 19 Sep 2016 19:01:41 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 19 Sep 2016 10:01:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,362,1470726000"; d="scan'208";a="763367853" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.115]) ([10.237.220.115]) by FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2016 10:01:36 -0700 From: Ferruh Yigit To: Xiao Wang , wenzhuo.lu@intel.com References: <1472312902-16963-1-git-send-email-xiao.w.wang@intel.com> <1472312902-16963-3-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org Message-ID: <5cff68ac-1685-1f6f-635d-33d99f0a9c07@intel.com> Date: Mon, 19 Sep 2016 18:01:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1472312902-16963-3-git-send-email-xiao.w.wang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 02/39] net/ixgbe/base: remove X550em SFP iXFI setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 17:01:42 -0000 On 8/27/2016 4:47 PM, Xiao Wang wrote: > This patch removes X550em SFP iXFI setup for the drivers since there > is no released hardware production with SFP iXFI. XFI? > > Signed-off-by: Xiao Wang > --- > drivers/net/ixgbe/base/ixgbe_x550.c | 57 +++++++------------------------------ > 1 file changed, 11 insertions(+), 46 deletions(-) > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c > index aa6e859..b8fdb00 100644 > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > @@ -2460,53 +2460,18 @@ s32 ixgbe_setup_mac_link_sfp_x550em(struct ixgbe_hw *hw, > if (ret_val != IXGBE_SUCCESS) > return ret_val; > > - if (!(hw->phy.nw_mng_if_sel & IXGBE_NW_MNG_IF_SEL_INT_PHY_MODE)) { > - /* Configure CS4227 LINE side to 10G SR. */ > - reg_slice = IXGBE_CS4227_LINE_SPARE22_MSB + > - (hw->bus.lan_id << 12); > - reg_val = IXGBE_CS4227_SPEED_10G; > - ret_val = hw->link.ops.write_link(hw, hw->link.addr, reg_slice, > - reg_val); > - > - reg_slice = IXGBE_CS4227_LINE_SPARE24_LSB + > - (hw->bus.lan_id << 12); > + /* Configure internal PHY for KR/KX. */ > + ixgbe_setup_kr_speed_x550em(hw, speed); > + > + /* Configure CS4227 LINE side to proper mode. */ > + reg_slice = IXGBE_CS4227_LINE_SPARE24_LSB + > + (hw->bus.lan_id << 12); These lines can join