From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 736F158CE for ; Mon, 29 May 2017 19:44:36 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2017 10:44:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,415,1491289200"; d="scan'208";a="267757407" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by fmsmga004.fm.intel.com with ESMTP; 29 May 2017 10:44:34 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20170526183941.80678-1-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <5d0e287f-dfe9-3a41-695e-9af0d57d37c1@intel.com> Date: Mon, 29 May 2017 18:44:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170526183941.80678-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 00/25] bnxt patchset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 17:44:36 -0000 On 5/26/2017 7:39 PM, Ajit Khaparde wrote: > This patchset amongst other changes adds support few more dev_ops, > updates HWRM to version 1.7.7, switches to polling stats from the > hardware, support for Jumbo MTU, LRO etc.. > As suggedted for the previous submission: > Grouped in the end, it also has PMD specific APIs to control VF from PF. > I have updated the release notes and the features file wherever possible. > > -- > bnxt: update to new HWRM version > bnxt: code reorg to properly allocate resources for PF/VF > bnxt: handle VF/PF initialization appropriately > bnxt: support lack of huge pages > bnxt: add additonal HWRM debug info to error messages > bnxt: add tunneling support > bnxt: add support for xstats get/reset > bnxt: Add support for VLAN filter and strip dev_ops > bnxt: add support for set multicast addr list and MAC addr set > bnxt: add support for fw_version_get dev_op > bnxt: add support to set MTU > bnxt: add support for LRO > bnxt: add rxq/txq info_get dev_ops > bnxt: add code to support VLAN pvid set dev_op > bnxt: reorg the query stats code > bnxt: add support for led on/off > bnxt: add support for tx loopback, set vf mac and queues drop > bnxt: add support for set VF QOS and MAC anti spoof > bnxt: add support for VLAN stripq, anti spoof and filtering for VFs > bnxt: add support to get and clear VF specific stats > bnxt: add code to determine the Rx status of VF > bnxt: add support to add a VF MAC address > bnxt: add code to configure a default VF VLAN > bnxt: Add support to set VF rxmode > update release notes I have sent some comments for the patchset. Also generic to the whole patchset, there are a few minor details it would be helpful if you can apply in next version of the patchset (otherwise maintainers have to fix them) : - rebase patchset on top of latest next-net, there are two easy to fix conflicts because of merged patches to next-net - patch subject starts with "next/bnxt: " for driver and "doc: " for document patch. - in patch subject, after ":", sentences starts with lowercase char - instead mentioning added dev_ops name in the patch subject, it would be better to mention feature added. Thanks, ferruh