From: Matthew Hall <mhall@mhcomputing.net>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl
Date: Mon, 21 Jul 2014 09:53:45 -0700 [thread overview]
Message-ID: <5d0e56af-1662-4e4a-b942-4da275234d5f@email.android.com> (raw)
In-Reply-To: <1882677.eVWsvu6oSK@xps13>
The same code is used in l3fwd and l3fwd-acl. When it is reused in l3fwd-acl a packet processing function from original l3fwd is not used any more.
--
Sent from my mobile device.
On July 21, 2014 6:44:41 AM PDT, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>Hi,
>
>2014-07-20 20:47, Matthew Hall:
>> +CFLAGS += -Wno-unused-function
>
>I think it's better to fix the code instead of removing a warning.
>If there is a very good reason to not do it, it would appear in the
>log.
>
>Thanks
next prev parent reply other threads:[~2014-07-21 17:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 3:47 [dpdk-dev] [PATCH] examples: fix clang compilation issues Matthew Hall
2014-07-21 3:47 ` [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl Matthew Hall
2014-07-21 13:44 ` Thomas Monjalon
2014-07-21 16:53 ` Matthew Hall [this message]
2014-07-21 17:37 ` Richardson, Bruce
2014-07-21 3:47 ` [dpdk-dev] [PATCH 2/4] virtio-net.c: incorrect parens around equality check Matthew Hall
2014-07-22 13:14 ` Thomas Monjalon
2014-07-22 19:27 ` Matthew Hall
2014-07-21 3:47 ` [dpdk-dev] [PATCH 3/4] examples/*: -Wno-switch required for weird ioctl() ID's Matthew Hall
2014-07-21 13:45 ` Thomas Monjalon
2014-07-21 3:47 ` [dpdk-dev] [PATCH 4/4] rte.extvars.mk: allow user to override RTE_SDK_BIN Matthew Hall
2014-07-21 14:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0e56af-1662-4e4a-b942-4da275234d5f@email.android.com \
--to=mhall@mhcomputing.net \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).