From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186]) by dpdk.org (Postfix) with ESMTP id 53B9C595A for ; Mon, 21 Jul 2014 19:22:04 +0200 (CEST) Received: from [192.168.0.34] (172-3-139-73.lightspeed.sntcca.sbcglobal.net [172.3.139.73]) by mail.mhcomputing.net (Postfix) with ESMTPSA id 8C48580BDB3; Mon, 21 Jul 2014 10:22:46 -0700 (PDT) User-Agent: K-9 Mail for Android In-Reply-To: <1882677.eVWsvu6oSK@xps13> References: <1405914461-19335-1-git-send-email-mhall@mhcomputing.net> <1405914461-19335-2-git-send-email-mhall@mhcomputing.net> <1882677.eVWsvu6oSK@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 From: Matthew Hall Date: Mon, 21 Jul 2014 09:53:45 -0700 To: Thomas Monjalon Message-ID: <5d0e56af-1662-4e4a-b942-4da275234d5f@email.android.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/4] l3fwd: some functions are unused in l3fwd-acl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2014 17:22:04 -0000 The same code is used in l3fwd and l3fwd-acl. When it is reused in l3fwd-acl a packet processing function from original l3fwd is not used any more. -- Sent from my mobile device. On July 21, 2014 6:44:41 AM PDT, Thomas Monjalon wrote: >Hi, > >2014-07-20 20:47, Matthew Hall: >> +CFLAGS += -Wno-unused-function > >I think it's better to fix the code instead of removing a warning. >If there is a very good reason to not do it, it would appear in the >log. > >Thanks