From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72DE843C9F; Wed, 13 Mar 2024 12:25:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 308BF40A84; Wed, 13 Mar 2024 12:25:51 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 28758402B8 for ; Wed, 13 Mar 2024 12:25:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfL5D7swhskoFsKmz5fgFTR3KcAC6aSyUurNxJpJc9n2g0N65OiX2yAsYo9UXcfeg/vQKNDyn4FwZIRO7ekUTr6gbKEulgvSW6MjaabSwrvt/Kr3Lm3s/yNwrWBCt8NM8tbsZOwb9pEcmnbTjNF7Qa+k4E/9zxA4udUHUm0mU4UpjUZx6xs6LRJi2dYcdz1ENYG+MaSn3Y9Uv9KbksOL+dkA2KAcHMT33eN4IUZ9VIynfU1jv8fdrj3cQ6/dqNieGk/bvnoClaX6xoClyKA6YIsqEIZwgvUOcqx1Ep9yUfQu+4Mn6TOtskw/I9T84moFVUcHEvMKVbvyJ7OVP25rYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a50E8E73zFgNMngjQ4VPQvrrXnauD9h1gG4u98MAzgs=; b=nKXgkIg306uV8GosSpiazQytpyjU93GhGEJdDZcK3dvN/YkY4UeLrzFUZjMBXgicIKvjNrxSQT9V7sik5P5R5ysW45gM09acRQmXDCyHEmda1u0024dcu9LmNMlWRcqDNw21bm46TQpuBvT4/qjzmvM/tibEybhBxdX5fX1dww6ihk5uad+xzGByWAuK2OgU8bqqp5dehBznc8nRygtSh8dAhziDENevD7UoOnAlwfeCL3TdzysqWPSxWn6Fx9KpKcJ0XBdVTNQIHIRV6kA/XgT0Go5VzrPrGBVbAFmZGApRHt3Ez8npr1ulbTM/+pYhv176Ewtujm0edARXrNYh+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a50E8E73zFgNMngjQ4VPQvrrXnauD9h1gG4u98MAzgs=; b=sC6WypCUx4SisRxBGVKTdIJ28cseYCup5b5PX7Ifm8blwsRbpyiwGMe3ZkXul7fw0pMNywg16HF3TSEjNj6A8M3gFTTT7uv1n7MrA/Sgk2NEEm7xmb9TzZHUPiSAqWUebRbOoDgTTTzxhi7PmxZmhXquZWVQ++qTib27rEw7nH0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7371.namprd12.prod.outlook.com (2603:10b6:806:29a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar 2024 11:25:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 11:25:48 +0000 Message-ID: <5d194cf0-0093-40d9-bd1f-a84bdbe497bf@amd.com> Date: Wed, 13 Mar 2024 11:25:44 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/33] net/ena/hal: exponential backoff exp limit Content-Language: en-US To: "Brandes, Shai" Cc: "dev@dpdk.org" References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-9-shaibran@amazon.com> <76154018-868a-481e-9922-ed5bd166d90a@amd.com> <4b6abd5ff30440f3b7edf1b3f4f9e67b@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <4b6abd5ff30440f3b7edf1b3f4f9e67b@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0104.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7371:EE_ X-MS-Office365-Filtering-Correlation-Id: efa15b93-3a1c-4b6b-f416-08dc435054ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IVlpj1p9DooypiWpQdQ1Doz892tpJ5A/1QfO+8bPPc7p25mf7ZuXiKeCMaTSB+wMOezT08ytAy6xLKtFnYkMiAVYNcKflhOqavJ8BNyKYhV2wuu5ECGz9jUzJocsbT86qiBVtDXAu19il7Uzsvx4BYF4AcpDNzmzlOXnKRO6m7U9d4vy9Io9xes/0TFFYrYLQ3j34b/3z9nMOKqDQlDFzmJiVLmZEkJ0zncDUCUgBOUai6ftj366G5AYuz5tmLlQpe3wsf2i4qPCR0t3xmiTawIl3yGT3rZk3XzhQ+W/TpaCIpcQK+sLfXHu0d672Z/o1VZEANxw86eYm+BVnfw4/clSFWgLQ3QuGjqocoaMh7nuM7Zo1pojv7flyLe+gA1kopckYbDS7FRIhSgkPZHQUuNB5/FC87fB5+PkcMu1HtfWQrbS46UA0nZszPsxhO3DRX33qtE37+rJDnqy1SLuhqK2JGUGesu/nZ6lsWkXXHA3nrQgAh+UsmnBkzOEf1nrtQHzhcGSoCTmNeNGkVIJh92EeUt//vElvTYfxhTda9XxhQ3LJfY6efN2XyfE9Hv9s7he6XYY9vb/RHo2UhxAs3CrzYt2wb6A2Id/KAfewHDMy/UsNCdojmaLD+ghkiYlf+kUqjbZoMm2t5fzV7rH7zenq52YKXM85KDbEWixJMk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHVqNHF1NHMxUkRrM0c2MkF3cEVCMVhhYjBvaXkrUFhNR2VvUXBmdXJVYXRF?= =?utf-8?B?TklFWlhGZytLNVdkTHZHSWpNbnlVZlZHUEZ1Z0RpZVFZL2MrZkVyNCtrR0cr?= =?utf-8?B?WXkxY3F3U0FrWHR3a3M3QUQvRTc3WGlPYTRabjVIWmxVYnNmTWdaNjFNTlpO?= =?utf-8?B?amVKNWJrdGRjUWlyTm1ZTjhJd0s2OWxQWTV4M1dnL2g0dXZ3c3RlVkw1SlR2?= =?utf-8?B?Z0pZNEFBNVI5ZFR2ZEJwY2lkWk0yMnRPU29BT0tZenZ4dkhjUk5CN0h2cHA3?= =?utf-8?B?bnllcEhva3ZhbkJUUFlqY1kwd3cwTmRTRXNYdUltMUFjTldhT0VpZGVLL2Ey?= =?utf-8?B?emkzOThUQS9IS1JONzgrUXE4bUhJZjNXeUFNR25QYUR4R0lqcFMxUlhrbTB6?= =?utf-8?B?aUlLKy9Yend1b0hNNmdhTlRaZXVnSVZaNXoxRXR2dGw3WE5oanJXaVpQR1VI?= =?utf-8?B?NkI0L0tETS94VWw3T2ZwS1NSK0VaYlhRUWdOTWFvRC8yME1qYUk4dTlSSGU3?= =?utf-8?B?b055bkt3ZVlRTzk3YTlLOVVIRnU5YkNjeDljaHNrczhoYXdoSVFsSkYrUGRI?= =?utf-8?B?Q0hPR1hSM0VvMWJ4VHQxdk5TTGlickRRSFErT1pTSFE0Vi8vWUMxOWEwbWpj?= =?utf-8?B?UjhjS0dBVWQ5WmpZdVBuSGRDa3lKTmtDNSs3TzQyN05YQzA4UmkybytWbVNT?= =?utf-8?B?K09YNVEzMEd1blo5MkdwMyt2Q2htd3VjSm5DK3lGeWU2MTRTM0trU3V6Nmg5?= =?utf-8?B?elV6bURsSmVvOG9RSUNqUm1KQi9GNm5aa1QrMEZyb3Z0VFd2WFJDV2lGbGxL?= =?utf-8?B?V25SekRSRk9zR2l4WE5nQjAzM0k2Zm1tWnRXcStSbW51WXZyNHE0Yzh3dkcx?= =?utf-8?B?ekR4a1hjZkRHQWtDdFFoQWJadkRsblQxV3Y1VXNncjBGYmpZb3BvenRaZVEz?= =?utf-8?B?UkxMM3ZiYkhQdTZBWExhVjZTb2VsaWJ6dWd0Z2VvLzFaVkhIZUpidU9BWDFo?= =?utf-8?B?NTJudFp0NHFhandoOFhuQUI2Vm1DK2tXOGhvY2R4QVZJRW5RaGd3SU9PMklJ?= =?utf-8?B?K1k3VDZiZ1VDMUlaNlBwM2wxaU5yaTJaRjQ2aWM5Um0xckZ0eFlWUnhuUm8z?= =?utf-8?B?VnpDUkFXb01qZlZMandXakxiSDd1Vm5TZi9QdDRwV0FkWENGOUtwQlZOUzZr?= =?utf-8?B?THZFcWdUb3pQdEpuNlJOT2swUXBWQ2wxQjF5Y0lmUzFNZ0NrNFc4Q2tNRitj?= =?utf-8?B?L054K0xPREE2OWtMV2NJcFdWUFUxVkxORmtMOEQ3S1AzMTNTVVhRUHVtdU91?= =?utf-8?B?dGZHUUZvNHQ1Zy81VVhTV3J1R2V5K1VZUXhqcUUwZ1lzOU4xK3Bpa2laZTdR?= =?utf-8?B?Qm95SVNaVTd6TGhiSzNGcEZTOGpoZVVQcldpa2lIMUFoWlk5MEdGSXpTbkpu?= =?utf-8?B?ZnpROS93TEtTU216UE1vY1F4RWJKdTdvUjJaVk9zalJXc2psMjV6STN5YmVC?= =?utf-8?B?MWovMUUzNkR6dVlqVWZ0WHhaLytEQWw4dlRyZFFIU29hdzVJUXAydHRtNVFX?= =?utf-8?B?TEg0NmMxb1ViWit2RlJqd0dyYXRpajMxTzRXRWkvbVVkdjMwNzBhNER1VjJG?= =?utf-8?B?SEpEcXdrNzNaNWthZHpBNzZXUVFYeWQ1WUQyQWRDcUhvWGxNdFNNeEJ6aGwv?= =?utf-8?B?YjJ1N0hLd0srN2dKOU5PQ1RkUWcraUtjVFo0OVZTdWNvaldYdU5iRFlpbVI0?= =?utf-8?B?cTlNaXMxY0FXYnowdkJnQXFOblRhbVRrcHM1dEZWNzM3Q2ZUQmZNZHpHcEhL?= =?utf-8?B?UmVRdCtuUUxLWjM1WG9BazBMRkZEeEhTdVE2Nm1HQmU4V3dnSXI4bE9KQXo3?= =?utf-8?B?ZURmOWJjeVBRME95OHBNbktlUktrY0IrV0hIc3h1eU4vNWNXb0ZldFErT2pt?= =?utf-8?B?WGRoOEJ2aStsZDM0UFFwSm9qU015dldIM0o0VU1qM2FnK1E5YXhzZE1qbkMx?= =?utf-8?B?Rldnc1BMaFpBbnZVdHlMV2twSDU5ZWgrTGVCWDdtRk1xaFZhaXhGRnJFZy95?= =?utf-8?B?SVlTT09Va2dSUXBScG5nSXM2UlZzY2t2UC9qQmpuenp5b0pSSXlnYVB6VUhn?= =?utf-8?Q?WVhM5+vFJpuZh+W4yqB6GV8Iy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: efa15b93-3a1c-4b6b-f416-08dc435054ef X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 11:25:48.3279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cQiZWhYXuZe6h2dDHIehb/0OVzPbwPr+DrQ5M+RDJ6X3sf8tWf6p9qYl0voasHhP X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7371 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/12/2024 4:53 PM, Brandes, Shai wrote: > > >> -----Original Message----- >> From: Brandes, Shai >> Sent: Sunday, March 10, 2024 4:54 PM >> To: 'Ferruh Yigit' >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 08/33] net/ena/hal: exponential backoff >> exp limit >> >> >> >>> -----Original Message----- >>> From: Ferruh Yigit >>> Sent: Friday, March 8, 2024 7:24 PM >>> To: Brandes, Shai >>> Cc: dev@dpdk.org >>> Subject: RE: [EXTERNAL] [PATCH v3 08/33] net/ena/hal: exponential >>> backoff exp limit >>> >>> CAUTION: This email originated from outside of the organization. Do >>> not click links or open attachments unless you can confirm the sender >>> and know the content is safe. >>> >>> >>> >>> On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: >>>> From: Shai Brandes >>>> >>>> limits the exponent in the exponential backoff mechanism in order to >>>> avoid the value overflowing. >>>> >>> >>> Is this a fix? > [Brandes, Shai] No, this is originated from a backport from the Linux community to our HAL. > The backoff mechanism is used to delay device reset, command completion checks, etc. > The backoff eventually could cause the delay to become excessive (1<<32). > So, this patch cap the backoff value of the exponent used for this backoff at (1<<16). > In addition, for uniformity and readability purposes, the min/max parameter > in the calls of ENA_MIN32 and ENA_MAX32 macros was changed to be first. > I think this fixes the device reset. Without cap in the backoff value, delay can be too long (depending input to the function) so that can't reset the device. But anyway, thanks for the clarification. > >>> >>> What was the impact of the overflowing if not limited? And is there a >>> significance of the value 16, can you please elaborate? >>> >> [Brandes, Shai] I will restructure this patch, since this likely hides a fix in hal. >> It is originated from the HAL release, from which I took the patches one by >> one, but the commit messages there tend to be (too) concise. >> >>> >>> Also let me remind the patch subject format, (this may look >>> insignificant but helps to have more unified commit messages for >>> developers, and if not updated by author, maintainers update it and >>> this brings more overhead to >>> maintainers): >>> "sub-module: verb object" >>> >>> And we use verb 'fix' explicitly for all commits fixing something, and >>> that something can't be referenced as 'error', 'failure', 'issue', >>> 'problem', etc... but it should be detailed. >>> >>> Most of the times better to document NOT from driver internal >>> perspective, but impact of it, like "net/ena: set chain limit to 16" >>> is NOT a good one, it explains driver internal perspective (making all >>> up) but it can be something >>> like: >>> "net/ena: support big packets by increasing link limit" >>> >>> For this one, I am not sure impact of the change so hard for me to >>> propose an alternative, but just as example it can be something like: >>> "net/ena/base: avoid collision by limiting backoff delay" >>> >>>> Signed-off-by: Shai Brandes >>>> Reviewed-by: Amit Bernstein >>>> --- >>>> drivers/net/ena/hal/ena_com.c | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/ena/hal/ena_com.c >>>> b/drivers/net/ena/hal/ena_com.c index 6953a1fa33..31c37b0ab3 100644 >>>> --- a/drivers/net/ena/hal/ena_com.c >>>> +++ b/drivers/net/ena/hal/ena_com.c >>>> @@ -34,6 +34,8 @@ >>>> >>>> #define ENA_REGS_ADMIN_INTR_MASK 1 >>>> >>>> +#define ENA_MAX_BACKOFF_DELAY_EXP 16U >>>> + >>>> #define ENA_MIN_ADMIN_POLL_US 100 >>>> >>>> #define ENA_MAX_ADMIN_POLL_US 5000 >>>> @@ -545,8 +547,9 @@ static int ena_com_comp_status_to_errno(struct >>>> ena_com_admin_queue *admin_queue, >>>> >>>> static void ena_delay_exponential_backoff_us(u32 exp, u32 delay_us) >>>> { >>>> + exp = ENA_MIN32(ENA_MAX_BACKOFF_DELAY_EXP, exp); >>>> delay_us = ENA_MAX32(ENA_MIN_ADMIN_POLL_US, delay_us); >>>> - delay_us = ENA_MIN32(delay_us * (1U << exp), >>> ENA_MAX_ADMIN_POLL_US); >>>> + delay_us = ENA_MIN32(ENA_MAX_ADMIN_POLL_US, delay_us * >> (1U >>> << >>>> + exp)); >>>> ENA_USLEEP(delay_us); >>>> } >>>> >