From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DEFB45954; Tue, 10 Sep 2024 11:01:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07A3042E54; Tue, 10 Sep 2024 11:00:24 +0200 (CEST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by mails.dpdk.org (Postfix) with ESMTP id 3DFCE42E46 for ; Tue, 10 Sep 2024 11:00:22 +0200 (CEST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a8d24f98215so401689666b.1 for ; Tue, 10 Sep 2024 02:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725958822; x=1726563622; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xW6xiuercqsxNOuua6yiVY7CHCYDA9dW4REC5faABaw=; b=m6Mqvg/rLhLkajk5NSbaNi5mMhV50DZpVj+qFtIDhfWP4kQFEDn0Y7UrMZcY2ZzdNS W0idoyk0G4Yq6n/AdBxDdco6GxNR4KZNix0TTb+LE2QBjzcKlSlL9hN/vAB4/9VyKRC5 k5oKPlQvBKCcpihh40guDSEs1rdZKOzbK01M0pn+x7KU4rA7MwNvbtrW48pUCLJm/UgT PLm7G482PwrWyD+ZIO3uopRWucFeFQkalz8SsNln4uY3uitpjiHZPTGlrMGTybxx8bt+ dEGjiSkn5/jWqyHGSxNxX+o3Msv4c4P+vgsTbSih3Ajd2W9/OvzHJCUzXzOVJOH2F/f6 4hsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725958822; x=1726563622; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xW6xiuercqsxNOuua6yiVY7CHCYDA9dW4REC5faABaw=; b=hSyGhakx//DFehTYq87RI0H6Xdpn57DYuURdmGiZ0M5jpcUBebA3mFaB9JMkONlDoJ Lo0sLfCi3YDEenTx9y/WtgQjZ4APZ6vzNxWsg75f0APs1koEtRtPr9NCALy5gsNtd8zv rtqAZHOD/kCpkO4awxOG2hbAu8fzmA9uG6+iWvSlSGLyifvhpEuQKrjllwAa5XgHh1yR S6DmjHHnhcbTW8UatV44+0BYF11BRlWrpa1ysjibNW6vt5dvtHnnuS3lven4fOP5wQyH 4w/iaT7a5iYZhN5BV3CO0wUheyK8E6EUZQ1BWhTMcG3gtAl7HoItCbAqe+8JAe8c3eMH AtxA== X-Forwarded-Encrypted: i=1; AJvYcCUtlZS6kVmGdVSAPas41MmmHIOMC6cu8WA5dN9gwcBaIOEf2sqSDr7JdU4WDZkf+KQVTuk=@dpdk.org X-Gm-Message-State: AOJu0Yx9vSaIoa+JIPEcp+O7+ql2d/A4+Iu6GclGkt9msm8/kyIugsiH hlMf+Cu03pZIj8Yebdq3ZgnlGfzV0k3qu+VIEtQkGUlcy5AFUmoSSjNZHJSGSB8= X-Google-Smtp-Source: AGHT+IH+XgamTjWC33sQZEmdb7XYKqqTA1BKjfHJoS+IbaChIbXddjgbu0cZqeziADxli1aUwZFC5A== X-Received: by 2002:a17:907:8688:b0:a8a:86f8:4eed with SMTP id a640c23a62f3a-a8ffaa92959mr6185166b.10.1725958821661; Tue, 10 Sep 2024 02:00:21 -0700 (PDT) Received: from [10.12.0.236] (81.89.53.154.host.vnet.sk. [81.89.53.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d2583179csm454449566b.42.2024.09.10.02.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 02:00:21 -0700 (PDT) Message-ID: <5d3a6f20-2418-42ee-89df-cad63e6f5978@pantheon.tech> Date: Tue, 10 Sep 2024 11:00:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] dts: Testbed And Node Configuration Split To: Jeremy Spewock , Nicholas Pratte Cc: luca.vizzarro@arm.com, probb@iol.unh.edu, bruce.richardson@intel.com, yoan.picchi@foss.arm.com, paul.szczepanek@arm.com, Honnappa.Nagarahalli@arm.com, dev@dpdk.org References: <20240610193410.17968-2-npratte@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 14. 6. 2024 20:27, Jeremy Spewock wrote: > I think this is definitely a step in the right direction in terms of > how we structure the config files. Something that I think could also > be a cool improvement for how we handle configs is just making a > `conf/` directory and then taking all of the configuration in each of > the yaml files present in the directory and combining them into one > config in the framework like we have now. That's definitely a larger > undertaking however, this split will save space if users want to > specify more than one host or use the same execution configuration > between different node configurations and I think that is an > improvement on its own. > I like this suggestion. When we have multiple config files, it just makes sense to group them. > On Mon, Jun 10, 2024 at 3:34 PM Nicholas Pratte wrote: >> >> This implementation splits the execution and node configuration >> components of the conf.yaml into two separate config files. A >> new command line argument is added, allowing the user to specify >> both a node configuration file and an execution configuration >> file. Be default, these config files are now named node_conf.yaml and >> execution_conf.yaml, respectively. >> >> To assert these changes, the schema calls for one of these objects, >> nodes or executions, in each file, but neither config file can have >> both. >> >> To avoid excess refactoring, both config files are merged together >> early on in the load_config process. >> >> Bugzilla ID: 1344 >> >> Signed-off-by: Nicholas Pratte >> --- > >> diff --git a/dts/testbed_conf.yaml b/dts/testbed_conf.yaml >> new file mode 100644 >> index 0000000000..af2180eac2 >> --- /dev/null >> +++ b/dts/testbed_conf.yaml > > I don't think this file is used anywhere and it looks like another > name for the execution_conf.yaml so we likely don't need it. > We actually don't want the execution_conf.yaml file (and use testbed_conf.yaml), but the point stands - there are two files that are the same. >> @@ -0,0 +1,26 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright 2022-2023 The DPDK contributors >> +# Copyright 2023 Arm Limited >> + >> +executions: >> + # define one execution environment >> + - build_targets: >> + - arch: x86_64 >> + os: linux >> + cpu: native >> + # the combination of the following two makes CC="ccache gcc" >> + compiler: gcc >> + compiler_wrapper: ccache >> + perf: false # disable performance testing >> + func: true # enable functional testing >> + skip_smoke_tests: false # optional >> + test_suites: # the following test suites will be run in their entirety >> + - hello_world >> + - os_udp >> + # The machine running the DPDK test executable >> + system_under_test_node: >> + node_name: "SUT 1" >> + vdevs: # optional; if removed, vdevs won't be used in the execution >> + - "crypto_openssl" >> + # Traffic generator node to use for this execution environment >> + traffic_generator_node: "TG 1" >> \ No newline at end of file >> -- >> 2.44.0 >>