From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id E1C801041 for ; Wed, 28 Mar 2018 13:58:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 148AF8185928; Wed, 28 Mar 2018 11:58:58 +0000 (UTC) Received: from [10.36.112.44] (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 784C51C722; Wed, 28 Mar 2018 11:58:53 +0000 (UTC) To: Anatoly Burakov , dev@dpdk.org Cc: Yuanhan Liu , Tiwei Bie , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com References: <46388b194cd559b5cf7079e01b04bf67a99b64d7.1520428025.git.anatoly.burakov@intel.com> From: Maxime Coquelin Message-ID: <5d3c4d86-0fda-7a17-7d9e-0f1abce540bd@redhat.com> Date: Wed, 28 Mar 2018 13:58:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <46388b194cd559b5cf7079e01b04bf67a99b64d7.1520428025.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 28 Mar 2018 11:58:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 28 Mar 2018 11:58:58 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2 40/41] net/virtio: use contiguous allocation for DMA memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 11:59:00 -0000 Hi Anatoly, On 03/07/2018 05:57 PM, Anatoly Burakov wrote: > Signed-off-by: Anatoly Burakov > Reviewed-by: Venkatesh Srinivas > --- > > Notes: > Not sure if virtio needs to allocate DMA-capable memory, > being a software driver and all. Corrections welcome. Yes, we need the ring memory to be contiguous in physical address space. > drivers/net/virtio/virtio_ethdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) So: Reviewed-by: Maxime Coquelin Thanks, Maxime