DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>, dev@dpdk.org
Cc: bluca@debian.org, luoxianjun@huawei.com, luoxingyu@huawei.com,
	zhouguoyang@huawei.com, shahar.belkar@huawei.com,
	yin.yinshi@huawei.com, david.yangxiaoliang@huawei.com,
	zhaohui8@huawei.com, zhengjingzhou@huawei.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/4] net/hinic: increase Tx/Rx queues non-null judgment
Date: Mon, 11 May 2020 20:09:03 +0100	[thread overview]
Message-ID: <5d966a99-d066-4179-824d-3dc3f523fe1c@intel.com> (raw)
In-Reply-To: <034a9a94e90cfffdeee2b7c37d000977860705ba.1588991713.git.cloud.wangxiaoyun@huawei.com>

On 5/9/2020 5:04 AM, Xiaoyun wang wrote:
> Increase tx_queues and rx_queues non-null judgment before free tx or
> rx resources, and modify some formate for logs.

The fix is small, but it is lost in the format/syntax changes, can you please
seperate the fix.

Btw, fix is adding null check for pointer, does it case any crash if not fixed,
if so better to mention it in the commit log, to set the priority right, instead
of saying increse judgment which looks like optional change.

> 
> Fixes: 54faba2295bd ("net/hinic: adds Tx queue xstats members")

Can you please double check the fixed commit, this looks unrelated. Why do you
think this is the commit that creates the code that has been fixed in this patch?

> 
> Cc: stable@dpdk.org
> Signed-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>

<...>

> @@ -313,6 +313,8 @@ static inline struct rte_mbuf *hinic_copy_tx_mbuf(struct hinic_nic_dev *nic_dev,
>  		mbuf = mbuf->next;
>  	}
>  
> +	dst_mbuf->pkt_len = dst_mbuf->data_len;
> +

This change is unrelated and not mentioned in the commit logs, can you please
separate it to its own patch, so it can get the description it deserves.

  reply	other threads:[~2020-05-11 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  4:04 [dpdk-dev] [PATCH v5 0/4] Support ipv6 flow rules Xiaoyun wang
2020-05-09  4:04 ` [dpdk-dev] [PATCH v5 1/4] net/hinic: increase Tx/Rx queues non-null judgment Xiaoyun wang
2020-05-11 19:09   ` Ferruh Yigit [this message]
2020-05-09  4:04 ` [dpdk-dev] [PATCH v5 2/4] net/hinic: add jumbo frame offload flag Xiaoyun wang
2020-05-09  4:04 ` [dpdk-dev] [PATCH v5 3/4] net/hinic: increase judgment for support NIC or not Xiaoyun wang
2020-05-09  4:04 ` [dpdk-dev] [PATCH v5 4/4] net/hinic/base: support ipv6 flow rules Xiaoyun wang
2020-05-11 20:12   ` Ferruh Yigit
2020-05-11 19:04 ` [dpdk-dev] [PATCH v5 0/4] Support " Ferruh Yigit
2020-05-11 20:20   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d966a99-d066-4179-824d-3dc3f523fe1c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bluca@debian.org \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=david.yangxiaoliang@huawei.com \
    --cc=dev@dpdk.org \
    --cc=luoxianjun@huawei.com \
    --cc=luoxingyu@huawei.com \
    --cc=shahar.belkar@huawei.com \
    --cc=stable@dpdk.org \
    --cc=yin.yinshi@huawei.com \
    --cc=zhaohui8@huawei.com \
    --cc=zhengjingzhou@huawei.com \
    --cc=zhouguoyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).