From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB9E1A0A02; Tue, 4 May 2021 18:34:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 356D54014D; Tue, 4 May 2021 18:34:10 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6FAD340147; Tue, 4 May 2021 18:34:08 +0200 (CEST) IronPort-SDR: CpyKLorP0OYhAS4OuWhi9SgjmnLYtY3xRLfZ0wsYwWp8BQnzB5arSLVHbMx9cJeYJ2UmANPT8n +aaSWAqp+Q+g== X-IronPort-AV: E=McAfee;i="6200,9189,9974"; a="197639616" X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="197639616" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 09:34:07 -0700 IronPort-SDR: y8XxORfs4gi0ZAVzColLNqWYdm4c8NphkmU17ZV7VwDiezWNja2WIIhr6HjdRGAj92clPAuL/A naom0Q/9dqOg== X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="433354935" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.243.109]) ([10.213.243.109]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 09:34:05 -0700 To: Thomas Monjalon , hemant.agrawal@nxp.com Cc: dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org, longli@microsoft.com, Rosen Xu References: <20210429055548.12964-1-hemant.agrawal@nxp.com> <2232862.pp3s5jRlb4@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: <5d992eab-8aa5-d9f6-8570-8fda33e45536@intel.com> Date: Tue, 4 May 2021 17:34:02 +0100 MIME-Version: 1.0 In-Reply-To: <2232862.pp3s5jRlb4@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/4/2021 4:50 PM, Thomas Monjalon wrote: > 04/05/2021 14:49, Ferruh Yigit: >> On 4/29/2021 9:01 AM, Hemant Agrawal wrote: >>> >>> On 4/29/2021 1:26 PM, Thomas Monjalon wrote: >>>> 29/04/2021 07:55, Hemant Agrawal: >>>>> This patch fixes issue with OVS 2.15 not working on >>>>> DPAA/FSLMC based platform due to missing support for >>>>> these busses in dev_iterate. >>>>> This patch adds dpaa_bus and fslmc to dev iterator >>>>> for bus arguments. >>>> I think we should add VMBus as well. >>> They are 2 buses remaining vmbus and ifpga. However I don't know, if they use >>> args as vdev or as pci? >> >> cc Rosen for the 'ifpga' bus, 'vmbus' maintainer seems already cc'ed. >> >> This variable ('bus_param_key') is used to construct 'bus_str', and 'bus_str' >> seems used only for the '.dev_iterate' bus operation. >> >> Since 'ifpga' & 'vmbus' are not implementing the '.dev_iterate', so is it really >> required to add them? > > Good point Ferruh. > > The only bus implementing dev_iterate are dpaa, fslmc, pci and vdev. > So this patch makes sense. > > Acked-by: Thomas Monjalon > Applied to dpdk-next-net/main, thanks.