From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: dev@dpdk.org, Paul Szczepanek <paul.szczepanek@arm.com>
Subject: Re: [PATCH 4/6] dts: add artifact module
Date: Tue, 12 Aug 2025 09:21:05 +0100 [thread overview]
Message-ID: <5da4fdc1-a9ba-4180-b8c6-dbb20bd90607@arm.com> (raw)
In-Reply-To: <CAJvnSUCHuZWuGbDokC8=qfQj=OXhPcA+36LMv5zVbVN-nTr6Ug@mail.gmail.com>
On 12/08/2025 04:26, Patrick Robb wrote:
> Oh yeah - is there a reason why we don't call touch in the init
> function? running touch should be idempotent so we aren't worried about
> it being called too many times. I was reminded when I saw in the softnic
> testsuite that it is being called in the testsuite setup. Maybe this is
> extra work on the testsuite side for no reason.
The idea is that an artifact is just a definition of a file. We use the
constructor to define one, and we use the methods to actually operatore
on it. I originally implemented this behaviour, but there was a case –
which I can't remember right now – where this wasn't wanted. Overall, it
should be clearer to the test writer to calls operational methods
explicitly.
next prev parent reply other threads:[~2025-08-12 8:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 15:11 [PATCH 0/6] dts: add file management Luca Vizzarro
2025-07-25 15:11 ` [PATCH 1/6] dts: merge RemoteSession class Luca Vizzarro
2025-08-08 1:15 ` Patrick Robb
2025-07-25 15:11 ` [PATCH 2/6] dts: add node retriever by identifier Luca Vizzarro
2025-08-08 18:10 ` Patrick Robb
2025-07-25 15:11 ` [PATCH 3/6] dts: add current test suite and cases to context Luca Vizzarro
2025-08-08 18:19 ` Patrick Robb
2025-07-25 15:11 ` [PATCH 4/6] dts: add artifact module Luca Vizzarro
2025-08-12 1:25 ` Patrick Robb
2025-08-12 8:31 ` Luca Vizzarro
2025-08-12 13:50 ` Patrick Robb
2025-08-12 3:26 ` Patrick Robb
2025-08-12 8:21 ` Luca Vizzarro [this message]
2025-07-25 15:11 ` [PATCH 5/6] dts: make log files into artifacts Luca Vizzarro
2025-08-12 3:10 ` Patrick Robb
2025-07-25 15:11 ` [PATCH 6/6] dts: use artifacts in packet capture and softnic Luca Vizzarro
2025-08-12 3:29 ` Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5da4fdc1-a9ba-4180-b8c6-dbb20bd90607@arm.com \
--to=luca.vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).