From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0CF446D09; Tue, 12 Aug 2025 10:21:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D7294026A; Tue, 12 Aug 2025 10:21:10 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id E882740264 for ; Tue, 12 Aug 2025 10:21:08 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDFB42934; Tue, 12 Aug 2025 01:20:59 -0700 (PDT) Received: from [10.57.2.91] (unknown [10.57.2.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7904F3F5A1; Tue, 12 Aug 2025 01:21:07 -0700 (PDT) Message-ID: <5da4fdc1-a9ba-4180-b8c6-dbb20bd90607@arm.com> Date: Tue, 12 Aug 2025 09:21:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] dts: add artifact module To: Patrick Robb Cc: dev@dpdk.org, Paul Szczepanek References: <20250725151503.87374-1-luca.vizzarro@arm.com> <20250725151503.87374-5-luca.vizzarro@arm.com> Content-Language: en-GB From: Luca Vizzarro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/08/2025 04:26, Patrick Robb wrote: > Oh yeah - is there a reason why we don't call touch in the init > function? running touch should be idempotent so we aren't worried about > it being called too many times. I was reminded when I saw in the softnic > testsuite that it is being called in the testsuite setup. Maybe this is > extra work on the testsuite side for no reason. The idea is that an artifact is just a definition of a file. We use the constructor to define one, and we use the methods to actually operatore on it. I originally implemented this behaviour, but there was a case – which I can't remember right now – where this wasn't wanted. Overall, it should be clearer to the test writer to calls operational methods explicitly.