From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org, Chas Williams <chas3@att.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [RFC v2] net: fix rte_vlan_insert with shared mbuf
Date: Thu, 4 Jul 2019 19:40:46 +0100 [thread overview]
Message-ID: <5db9ccd0-bc8c-9991-db3d-f77e52886211@intel.com> (raw)
In-Reply-To: <da34a2f3-0caf-e88a-953d-8501ed090249@intel.com>
On 4/12/2019 5:35 PM, Ferruh Yigit wrote:
> On 3/28/2019 8:53 PM, Stephen Hemminger wrote:
>> If mbuf is shared then rte_vlan_insert() would clobber the original
>> Ethernet header. The changed version handles this by getting
>> an mbuf that will hold the new Ethernet and VLAN header followed
>> by another mbuf (cloned) for the data.
>
> Hi Stephen, Chas,
>
> Since this patch is still an RFC, and we are after RC1, I think it is better to
> consider this patch for next release.
>
> But for this release, what do you think having a patch to return error on
> 'rte_vlan_insert()' for shared mbufs?
nack for this patch
The other approach to not support the shared mbuf merged:
https://git.dpdk.org/dpdk/commit/?id=15a74163b12
prev parent reply other threads:[~2019-07-04 18:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 19:15 [dpdk-dev] [PATCH] " Stephen Hemminger
2019-03-26 19:15 ` Stephen Hemminger
2019-03-26 22:38 ` Chas Williams
2019-03-26 22:38 ` Chas Williams
2019-03-27 15:18 ` Stephen Hemminger
2019-03-27 15:18 ` Stephen Hemminger
2019-03-27 15:31 ` Chas Williams
2019-03-27 15:31 ` Chas Williams
2019-03-28 14:04 ` Ferruh Yigit
2019-03-28 14:04 ` Ferruh Yigit
2019-03-28 20:53 ` [dpdk-dev] [RFC v2] " Stephen Hemminger
2019-03-28 20:53 ` Stephen Hemminger
2019-03-30 12:41 ` Chas Williams
2019-03-30 12:41 ` Chas Williams
2019-04-04 23:54 ` Stephen Hemminger
2019-04-04 23:54 ` Stephen Hemminger
2019-04-06 23:11 ` Chas Williams
2019-04-06 23:11 ` Chas Williams
2019-04-12 16:35 ` Ferruh Yigit
2019-04-12 16:35 ` Ferruh Yigit
2019-07-04 18:40 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5db9ccd0-bc8c-9991-db3d-f77e52886211@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).