From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24C58A0524; Tue, 13 Apr 2021 16:30:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D2381610AF; Tue, 13 Apr 2021 16:30:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 31D33161097 for ; Tue, 13 Apr 2021 16:30:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618324255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RHIJcX+gS4dxxmTPDKM6GqnDZvDRAiNNRStIPXZfLmM=; b=gLsLPdE0taCGraeyxIZgGlJxA0BxXeMfwByhANwr9EKlka1aNGkowOaAT0jQjfCcV6MDRh ARRVgu8kb3TTn32MXYJkGVJNP/14uyLoijwXPDzY+yr+0cgUCJfDA19RmO3TTh46E3/Uts MjsmTPXwJyT6qAHf57rbTXwii4MtI+I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-bpGdFtZYNBq-8m--kOFygw-1; Tue, 13 Apr 2021 10:30:47 -0400 X-MC-Unique: bpGdFtZYNBq-8m--kOFygw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A38E881746B; Tue, 13 Apr 2021 14:30:46 +0000 (UTC) Received: from [10.36.110.28] (unknown [10.36.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5C8B1853C; Tue, 13 Apr 2021 14:30:33 +0000 (UTC) To: David Marchand , "Wang, Xiao W" Cc: "Xia, Chenbo" , "Liu, Yong" , dev , "Ananyev, Konstantin" , dpdk stable , "yangyi01@inspur.com" References: <20210311063827.55394-1-xiao.w.wang@intel.com> <20210317063109.135662-1-xiao.w.wang@intel.com> From: Maxime Coquelin Message-ID: <5ddd6f84-e607-f19f-2fb8-8988db6a7627@redhat.com> Date: Tue, 13 Apr 2021 16:30:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/12/21 11:33 AM, David Marchand wrote: > On Mon, Apr 12, 2021 at 11:09 AM Wang, Xiao W wrote: >> Considering the major consumer of vhost API is virtual switch/router, I tend to keep the current implementation and apply this fix patch. >> Any comments? > > This is just a hack that bypasses the vswitch control. > > It happens to work when the vswitch does nothing. > If anything is done, like popping a vlan header, the vswitch needs to > update l3 offset. > > I agree with David, current behavior is wrong. Furthermore, when the lib is used via the Vhost PMD, the application should not have to handle it differently on whether it is Vhost PMD or any physical NIC PMD.