From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1A030A0530;
	Wed,  5 Feb 2020 15:12:35 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BDF641C1A2;
	Wed,  5 Feb 2020 15:12:32 +0100 (CET)
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com
 [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id BC6931C133
 for <dev@dpdk.org>; Wed,  5 Feb 2020 15:12:30 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1580911950;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=2KvFJ60fkRY9tFb84PiAoF4Zx6PMfEtuKc1uGhPhPIo=;
 b=EFjKA5cnOaAet+aL4956wgjJKsTYng+eh0Zy1mEOhprWxkE/Qq8IPXWS0hXV4oTJSzoPvB
 fmVDPE45LXY41SnY0mUWKmSIsbiJIuax3CogDCY/nMdPqVo62p9SL86WJpimOVCmgKNPN7
 V3vvzjyjKfc6zDxy73tGZ8559EpDVEk=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-218-ScwWc-0FNVus-vF8qhVlvw-1; Wed, 05 Feb 2020 09:12:26 -0500
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA89E802560;
 Wed,  5 Feb 2020 14:12:25 +0000 (UTC)
Received: from aldebaran.drizzt.lan (dhcp19-189-71.ntdv.lab.eng.bos.redhat.com
 [10.19.189.71])
 by smtp.corp.redhat.com (Postfix) with ESMTP id E0B9A60BF7;
 Wed,  5 Feb 2020 14:12:21 +0000 (UTC)
From: Timothy Redaelli <tredaelli@redhat.com>
To: stable@dpdk.org
Cc: dev@dpdk.org,
	david.marchand@redhat.com,
	cristian.dumitrescu@intel.com
Date: Wed,  5 Feb 2020 15:12:20 +0100
Message-Id: <5de9fca287dbda831bbe11e34ecf89631e3a812f.1580911676.git.tredaelli@redhat.com>
In-Reply-To: <cover.1580910264.git.tredaelli@redhat.com>
References: <cover.1580910264.git.tredaelli@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-MC-Unique: ScwWc-0FNVus-vF8qhVlvw-1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Subject: [dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC
	10
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

GCC 10 defaults to -fno-common, this means a linker error will now be
reported if the same global variable is defined in more than one
compilation unit.

Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
Cc: cristian.dumitrescu@intel.com
Cc: stable@dpdk.org
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---

v2:
    app is already declared as extern in main.h. (as reported by David)

---
 app/test-pipeline/config.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c
index 28ac9fcc0..33f3f1c82 100644
--- a/app/test-pipeline/config.c
+++ b/app/test-pipeline/config.c
@@ -42,8 +42,6 @@
=20
 #include "main.h"
=20
-struct app_params app;
-
 static const char usage[] =3D "\n";
=20
 void
--=20
2.24.1