From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30077.outbound.protection.outlook.com [40.107.3.77]) by dpdk.org (Postfix) with ESMTP id 0C6E21B66D for ; Tue, 3 Apr 2018 08:40:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kJpTc6GxfU01amBDa7iTXkt+b2j/e1qBaXfToO9LQTE=; b=iPPGaLMd3aGqV1bbDlb/EVxqrjdsU3Ooc/1xr4N8UizcDsv3nu3aeDGHPhFvgv7t6SdXKW6TT3cSsB3VvpyfFNgNl8tCoaw4IKt8uGpqlRC2qJnZwKDkgD+DqLgs1Yv5MR2PduxzCncqmK41w0EXcuCtFBcNY0KEswccrDkbmDM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by HE1PR0402MB2779.eurprd04.prod.outlook.com (2603:10a6:3:d4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Tue, 3 Apr 2018 06:39:58 +0000 To: Thomas Monjalon Cc: hemant.agrawal@nxp.com, dev@dpdk.org References: <20180402220649.662-1-thomas@monjalon.net> From: Shreyansh Jain Message-ID: <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com> Date: Tue, 3 Apr 2018 12:25:11 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180402220649.662-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: SG2PR01CA0091.apcprd01.prod.exchangelabs.com (2603:1096:3:15::17) To HE1PR0402MB2779.eurprd04.prod.outlook.com (2603:10a6:3:d4::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9d40fda1-20ed-4b8e-7830-08d5992db8c6 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2779; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2779; 3:hfHSzJV21F2qtj5Ekitc5htpH6LoJUxPpxskmUXUscJlPpwkQcmABfhe7gXe31jmRo5NX3655ayz3OWG647IMYy9+XuBy9RL78IbBKc61wZzl84IpvlgYqg4bA5CUXN+0cvvAx4t01zrfVuJJ7p5dy+/3Wjt8uV0Mz0ZyyiIpFCPpX9WjsRnllN+dRR0HvMikAnaof4B+hhC/ZPXHAn6PkMc+mEVX06iWPQcBaanHFbuo4t1hVgYBiwxSQ2CCKWa; 25:4AIVHDJFDFfIf9dzXNkZwcqTkVnGSpLVvE68cWj1lSp6MmKdTiLUnjOekIFMvtlFd+Ip6fR5hyu5ID4Yh3vzT5OrAzWtMT1zR5f7qs+UxkLAXbzlRjKeMiO0jm+jl/Vk5kgXTM8Kl1PWzh3CosQ/7S7plckHV9GnwjxuoTXybNMDUbYnsBSARDbX+tCtSzn1xRznXxpeSl21S7iKPdH12034Op58FTDuxs4ZzJprA/yjSjeyAB4eoodbXYGwTTmmIMA6kHAUMBJ5N87nmqdFHEDrnFiKZzwsS0HLVcLRYejhN8slxmZRs4VGeD5E6mUoLi+Gj1yMnxIt1o8Z6Gt+7Q==; 31:JAuSePvtp/cAR4yOTYI5dVmAEQqYMBFaf2SEUtYuPtThfP+r2k9UdBfmG7BgRKh5J6WjT+OUlTi4eStUBjulM+Pxll45yy9xvwnbZKBMRXweAUeBGrtKE3ESeK9fh+xn7YTCV2DI+GM/i8FgzFGeNhNmIzTSbYADQyhnpudQjla2SPZ91/P9n0lT3nXKA6x7054tk/LZ3hk3pTNRAQfAniwr6HSnBZRkqayoHpkTZEg= X-MS-TrafficTypeDiagnostic: HE1PR0402MB2779: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2779; 20:yyOyljwO8xwcRmfVP5bjxPUkB2Lbca6YYk/ABC/9/wuWuwn6L5p3fFqJrFN1z6+QZy5YQFBzGJhXj7FAtpFNLEWsOCRtPeV3Vwfkk1t871b8rT/jn5M9DlBHBfbjvfv6YLbUVSbfoS/Nz97oq0xaSCTO9iU0SMpEzQs1NzCx0B55NzxmUrM+X5YMq3HrIT4HGqctaCHLkJelPacZk9uXrS9ZpHVIEX+rjQgyAYTUZdvUzzm6YfkaMk+DxOrpLwbcu/N0HD7zq97x79DZYvlrIEdKgfohwdByNmDUmOxUa8ZIcRPbyMCELiy150i4r4Gx8iFdQVVy4ya/qrrqwFrIyhoa0gxR98bsdLrhh4QINhDufmmKo1xBXln4p870WkK8l4dDpmZ0vsv4Gp8KGH4wuPJzrM9y61vYBMYHG+aY07+uX5jnYMCnpjr1g8hUlUEVJSaCsOt44PqgMB+bUaqkI8WrPNGEzZpwisbs5/1CxTA6c0cOM2Uld0eUtwn8P6Fm; 4:jHY9mSDz2qNn+jdxU0+Y5FJvgKGA1SYg49nGt9L1jLtAOML5Klz1/tQHUmPUa2XxTDkCTs0Zv+DLkrvjaK7Rmm1NOR76zXVEyHm8e1A1vB1Gn1E4vrpx4RkrhpYbL511WSXAk91qQq3SljgHImamOAdBUa2Fo41MNp9oA4Tu/kaQ42/Y6Lp4djMkIbmCyzOwu6S/T9LoSw/g0Y5ukXJbmoMGOLE4a8vmuwNwknePeNpQvuMLpl4lMJ/JcQkBBKFrURjIytx5ZXpacmj7vechtg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0402MB2779; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2779; X-Forefront-PRVS: 0631F0BC3D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(376002)(39860400002)(39380400002)(346002)(366004)(396003)(199004)(189003)(316002)(2486003)(52146003)(23676004)(31686004)(5660300001)(2616005)(446003)(476003)(26005)(956004)(11346002)(486005)(65956001)(16526019)(186003)(66066001)(77096007)(58126008)(65826007)(81156014)(8936002)(81166006)(16576012)(7736002)(8676002)(64126003)(68736007)(86362001)(65806001)(47776003)(67846002)(59450400001)(305945005)(76176011)(52116002)(230700001)(386003)(55236004)(5009440100003)(105586002)(6916009)(2906002)(6666003)(36756003)(229853002)(31696002)(50466002)(97736004)(478600001)(3846002)(6486002)(4326008)(53936002)(486005)(6246003)(25786009)(106356001)(6116002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2779; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA0MDJNQjI3Nzk7MjM6TXg5Wk1PYnBEYjhlMDRlTFg4MUNIbDJw?= =?utf-8?B?TWtMYXcwT1RQeE90OERQdG91R3NFRzZYMzZrS1FnZ2JEdDdTYmFFY2ZMZGRT?= =?utf-8?B?WDFyTURwR2F2alJUWHVZOE1qck02ZWpqZ3FJZlVtb2xsdFFpWXAvMFQvYkJP?= =?utf-8?B?YVhVbng4OTkxakdiME5TWDRUREZpd3F1TnRDSXBnSFFqY2JGS3gxSlZmNjJ2?= =?utf-8?B?S0VPT3FkQXBJanZrbDRObElKRC9mQ2JHK1pWVW50VFBlNExvTmplUUVld1Va?= =?utf-8?B?dUpwdDdzamRxM0dlY0p4Y01YS0xZL0ZjVTQ3MUNja0M2aHVBUlpwcEtEd0wr?= =?utf-8?B?NFQ2OXdDVklmaW5PZWlGV2RoalpIUC9RYi96T3RVdG4zUW9RcktJeEFycjkw?= =?utf-8?B?bXd6MWdoa1c0U2FhZnJsLzZwbnZrQXhFZld0STZsQmNPMVloL0M0NVdqRXZz?= =?utf-8?B?ZnRXRElrSitUZHZLQ2hPeVh0bW9qQ1o3WWFjUUxETnU2ZUJGR3FLOG0wWnZU?= =?utf-8?B?eEhnQndwYlBNM01hQU5GMDB5M0ZuVXFqOXh1K0laZlZjVXRJajc2TzRJL3V4?= =?utf-8?B?eG9NMEVYRXJBTE5KdWttMGNBTHJPc3VaOE5MRUhyUEJnd0dZdXFNMGd6TVpi?= =?utf-8?B?VEl4dGMzZWFoZFVrUExxRG5qaE1pUEh2NS8zMGNjRE5tK3htcnFyVHFPT0hy?= =?utf-8?B?bWtNc1pvZlZtVmFLTE9QaUlVYnVMUldVcTJCczlaYW1XUUxWY3phZkd1ekZj?= =?utf-8?B?djlWU0dyNWh4d241RXl0MjRjbXVRUllsTEJGUkN0R0twWEYvTnB4UVpCNmdH?= =?utf-8?B?ZVArNUZqTU5XcDR2aGFlazdYZU40aklndFVWd3EyalZlTEpYdVhnTTJtS1Bz?= =?utf-8?B?ekxXV3htUDJCaU1YdUExcVVCR2tPR2I1RVBIajR0Q1l1UGZBZlFNSzA5dEMv?= =?utf-8?B?YU5jdmVtZW4zZGgxemU3V0p0TjcyNHF3N1Y0NjBNMllTOU1FbStmdFA1R1k3?= =?utf-8?B?ZUhyTkdHaGhpVWlMRE1QUm1ZUzJtbXprRFRjVXNxTWFwNjd2c2YxT3ZvQzl2?= =?utf-8?B?empPU1pPdGVCcTdhYWtiWnREQXhMT0pDZFdaeW5Xc29COW1uNDhKVEg4UFg3?= =?utf-8?B?Q0NITUhJZzYwVmZXMHVEL3NoZmxsdWI4ZjdaaHNaVVhVb1UrZ1ljSjVWdGJp?= =?utf-8?B?TCtReUhMd3QrTmE4S1lWc09RTU1UM0ZZVjhzQXRMbnI0NzdvMU9vcTBTaWlR?= =?utf-8?B?Y2w5cklNT2VwTGFOd0d3dFVBc1JmaHlZaG42Y2VXSEFlQVFKSXBmZnpmK2dB?= =?utf-8?B?dHRGUWtOUkpNRm8yaTlpaEQ2c0hmajZkcHdINmhaQ01rdXJDMVh6UGIzcGpr?= =?utf-8?B?NGRFWTFiMW5Ma3dkMkQxR2VicjRjaVZTME5pSDRKendneHlveDNYRTlmUEtn?= =?utf-8?B?ai9MWndmZUlqTHprUDBOSmx6RUhPN0tYVDVFYTBkWTZvaDU3UFk2NVVzZHln?= =?utf-8?B?T1VndVZrKzVOVzZBc1pIdHpuM1FwbEJ5aWY3QTA1QjZJSkZGU1RuNFZsaVZP?= =?utf-8?B?RHNyNzJSYVFDSlBLWTdwMXpnaFB3UXJEYk9Bc1Y4azE0azh1K3FQeWtGS3pl?= =?utf-8?B?VTQwMUtkQ2NQZXRENlhzSGFlejFGdGZaMk1EOW1LY2V6czNGQjdQRjROcmc1?= =?utf-8?B?clhFVHV2UnZHODlDak9INEk5ZGlyQU5qUm5xSUtnaTZCRTRaNEJINnFXRXFT?= =?utf-8?B?clF5WVJ4TXRRVkxDejlKcXMvN2FEZkdWWjNZaVVYbHZMdm9scXFONjhxd2Vr?= =?utf-8?B?NnBCNHBCd1hZMDdtVFlKQWgvNW5IaFByRjhDcFpxa3c3ZXNOd2ZKR3ZNbTZG?= =?utf-8?B?ZVh6eGg1ZGlOK2dyQWx5ZktmYU0waW5TWWRIaE1vak9YK3FwY29xMWdWTWlp?= =?utf-8?B?SXQwTVR3ZmtyWGNkTkg5YmxoWDg5c09LU2xKeHQySnppcFJjWktPZk55YXpi?= =?utf-8?B?Mi9WcDVEaWUzMUJSb21mSjdZb3dzOGlOZU1mbXlZNGQxaTB3RjV6UnRRRUtE?= =?utf-8?Q?zmKXCd+ECxKHQTBOMZ7lAgzKtrM?= X-Microsoft-Antispam-Message-Info: HH4YX1bI2SQzoulAnSt+u3sHCOWX2bF1/Lf5/bB1A1njR2hgaVApnPX5UoZiQnp4WWkxnf7N/PudSAFJV+YM8iE/nEDJ5FnV5qJaGwhI3xay1eC9agM5eGu5E4TD4LLd8YDCXx0FHFTRaFGyDtbOuOT0A8AQmKBjNIr1MRBVzabD3KvzlJ8IfcbIDKZrhL2L X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2779; 6:IR5c8Uyd44zMCqgVjVMwYk+5pR0GCIoKYmnA9FWRPketg3hSkhYlXgWkVR2t+yh+W00+1wuBaA7DjrcN0EYEKKD+maT6ZBDhBXrbsjUnNzqhOQBndv2+iCju5xYRbC6vpOGTCz3aU60eHlRbTKHc0smmrrDzKhGCsTo1la9I1Y8y/OnsE2LgzoDYSC1RLNg1NtjpRAzbtimRCDi//SGWzYsFOaTPWjH2UMwCzE4tbNKwTG/CV/BseYLeCgsB+pW11I1TYToerTeDzG1rklTdxtC3pWKjl28Fc5KTQHFXOYUe+UwXAUhLXxnbhbW+wsYn04WRjrKXgKntziwSGBp5gDXe8lQbDYAbFidNOwJrob+zVi5uGmdjQlosIEqaNoYauzFMoFiantcLGQehtUV4+8gN2EH8gR1ZGthNOb7bG7LG/gsc+jyaPI1/mv6CXQDIDW5lkQDyuPxX43JIbwF9qA==; 5:3Lf6MebqrJJBC8rtTdLg1eeCFTzLoiPHZ5X/T0CvC1PhjaElUhNN37HDPpyYhs/yCviuUO4h40Q9++vJlLNaMpsGsQ012vzvXXEq5Uy8p/47ugjLqJbTkn/wkkS3HaLsOX21fFb4zTtyF7lvKsi5iBJLqj4DvzKRvSMUto+RHQw=; 24:CgqoHVXZ/njmgqDp5CCG4W2d7osF/bL3UE38/0Nanw7/XxitAoXRCM9nW6dTCkeepwWuCxrljF6aUt3M5DTvjE3fBHIiUS5z9VHHqY3BeKA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2779; 7:ImfwtU1073tahrqFSHSFEHLCVXWRGL2LLhu5N3yQYaK6TFOT+Sc/zeq6O3g6NOm61bMgTkpPAIG8eyNc28BBM/XxLVv0BTYqEaulLQKb21oaookIkOPlfS28tzWkr4HK2VBV1Zy+OEG+vS5xKBvu8AdmgzJfF8gxy0Nju7qwPldAVjfhXS88GNxw1uP91SdjDT3tO7SzXz9AYQ0GuGpIcy2msRDdua7R7lLkyysa8s0QHi66dt/JbP8SVesIJC85 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2018 06:39:58.1323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d40fda1-20ed-4b8e-7830-08d5992db8c6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2779 Subject: Re: [dpdk-dev] [PATCH] config: remove useless lines for DPAA2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 06:40:01 -0000 On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote: > Some comments are not relevant in a config which only overrides > the default config. > > The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled > by default so it can be removed from this file. > > Signed-off-by: Thomas Monjalon > --- > config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/config/defconfig_arm64-dpaa2-linuxapp-gcc b/config/defconfig_arm64-dpaa2-linuxapp-gcc > index ecac994bf..96f478a06 100644 > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc > @@ -9,9 +9,6 @@ > CONFIG_RTE_MACHINE="dpaa2" > CONFIG_RTE_ARCH_ARM_TUNE="cortex-a72" > > -# > -# Compile Environment Abstraction Layer > -# > CONFIG_RTE_MAX_LCORE=16 > CONFIG_RTE_MAX_NUMA_NODES=1 > CONFIG_RTE_CACHE_LINE_SIZE=64 > @@ -22,8 +19,4 @@ CONFIG_RTE_PKTMBUF_HEADROOM=128 > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n > CONFIG_RTE_LIBRTE_VHOST_NUMA=n > > -# > -# Compile Support Libraries for DPAA2 > -# > CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n I think DEBUG_DRIVER should exist in local config so that a developer can easily toggle it without modifying the common_base, which should serves as repository rather than toggle. I do see the problem that having an option in common_base and then having it again in local config without overriding (=n) - is non-intuitive. But, I still feel it is easier to control changes in local config - (make T=) is easily visible.