From: Andy Green <andy@warmcat.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Patil, Harish" <Harish.Patil@cavium.com>,
"Mody, Rasesh" <Rasesh.Mody@cavium.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison
Date: Sat, 12 May 2018 09:04:16 +0800 [thread overview]
Message-ID: <5e07b401-69f4-8d4a-d6a8-8c434d54bd58@warmcat.com> (raw)
In-Reply-To: <20180511111057.64b617f3@xeon-e3>
On 05/12/2018 02:10 AM, Stephen Hemminger wrote:
> On Fri, 11 May 2018 16:32:24 +0000
> "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> wrote:
>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
>>> Sent: Friday, May 11, 2018 2:51 AM
>>> To: dev@dpdk.org
>>> Subject: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison
>>>
>>> /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:
>>> In function ‘elink_check_kr2_wa’:
>>> /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28:
>>> error: bitwise comparison always evaluates to false [-Werror=tautological-
>>> compare]
>>> ((next_page & 0xe0) == 0x2))));
>>> ---
>>> drivers/net/bnx2x/elink.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index
>>> 99684a5f9..2aef2b6da 100644
>>> --- a/drivers/net/bnx2x/elink.c
>>> +++ b/drivers/net/bnx2x/elink.c
>>> @@ -12919,9 +12919,7 @@ static void elink_check_kr2_wa(struct elink_params
>>> *params,
>>> * but only KX is advertised, declare this link partner as non-KR2
>>> * device.
>>> */
>>> - not_kr2_device = (((base_page & 0x8000) == 0) ||
>>> - (((base_page & 0x8000) &&
>>> - ((next_page & 0xe0) == 0x2))));
>>> + not_kr2_device = !(base_page & 0x8000);
>>>
>>> /* In case KR2 is already disabled, check if we need to re-enable it */
>>> if (!(vars->link_attr_sync & LINK_ATTR_SYNC_KR2_ENABLE)) {
>>
>> Looks like a good fix, but I wonder what's the actual intention of that conditional.
>> CC'ing the maintainers and Stephen Hemminger (the author of this code) to figure it out.
>>
>> Apart from that, missing signed-off-by, fixes line and Cc stable:
>>
>> Fixes: b5bf7719221d ("bnx2x: driver support routines")
>> Cc: stable@dpdk.org
>>
>
> Actually, I didn't write this. It came from contractors. Based of FreeBSD
> driver so look there.
Googling around, the correct comparison is == 0x20, I updated the patch
accordingly.
-Andy
next prev parent reply other threads:[~2018-05-12 1:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 1:51 [dpdk-dev] [PATCH 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-11 1:51 ` [dpdk-dev] [PATCH 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-11 16:03 ` Ferruh Yigit
2018-05-12 0:25 ` Andy Green
2018-05-11 16:33 ` De Lara Guarch, Pablo
2018-05-11 1:51 ` [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison Andy Green
2018-05-11 16:32 ` De Lara Guarch, Pablo
2018-05-11 18:10 ` Stephen Hemminger
2018-05-12 1:04 ` Andy Green [this message]
2018-05-11 1:51 ` [dpdk-dev] [PATCH 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-11 16:25 ` De Lara Guarch, Pablo
2018-05-13 4:45 ` Shahaf Shuler
2018-05-13 5:25 ` Andy Green
2018-05-11 1:51 ` [dpdk-dev] [PATCH 4/4] net/bnx2x: solve overruns Andy Green
2018-05-11 16:21 ` De Lara Guarch, Pablo
2018-05-11 16:04 ` [dpdk-dev] [PATCH 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e07b401-69f4-8d4a-d6a8-8c434d54bd58@warmcat.com \
--to=andy@warmcat.com \
--cc=Harish.Patil@cavium.com \
--cc=Rasesh.Mody@cavium.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).