From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 28F2E1CB8E; Sat, 12 May 2018 03:04:32 +0200 (CEST) To: Stephen Hemminger , "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , "Patil, Harish" , "Mody, Rasesh" , "stable@dpdk.org" References: <152600339444.53624.14086407337377549776.stgit@localhost.localdomain> <152600348247.53624.13691884496521997911.stgit@localhost.localdomain> <20180511111057.64b617f3@xeon-e3> From: Andy Green Message-ID: <5e07b401-69f4-8d4a-d6a8-8c434d54bd58@warmcat.com> Date: Sat, 12 May 2018 09:04:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: <20180511111057.64b617f3@xeon-e3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2018 01:04:33 -0000 On 05/12/2018 02:10 AM, Stephen Hemminger wrote: > On Fri, 11 May 2018 16:32:24 +0000 > "De Lara Guarch, Pablo" wrote: > >>> -----Original Message----- >>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green >>> Sent: Friday, May 11, 2018 2:51 AM >>> To: dev@dpdk.org >>> Subject: [dpdk-dev] [PATCH 2/4] net/bnx2x: remove unmeetable comparison >>> >>> /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: >>> In function ‘elink_check_kr2_wa’: >>> /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28: >>> error: bitwise comparison always evaluates to false [-Werror=tautological- >>> compare] >>> ((next_page & 0xe0) == 0x2)))); >>> --- >>> drivers/net/bnx2x/elink.c | 4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index >>> 99684a5f9..2aef2b6da 100644 >>> --- a/drivers/net/bnx2x/elink.c >>> +++ b/drivers/net/bnx2x/elink.c >>> @@ -12919,9 +12919,7 @@ static void elink_check_kr2_wa(struct elink_params >>> *params, >>> * but only KX is advertised, declare this link partner as non-KR2 >>> * device. >>> */ >>> - not_kr2_device = (((base_page & 0x8000) == 0) || >>> - (((base_page & 0x8000) && >>> - ((next_page & 0xe0) == 0x2)))); >>> + not_kr2_device = !(base_page & 0x8000); >>> >>> /* In case KR2 is already disabled, check if we need to re-enable it */ >>> if (!(vars->link_attr_sync & LINK_ATTR_SYNC_KR2_ENABLE)) { >> >> Looks like a good fix, but I wonder what's the actual intention of that conditional. >> CC'ing the maintainers and Stephen Hemminger (the author of this code) to figure it out. >> >> Apart from that, missing signed-off-by, fixes line and Cc stable: >> >> Fixes: b5bf7719221d ("bnx2x: driver support routines") >> Cc: stable@dpdk.org >> > > Actually, I didn't write this. It came from contractors. Based of FreeBSD > driver so look there. Googling around, the correct comparison is == 0x20, I updated the patch accordingly. -Andy