From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C37C742C5E; Thu, 8 Jun 2023 16:32:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95092410D3; Thu, 8 Jun 2023 16:32:21 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52]) by mails.dpdk.org (Postfix) with ESMTP id 2420B40A84 for ; Thu, 8 Jun 2023 16:32:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRNSiXX4Z9ZwTsBYxmHELu+z4aDd30ZUu3MYx16n+p/M3tXwAt1ni2wva9WOxU7vQg8VgcJeoDJA/tu8vh73lbOiBVR/VyuVc088Al5qJ37XXSBhZx4cEfWMWlM9chFBLsm+q/0oyd+T1U+Fr5jPkg5PJ2rhV09pCJRyf9RQAV5/alcWHOrtr4BFonZJjtj/h19yNfX8zLspBPvlQ83ZbTLucFu/n+fl7dsXaaWFGsZoVDkHcwtB94Wcy5kNxzxyNWL1M5S4EX+gmiVDaH7G4hPxX3MaVmdxTqOwsjz5qhplRwh19j5Kbvaot2onhdXP8q/rAMwbANTvUDaidMdCBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cFs0eKFzUpG73nlixsEX5dsQjytUGuD5TI/YVs/W48k=; b=CzPinhQN4JU910Behd262QzM2MY+/YWOr+ebrkz1qzIgaJYLabA1WxauGq2oo9WQeq9J65ic7yg7lzvxSRt6MZKH1q2C3eUF/8QOF4PRbdfD+c0e3z/VyClY2ZXhL/CSi5mbgyCzqQGFPRwkghsfWUPetnb/73GIoByP2/8fgteFTuQd2DUHNK4ieuHocaQsBX+OymYRwz0wpq6KqrtabCEdkbav4tGLehCAhOs0r21uwhQlmuE6DeGIf+tNsr/8WOjJR5scYxsIsAkg7l/mAnWAOlyV33yUcTPDBa6eZN4Bql17HG4PumVb7ucBhQP8ihkVpJV5onPlXQlIwgVbpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cFs0eKFzUpG73nlixsEX5dsQjytUGuD5TI/YVs/W48k=; b=X6pykYvqxG4waBkW/59P0T03cHK23e1oTHDRCetzgcYU9e0vluE178NQ+uoBGBt2aePmZXf4QBP1GITq7AXz5q6vzhkz3gn6YdD4EQ2gHCbbRjagTvmTMRSxHXAoR0geZ88LtHuhFuS0ajNQ0MV0WEDhjAdYSKH8GpSLBudCoGE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4198.namprd12.prod.outlook.com (2603:10b6:610:7e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 8 Jun 2023 14:32:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Thu, 8 Jun 2023 14:32:17 +0000 Message-ID: <5e199328-c626-8de0-7aef-de5bf23ee245@amd.com> Date: Thu, 8 Jun 2023 15:32:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Mike Pattrick , Aman Singh , Yuying Zhang Cc: ktraynor@redhat.com, dev@dpdk.org References: <20230608095907.557698-1-mkp@redhat.com> <20230608133144.567391-1-mkp@redhat.com> From: Ferruh Yigit Subject: Re: [PATCH v7] app/testpmd: expand noisy neighbour forward mode support In-Reply-To: <20230608133144.567391-1-mkp@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0418.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4198:EE_ X-MS-Office365-Filtering-Correlation-Id: d63a4d2e-3905-47b0-46f4-08db682d2889 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I1su2avKbmCz/m03yJp3ZrfJ5G+AbtjMVa8RAAILXyIE//NK4rXei8vPvJSxzBawQX5UAtxtzmp1nwVVdFNoTyrSavJTyD6cLimQVbi4cjGIMxDM9jLlYDR1mZUsU2V1Iz78hpODRrS9ed87ECUaRjXrhPf7chKGYHExgds2wdrY5tly/DrD/3o+4LtOjkZKYsfwQ41GfTWxnoer637Mkh2Mgu+6eEZeCs2/7ZlFkf/23cLK+VqMzxVcrBWAHdsJr4rW8q/217GpRQZ97wDFsysq9rFyewyK/SFJlMqAZgpS2YkKgqfxcxH+LDkfGkYe5Tj52GIP9rQwgtVsuO0RPfjIBWVnp2afCpZX2KKTWdvLIF3FYCR2hGgsvz9Irbd0ZSuZdiiyUPNpid6LyCs/30eSGCANtHF/JYe3taL49biwvS1/iNlCZ2kEX2/Ex0ni6psML17DSgOhjtwPJ7pFlii6k++5xhh8Kk5c1uTHUNW2Sry4ix36zaUknahkkROr42HmMO5LTPoRCl/UK4p3B0Kzx1BH4wezJ96hFCOWEsZQ2jALhCLSXzv7wHjBs1MsOwJ2l1SgebbXA9gtrP8xks/dWS48oj9kEdK92RJG4Bj68XZHLt6TnfXgntavxrrERzRv4igcRT/Ic0uOkVx1sw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199021)(53546011)(2616005)(26005)(6506007)(6512007)(44832011)(316002)(83380400001)(66556008)(31686004)(4326008)(66476007)(66946007)(6486002)(6666004)(186003)(478600001)(31696002)(110136005)(36756003)(2906002)(5660300002)(8676002)(8936002)(86362001)(41300700001)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWFmMnFXMWRTblV1MXVUMG1rcSs3OEpWVlI4VmM5V2xWMlhaeHFLRW9QSktN?= =?utf-8?B?L0VzbkZROFZ0Y2l4aTI2WTR3RFR3WEdVTUpnTzlaY093YmFPVHVrNTU4ZS8y?= =?utf-8?B?Uk45aC9NZ1Fzb2hwYWE0T0gyS0pRd0VhMk5vSXVSL24rQW5YVXpub2RiODc5?= =?utf-8?B?bDc3L0kvbE1HajlMQXQ1bUtyQndMejdLODY3Yk5ybTB6dmRYd1pnWU5xcUQy?= =?utf-8?B?K1JGWlBCQWxIMjFCVXc3M0kvN3BnczNGbTZPemhFeCtCbW5aRmJLaWIzVkJP?= =?utf-8?B?V1hqMmcxNFZIQXlZQS9HWnFkdyt2TEdKNFlwZW4zNVNjVm4xcjQrTk5kbjdr?= =?utf-8?B?WGUvL1lIeis0ZzUwVEVTbGRTWUtTejREY0VobmZWbTdiN2NjVjJ1R0dMVnpI?= =?utf-8?B?NlJWNk42Ujl6UzNKMThReU5HR0VZaG9kTHNUVEc2L2ZPMmVRSGxQS1dUdEpB?= =?utf-8?B?VTJnRU44NDV1akxrTFY3c3RmdUVTSld5R0J2eUdmU0d5K2VzeitTVFZueThT?= =?utf-8?B?emwwOGtEekdjL0pTWm5zMHFiWHUxZ1VmODhnUXRhNkJaNXE5TDN2dFh4UWFs?= =?utf-8?B?STlYb1NxejhWeEhrb0pvNGZ2MlB5M0E0R1BXRm1xZ2FZUkxHU1ZSaWhlWUVY?= =?utf-8?B?em9IRTRNeVNNdUM2bUthbjQ4a21zTTlldzB1TGpCSDN0c1lVU211eGlKSTd4?= =?utf-8?B?Z1VqOHY5azVpYUZPdkIzUk1EVFV5Z3lFQ3NFOGFDZU8rYi8xVXBxOWFlNlpX?= =?utf-8?B?N0VUYit5T3dWSi94N0Z5L2UySFNndXpOQnN4MEZUZkVEYTZWZms3S0dVcW9u?= =?utf-8?B?Z1owaUF5d2xpRFloUmJRR3dteFVtclZlQVpPQVlySm52UEUvOTVpaWxpRk9C?= =?utf-8?B?SitxV2g0WlNOUTdzYVduSjVUekZSK240a20vUENTWjRnM2tiTnFGZFJ6REV5?= =?utf-8?B?ZFFSOXh0RWFvNlh4UEZVTlluWXdFSmsxVzZlV2FaYkFUR1VPbWZ3bjgxdUpV?= =?utf-8?B?NkM3emNJK1hkdGlLUnpiWWFDeFduY1VtazNEaEdUcVJ4NHBnZnZrT1NBTFhR?= =?utf-8?B?YmZIV09pY0pJd0V1YzhmYUVXSk9iN2lsbmVDcFBOcHBPT1JmeHZ2SkRMcHdN?= =?utf-8?B?MXV3UWg0UFlvOXE4NjBOYTNzZGVXdm5nZm5UV3VKbDhZeTBZL3IvWnNuOUFW?= =?utf-8?B?L1RVa0dicjcycUY3cU9WWmtrUlpTSFFXdGNDbXR1Qm1OcTZIMWw1TXBMeVk4?= =?utf-8?B?QjJnWjNkcExoeUkxTFJtOCsvVjRWSXYwcnNaSUNlYy9Yb1g0dFdnejJaRXBP?= =?utf-8?B?dE9LNlBWK0R1OGZ2eDZFMjNCd2VteWIvdGF6UmRmWjIwY2RnMGlGWGw5Z2ZS?= =?utf-8?B?NFV6M24xc2M4YkpRdTl1WU1CaGZ5c29sSlB5ZlJIWTY3aE5jUHppR2ZVK2Zp?= =?utf-8?B?ODFzSDhoLzdUQ2NiL1Uza3IzVXZMNFV3MU81anFhLzVqUVZIYVV5U1pUdG0z?= =?utf-8?B?WWFTWkk1WlJVazFWMXgyd2dva2ZvRVBZNW8wcUJzOEFYQmFyd0NHR2VSYWpw?= =?utf-8?B?NmZ3ZnpHN2lvSVhzVVo5K05HVEVRWFRQY1dYdGpJN3loTWRPK2dxS3RwVm5E?= =?utf-8?B?VmtvUUFjdmpoektaQ0krcDVKQ25SeDJUbTlWdk8vMlZkSHpybm5IM3FJdkM2?= =?utf-8?B?SUtEcnl4OFVBczFKUEYxSTAzV1NLeHNlOURmZmNpK21KeFdkNk55SWRqUXRn?= =?utf-8?B?SGxzc1ZBSzNuZVpLZGxTSlVGMTY4NWw1cFJORUpwbFFObUlJell1eWhwTHdC?= =?utf-8?B?Nkk1Q2RaWUhPb3ZWQWdtcDQvU2dxekduVlJiR3dSZU5sY1RROVhVdlVuM3lt?= =?utf-8?B?M05reGx6cFlxYVJVSFF2N0E1Y3dMZjcrOHBDdC9IYW9CM2xERUlQQ3Fmbmdk?= =?utf-8?B?Mng0S0dUK1owU2tKRTNERnV4cllhL2ZabHp1U05KaDJ1MWxkaHJ0VXNwWTY4?= =?utf-8?B?SXRHTDQ4bCs1QWpiMisyZjd2d2xsYVVPcW9lVzFTaUkrcjR1MDZLNHI0eGY3?= =?utf-8?B?WUsrQ3c4RzhqenNNNVZVenlURys2a3NpaitxZGpUaHN4c1Vkd09FSVM5VGhL?= =?utf-8?Q?dPUXK8RkzRZmLD9zBopQ13767?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d63a4d2e-3905-47b0-46f4-08db682d2889 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 14:32:16.8275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HkG/FveKOkmYEBNK169g12M5jjtnYkxi9isa93MiLMz88Q7TZFjHl237BYpWaXds X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4198 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/8/2023 2:31 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswap modes. To facilitate adding this support, some new header files > were added. > > Signed-off-by: Mike Pattrick > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. > @@ -4052,9 +4052,16 @@ rxtx_config_display(void) > { > portid_t pid; > queueid_t qid; > + char buf[32]; > + > + if (cur_fwd_eng->status) > + snprintf(buf, sizeof(buf), " (%s)", cur_fwd_eng->status); > + else > + buf[0] = '\0'; > > - printf(" %s packet forwarding%s packets/burst=%d\n", > + printf(" %s%s packet forwarding%s packets/burst=%d\n", > cur_fwd_eng->fwd_mode_name, > + buf, > retry_enabled == 0 ? "" : " with retry", > nb_pkt_per_burst); > > @@ -4816,10 +4823,17 @@ pkt_fwd_config_display(struct fwd_config *cfg) > struct fwd_stream *fs; > lcoreid_t lc_id; > streamid_t sm_id; > + char buf[32]; > + > + if (cfg->fwd_eng->status) > + snprintf(buf, sizeof(buf), " (%s)", cfg->fwd_eng->status); > + else > + buf[0] = '\0'; > > - printf("%s packet forwarding%s - ports=%d - cores=%d - streams=%d - " > + printf("%s%s packet forwarding%s - ports=%d - cores=%d - streams=%d - " > "NUMA support %s, MP allocation mode: %s\n", > cfg->fwd_eng->fwd_mode_name, > + buf, > retry_enabled == 0 ? "" : " with retry", > cfg->nb_fwd_ports, cfg->nb_fwd_lcores, cfg->nb_fwd_streams, > numa_support == 1 ? "enabled" : "disabled", Removed interim 'buf' variable (and 'cfg->fwd_eng->status' specific check), and updated as following while merging: ``` - printf(" %s packet forwarding%s packets/burst=%d\n", + printf(" %s%s%s packet forwarding%s packets/burst=%d\n", cur_fwd_eng->fwd_mode_name, + cur_fwd_eng->status ? "-" : "", + cur_fwd_eng->status ? cur_fwd_eng->status : "", ```