From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30CB9464A3; Fri, 28 Mar 2025 14:05:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16523402C1; Fri, 28 Mar 2025 14:05:45 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mails.dpdk.org (Postfix) with ESMTP id 9346B40269; Fri, 28 Mar 2025 14:05:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743167143; x=1774703143; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ATS9CE/U1fW8YMu9H75XDVX51pTkfdxcNuTA+Anl0E8=; b=aumHerYdl7pFWKkuy214V4ORvFKxq+SOLc70WYKM+XukjzXIUvwn9Bjq 7FMpeCxMApmMsFP8Uav6bxzreY6TShuB+/nhC69bLI1m6sJiJ0+SA2yLk du3G7EPlO2E1xqPz6ynjGUnLYjFKmWpEctDIlJpHxq28LBdYTXc9egK9y OG2z2JyoZQtOmzBmFAZA06e6qN2CSA87npHWijEIrYw9qj8J/rGonWtRY OXkYJ0HKizvW8G4mKw+kvU61/Q7XYb8pwtOhVgZxr5ka6GgITqWOXo3nA L+/9ITz6TTfZ53lSzodkafyIoavKkRdi/tjYUhjYXS6HLfJIFAzJpYoUH A==; X-CSE-ConnectionGUID: 1lhry+ASTMywpGzLcK2Msg== X-CSE-MsgGUID: DLkdeW0RRl2h4A5iInDvDw== X-IronPort-AV: E=McAfee;i="6700,10204,11387"; a="44709662" X-IronPort-AV: E=Sophos;i="6.14,283,1736841600"; d="scan'208";a="44709662" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2025 06:05:41 -0700 X-CSE-ConnectionGUID: WIdl8wNhQYqBLbdAr6YW0Q== X-CSE-MsgGUID: 6i8NvRWQR4uXDQQxWQYDGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,283,1736841600"; d="scan'208";a="125952606" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Mar 2025 06:05:42 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 28 Mar 2025 06:05:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Fri, 28 Mar 2025 06:05:41 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 28 Mar 2025 06:05:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BeyJHJjT9fdHiV+xRbUG7yuIdFhzb8AT0UmORfdkjh/1XmgNogIq0ExOMP/me1YqmlLp28BoNLZUYfY5N/t003X82PQwu2xKqwXm2wMCvbdcboLEqHc6kWwUS0AaosOA6PKSf1KTctc3Q4IRki0JaUYNEbHPjqhi6F3VF3GI/IDHEjkGHAku8adIO8i0QAVgmT0Ff/hqVUhqHMy1DNxmZRAiZiROZKk7iHckJjVjUNC+BQTgWH6uXfbOZOevQ6G1DzZnE7oC4l3KhlFjzPvaCSepOuyq6nUuo0U5Z3oLQL+KclAcRwPZESCLf5hchl9PvRE9jI7/2spE9xmaZgqnoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GgnuK/sRhXYtKTKANewxjp0V4ITtvBbAY3kg7gwXiWs=; b=s+1UInaz+UEs+x4cUkTCgNx+aAgbPYTziBIIRafD3w2gJ769GEN77UZ7aC9xxvQ9NIHX16UTS9dycNh8oQPJIqMi++63gEwL9OwY6zefBuiJqfcH9Vpkqc2iSVwBSVy31QRfYeuyeK/x0u+oVwDQzJdLK9RH3VekpeOWNWumsxx5FZ0W3HuOZyDuRAyxj7fJJ9QUX7Tm+XBOyl8jUXopZTBJJseUzP25wZed+nb7p+TEJo/8ewumY0u+Cmo+YvIT9ZWUSpXcF7SdsnpZYkj2mcFGDnnx1GY3QB50cnQIilnXM1f3jdbhwg5MZIyA2L0IfBSsvf+5Ntjpbn2b7RdOXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CH0PR11MB5282.namprd11.prod.outlook.com (2603:10b6:610:bd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.50; Fri, 28 Mar 2025 13:05:39 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%2]) with mapi id 15.20.8534.043; Fri, 28 Mar 2025 13:05:39 +0000 Message-ID: <5e1e8f75-6d63-42ad-be71-3bbbbfb743f4@intel.com> Date: Fri, 28 Mar 2025 14:05:33 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/9] net/ixgbe/base: fix lock checker errors To: Bruce Richardson , CC: David Marchand , Vladimir Medvedkin , References: <20250326155230.1315056-1-bruce.richardson@intel.com> <20250328111621.2665257-1-bruce.richardson@intel.com> <20250328111621.2665257-6-bruce.richardson@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20250328111621.2665257-6-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR05CA0051.eurprd05.prod.outlook.com (2603:10a6:10:2e::28) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CH0PR11MB5282:EE_ X-MS-Office365-Filtering-Correlation-Id: ec8dde33-310a-4d56-cef4-08dd6df93cbe X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?elN5Z25RRDJ3LzgxY1BTZzA4NzRaZ1JXMW5TQXhrU3VaUnBha3pyaWg3Z0dK?= =?utf-8?B?ZisyQXdzZHk2UUt1TkpCcitwT1V4ejRuVFNNZzBCQmlTcno4d0NhM0h2OEFi?= =?utf-8?B?azFyVlNReDJGRFAzc1VkdTVEVmhvRDBNb3pYRUZ5Z1hzc3lvVC84ekxNKzFQ?= =?utf-8?B?RCs3MEt4Zmk5SFBCS1kxUSt5aW9iUGppYmVNb0pobTJXeWZpRzhoWUM1am9k?= =?utf-8?B?MDBHNC90K2RicTVIRE13Sno5WXpiNkpCa0Q2TUJXRmFDaWY0VSttUWFzbjYx?= =?utf-8?B?enVaL0VlRStKZ3dWZFE0NTJLSVFwWWpPOHRHZndpNXFYUFhWbnEyNXdESXM0?= =?utf-8?B?Vzh2bEpCb2dHZEhBNGpZL0s0RDhmbDk2SFQzV2RLQ1BvYjhKV0pmUWpMak9O?= =?utf-8?B?Q1k1ck10RFhhcEJxOFA0MGhJaXArZ254SDJ0WDhqQ0VveW52TlZrZjVRbUky?= =?utf-8?B?RzVuMW1OclpwWmdESWtVUGlXZ21adDhLVmN6RGhHcWJVR1RGNEovdHh1NkRZ?= =?utf-8?B?eW9HeDhrbTZCaFZoQTh1b2hZdEpPRUU3QlVOQnk3UmszLzdxWlRmUzVRNUpk?= =?utf-8?B?bmp3R25ncGJWUTRXVXFBbGRWSmIzVk5zcFpuNlVaZ0VxOU5XQ0RIVjZhU1VX?= =?utf-8?B?QlR1K2pQakdtNHhkQThQVms1cXhOUkdDbDFVU1ZWQkdYLytRdmtRU01vWU5y?= =?utf-8?B?bGRWbmYyTEFWTTZOek9PR1N1Q1MxUkFHQWJhbktFOFV2NmxkWWlaVVZFZ2dt?= =?utf-8?B?cy9FY0JsTDRnWTlhT1VBUGNJNVJ5VTJCNXk5U0JPNFJYTEhqRFpBNnlxNG1u?= =?utf-8?B?UVBlMkFtbk1DM1JGMzlwVzFucGVVV3d4ZStKTHI4Lzg1VS9Qd2NEdFZHSlla?= =?utf-8?B?Vmt2QkVJMjYrakdxcWU1Uy9qeC9xYjg3L01YeXBZUjVQcUYvL2dBeDgzQmtC?= =?utf-8?B?WDg1NGs5WU1WZW5pSDFKOElBOGJHNVA4Z0t0ekJCRzZ1d3RhL21EODJhTFRG?= =?utf-8?B?aHVGY3lnWVdhQlNPclFzWEtYZ1VQQU5YaHNXcGNSVUFydGI3K2NIUnhTOVA0?= =?utf-8?B?N1kra2RucEZSMVZTV0tWV0FBMEFCbVNtenRodm13d1BjdmRQRWZ0bi9ObmdK?= =?utf-8?B?Z1FYMFVjQTh1L2lzWGwrVXhmei9kWUF6dUkvOWRQdlhJbDFISkdXVTZ3UnVV?= =?utf-8?B?TnNjR0tQV2MzMXRjQnNrQWlERHhlZXNYck1nZGRXMmpSS3o5SXVvRzVjZGZU?= =?utf-8?B?TkNzUWZOUWtsSEJkV1cyS2VUQnVWaVVXU0tJTG1VOXM3R3IrUmRxcnNrRzAw?= =?utf-8?B?ejlCL0xDTTZjTnlBNmtTY3dDVWFIQytud2hUWkxiTlZ6RjBvR01QNW9Ib25z?= =?utf-8?B?VVl3U3ZNK2JVS3M1eEt2LzcwVnFQcXFibm93WTQ1V0ZHU29MeHRzSFRDSlhR?= =?utf-8?B?MkNSMWR5OVRMdEI2RDhRcHBobjIzcXZxK0tRaTUxQkMxenRlRzlmcGcrUEh5?= =?utf-8?B?b21zYzBkbjlzYmpwcCtDWHpJUXU1SlFrNU1FNVhoamU5RStoaStla0FOOW82?= =?utf-8?B?UUkrQllRb3gxUWVUUFovVGcvRmVGWnNnQU9pQ1ZUNnpSNjlTU0R6WDRoKzZ6?= =?utf-8?B?MkFIN2FPY1IyRThCUVREZVNQWnhFWGlTNERyWEU1TmdxQ05UcjgyUjJnSFJX?= =?utf-8?B?TXpOMWhRK0lCb0lQZmNQQkNXQnZNdU1oQVdFNy9BMlNMN0EwUVlhTTFIc1p4?= =?utf-8?B?TEtjYjY4bHIwTHpTSnA0UGp2YmlWWXNRaDZuMG9GbThnWS9FRmN5dnFQcE0v?= =?utf-8?B?TUpmUDNDUGZ2S2d1alF6eFBIVDlzdW8zNVg3NHZLRnZhU21HTlpCaWNlTDkz?= =?utf-8?Q?cU53X4Mv2lD85?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEtIejNEYm9JY0VSQmE5SEJEV1BwaGdOblhpdVBHMDJSZXZOMjVWVnBnd3hE?= =?utf-8?B?Q0huOHlHcTlwaEpXZHM3bU8wcmltYnNHMEZRVFdmV0N5aWxWZ0N1TkhSTzVT?= =?utf-8?B?U3hUaEIyY3gzWDRRR1RkYW1qTW50VXc0NTVlekduenFEazhrV1dwWWtUSjVU?= =?utf-8?B?bFliOVpTU01VaWFyUXQxSDAyb3dyTklNaExqQmRxcnVUTmFBdmRvY2JLMXZ6?= =?utf-8?B?UHIrY0hNSy9BVEd4L1ZJaDRjMDZDUGFuNnl1K0pJYndPWE9UQTBDVlltN2xm?= =?utf-8?B?d2pjN1dRWHRKZXRScUVJVmNoZUZZQXJIZXVaaVFvcEYzekFTRmRKa05GZGRJ?= =?utf-8?B?RGJodm1wUmdjMGVsc0J5K211aklXbVMvRWYwVWpBWU01L0FoRGo1RXBXRXd4?= =?utf-8?B?RWp4c3ozR3VOcytyWFBHcUhlY2JUTnNlSGEzTk0yWURQMzYreVcxNmZrLytl?= =?utf-8?B?R3hxUng1N05UTFhLZVZad2kybFE2Y25kQXNCenlmQ09rOHBGNVdLSnYvaTVH?= =?utf-8?B?bGVZQkNDTjR4REs2WTRKdlpENStxWWx2R3M3bWN3NUVoMkhwS3k3U3Zqbkpu?= =?utf-8?B?TnUrSmI1VDJ0UVB6UnFXY3BPMnIyV2ZvaHY3SGN3cERubHZiQ2Jka1FtR25L?= =?utf-8?B?dEZnSHF3dlhtclF5b3FxRVh2Yk1hL2p3Rkg4d0QzcmVOK1BuRFJTNmYvS0Fn?= =?utf-8?B?WTFiaTF0aHR1Y0xFejRyVXdCWGhlQk9xbFQrYXAveWNubHJvUkd1QnJFWmFm?= =?utf-8?B?R2ttNFJVVjhOQ0ZaUnJvTXdwemlYd29lUys1RTd2bEVKMU1YOWtOZnpzMzZU?= =?utf-8?B?V1hLUlhNT3A0NXlwdTErQmZKTXUyN3VycWlXYUh5a3NTZFROZnMySWU1S0M2?= =?utf-8?B?Tk9sdzVFWVByalNFZlQ1bnQvcEFjQ0J2aytwU04xTWh6YnBQZ0VZem9IN3BT?= =?utf-8?B?Qm8xOW5yUEUrd3o5Mkl1K1NrNEJGdGlsOVdEUGk5RjBKVGFDeVNzSnIzWUFJ?= =?utf-8?B?V1BlMHhhd0lGdG4wT2RNYW5PaUd1MFZOd1JqN2FDVTh3Z2Q3SmNnZjhsemZ5?= =?utf-8?B?UFpGUEp6TDc3RkJkQjRRUjBiOWVHME9hays4c0pFQ2kwZGd5dVJXUUFKcUp6?= =?utf-8?B?azd1THFXU09UaXhseW5uUUhXTHJtSE5mNEhORG1tbU5DOGMwWHAzekdHOVVx?= =?utf-8?B?RkJoczcyUEFxaUd2UnNDU2xHRWphR0Q2azlRTzhyOFhHOVROMzduT3JWZVBw?= =?utf-8?B?cWVCcVBiZGRWc2lXSnZ4OHBuaEg1UHVleWlQeUJqeVBUMm9HZHl1S3RiUWdV?= =?utf-8?B?Yzd0RS9xbzJabEZpZ2V5THJxNUtBcXBiWUpkdi80aFJ5Zm5vby9IVmU2RUNm?= =?utf-8?B?YkpvZS9RRWRJd3phZ2hOc2t4RGlGejMvbzZjMXdFUTNxYWcram9zbHB4d01z?= =?utf-8?B?TkNCUTVOZjZkQ0NsYzkrWU52WERlc2J2Ly9pTDRhZnQwU3pvNEQvZC84bDU3?= =?utf-8?B?b0xBb0xIRzZGY2xGYUFoam54RXdwTUZiQjgyQkIvOTdaeWtlb0graVhubHJL?= =?utf-8?B?dEt5L1cvdnFBME9jVVAxL1Q3YVREVTI2SGwzTmNNaFRiREVKcTBNOEY3MktK?= =?utf-8?B?enVocXlVVjdDb2EzbXRtRHduQkdNS3NlTTcwK1ZzdHpsdXM1NDREaXUxaDda?= =?utf-8?B?SFd2eFJTNVZBQjNESTRoaW5pS2JNSThJQTRDNVNxdXNINDVLR0creUpnbUJL?= =?utf-8?B?T2VyeWtubG5SSERnRlAyQ0dhekJGK0xZaFlrejErSkl3NlFCSi9qcjIvNmV2?= =?utf-8?B?YWRlWWw1L2RZRHNZWlAzLzl5eGF1VmlOQVNIY0NyZGptYUd3REpDOWpGdk55?= =?utf-8?B?N1pRWVdtNmZIUzVSSytvVWFPTWFlbWs3Rk9JbUhlbGVzZmdHMC95QTYvbVlV?= =?utf-8?B?OGp3aGhUZkhndDV1czJQNFRCRnQ5azhQUDEzTGJuQkZUdXdRMzdqT2dsbnBS?= =?utf-8?B?OC9BTlNRaDFYT2JWbk83WGt0alJ0MURxZ1FuTnYyS0QxbFFLOUhzbzlxTU9y?= =?utf-8?B?QlIrTUlra2JsS3ZRUU41MGw3cnVXZ1ZZSkc3bTczdlRwRkpFQUIrSGZnVGV2?= =?utf-8?B?YWtHQ0NERnpVRXJtUjZGZkp5NGY4ZWxFUU5SWlZyVyt2MzRLdGQzcWVSUy9j?= =?utf-8?B?R2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec8dde33-310a-4d56-cef4-08dd6df93cbe X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2025 13:05:39.1510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NRTZ23r8S1ENIuV1sKXYKc+fy3woskBaYdhrw2d0kFuICWU+/F7P/dRhiHUQWJYpSyL/mpdX33mLNphA9Qvt8KtQbP9YrsheBOti1UFUQwE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5282 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/28/2025 12:16 PM, Bruce Richardson wrote: > When building on FreeBSD, errors are reported in the base code by the > lock checker (-Wthread-safety). For example: > > ../drivers/net/intel/ixgbe/base/ixgbe_osdep.c:42:1: error: mutex 'lock->mutex' is still held at the end of function [-Werror,-Wthread-safety-analysis] > 42 | } > | ^ > > These errors are due to the checker not recognising the lock wrapper > functions. We can avoid these errors by converting these functions into > macros. While converting the lock macros, we can also convert the memory > allocation functions too, which allows us to remove the osdep.c file > entirely from the build. > > Fixes: 30b19d1b5c43 ("net/ixgbe/base: add definitions for E610") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly