Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64

[Thinh Tran <thinhtr@linux.vnet.ibm.com>]

I looked at it, but I have a simpler patch below that can resolve the 
conflict, including after removing previous patches in mlx4/mlx5

Thanks,
Thinh Tran

  diff --git a/lib/librte_eal/ppc/include/rte_memcpy.h 
b/lib/librte_eal/ppc/include/rte_memcpy.h
index 25311ba1d..abeede231 100644
--- a/lib/librte_eal/ppc/include/rte_memcpy.h
+++ b/lib/librte_eal/ppc/include/rte_memcpy.h
@@ -11,6 +11,10 @@
  /*To include altivec.h, GCC version must  >= 4.8 */
  #include <altivec.h>

+/* redefine as in stdbool.h */
+#undef bool
+#define bool _Bool
+
  #ifdef __cplusplus
  extern "C" {
  #endif

On 4/28/2020 10:04 AM, David Marchand wrote:
> On Tue, Apr 28, 2020 at 5:02 PM Thinh Tran <thinhtr@linux.vnet.ibm.com> wrote:
>>
>> Agreed, this is not rte_trace issue. Moving to rte_common.h does not
>> work neither, because altivec.h is included after and redefine bool
>> This conflict happens on PPC64, I'll create a different patch.
> 
> Please look at Ori patch.
> Thanks.
> 
> http://patchwork.dpdk.org/patch/69426/
>