* [dpdk-dev] [PATCH] ethdev: fix missing names in Tx offload name array
@ 2018-09-06 12:01 Dekel Peled
2018-09-10 9:09 ` Andrew Rybchenko
2018-09-12 8:28 ` [dpdk-dev] [PATCH v2] " Dekel Peled
0 siblings, 2 replies; 5+ messages in thread
From: Dekel Peled @ 2018-09-06 12:01 UTC (permalink / raw)
To: thomas, ferruh.yigit, arybchenko, dev; +Cc: xuemingl, orika
Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
If new Tx offload capabilities are defined, they also must be mentioned
in rte_tx_offload_names in rte_ethdev.c file.
This patch adds the required lines in aray rte_tx_offload_names.
Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO")
Cc: xuemingl@mellanox.com
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
lib/librte_ethdev/rte_ethdev.c | 2 ++
lib/librte_ethdev/rte_ethdev.h | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 3f8de93..5004b9f 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -156,6 +156,8 @@ struct rte_eth_xstats_name_off {
RTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS),
RTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE),
RTE_TX_OFFLOAD_BIT2STR(SECURITY),
+ RTE_TX_OFFLOAD_BIT2STR(UDP_TNL_TSO),
+ RTE_TX_OFFLOAD_BIT2STR(IP_TNL_TSO),
};
#undef RTE_TX_OFFLOAD_BIT2STR
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index fa2812b..5456ce2 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -941,18 +941,18 @@ struct rte_eth_conf {
* the same mempool and has refcnt = 1.
*/
#define DEV_TX_OFFLOAD_SECURITY 0x00020000
+#define DEV_TX_OFFLOAD_UDP_TNL_TSO 0x00040000
/**
* Device supports generic UDP tunneled packet TSO.
* Application must set PKT_TX_TUNNEL_UDP and other mbuf fields required
* for tunnel TSO.
*/
-#define DEV_TX_OFFLOAD_UDP_TNL_TSO 0x00040000
+#define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000
/**
* Device supports generic IP tunneled packet TSO.
* Application must set PKT_TX_TUNNEL_IP and other mbuf fields required
* for tunnel TSO.
*/
-#define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000
#define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001
/**< Device supports Rx queue setup after device started*/
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: fix missing names in Tx offload name array
2018-09-06 12:01 [dpdk-dev] [PATCH] ethdev: fix missing names in Tx offload name array Dekel Peled
@ 2018-09-10 9:09 ` Andrew Rybchenko
2018-09-12 8:28 ` [dpdk-dev] [PATCH v2] " Dekel Peled
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2018-09-10 9:09 UTC (permalink / raw)
To: Dekel Peled, thomas, ferruh.yigit, arybchenko, dev; +Cc: xuemingl, orika
On 09/06/2018 03:01 PM, Dekel Peled wrote:
> Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
> If new Tx offload capabilities are defined, they also must be mentioned
> in rte_tx_offload_names in rte_ethdev.c file.
>
> This patch adds the required lines in aray rte_tx_offload_names.
>
> Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO")
>
> Cc: xuemingl@mellanox.com
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> lib/librte_ethdev/rte_ethdev.c | 2 ++
> lib/librte_ethdev/rte_ethdev.h | 4 ++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 3f8de93..5004b9f 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -156,6 +156,8 @@ struct rte_eth_xstats_name_off {
> RTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS),
> RTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE),
> RTE_TX_OFFLOAD_BIT2STR(SECURITY),
> + RTE_TX_OFFLOAD_BIT2STR(UDP_TNL_TSO),
> + RTE_TX_OFFLOAD_BIT2STR(IP_TNL_TSO),
> };
>
> #undef RTE_TX_OFFLOAD_BIT2STR
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index fa2812b..5456ce2 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -941,18 +941,18 @@ struct rte_eth_conf {
> * the same mempool and has refcnt = 1.
> */
> #define DEV_TX_OFFLOAD_SECURITY 0x00020000
> +#define DEV_TX_OFFLOAD_UDP_TNL_TSO 0x00040000
> /**
> * Device supports generic UDP tunneled packet TSO.
> * Application must set PKT_TX_TUNNEL_UDP and other mbuf fields required
> * for tunnel TSO.
> */
> -#define DEV_TX_OFFLOAD_UDP_TNL_TSO 0x00040000
> +#define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000
> /**
> * Device supports generic IP tunneled packet TSO.
> * Application must set PKT_TX_TUNNEL_IP and other mbuf fields required
> * for tunnel TSO.
> */
> -#define DEV_TX_OFFLOAD_IP_TNL_TSO 0x00080000
I don't understand why it is changed. Comments should be before define.
>
> #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001
> /**< Device supports Rx queue setup after device started*/
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] ethdev: fix missing names in Tx offload name array
2018-09-06 12:01 [dpdk-dev] [PATCH] ethdev: fix missing names in Tx offload name array Dekel Peled
2018-09-10 9:09 ` Andrew Rybchenko
@ 2018-09-12 8:28 ` Dekel Peled
2018-09-12 8:33 ` Andrew Rybchenko
1 sibling, 1 reply; 5+ messages in thread
From: Dekel Peled @ 2018-09-12 8:28 UTC (permalink / raw)
To: thomas, ferruh.yigit, arybchenko, dev; +Cc: xuemingl, orika
Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
If new Tx offload capabilities are defined, they also must be mentioned
in rte_tx_offload_names in rte_ethdev.c file.
This patch adds the required lines in array rte_tx_offload_names.
Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO")
Cc: xuemingl@mellanox.com
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
v2:
* Discard change of comments location in file rte_ethdev.h.
---
lib/librte_ethdev/rte_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 3f8de93..5004b9f 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -156,6 +156,8 @@ struct rte_eth_xstats_name_off {
RTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS),
RTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE),
RTE_TX_OFFLOAD_BIT2STR(SECURITY),
+ RTE_TX_OFFLOAD_BIT2STR(UDP_TNL_TSO),
+ RTE_TX_OFFLOAD_BIT2STR(IP_TNL_TSO),
};
#undef RTE_TX_OFFLOAD_BIT2STR
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] ethdev: fix missing names in Tx offload name array
2018-09-12 8:28 ` [dpdk-dev] [PATCH v2] " Dekel Peled
@ 2018-09-12 8:33 ` Andrew Rybchenko
2018-09-12 17:20 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Rybchenko @ 2018-09-12 8:33 UTC (permalink / raw)
To: Dekel Peled, thomas, ferruh.yigit, arybchenko, dev; +Cc: xuemingl, orika
On 09/12/2018 11:28 AM, Dekel Peled wrote:
> Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
> If new Tx offload capabilities are defined, they also must be mentioned
> in rte_tx_offload_names in rte_ethdev.c file.
>
> This patch adds the required lines in array rte_tx_offload_names.
>
> Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO")
>
> Cc: xuemingl@mellanox.com
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] ethdev: fix missing names in Tx offload name array
2018-09-12 8:33 ` Andrew Rybchenko
@ 2018-09-12 17:20 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-09-12 17:20 UTC (permalink / raw)
To: Andrew Rybchenko, Dekel Peled, thomas, dev; +Cc: xuemingl, orika
On 9/12/2018 9:33 AM, Andrew Rybchenko wrote:
> On 09/12/2018 11:28 AM, Dekel Peled wrote:
>> Patch 5355f443 added two definitions of DEV_TX_OFFLOAD_xxx.
>> If new Tx offload capabilities are defined, they also must be mentioned
>> in rte_tx_offload_names in rte_ethdev.c file.
>>
>> This patch adds the required lines in array rte_tx_offload_names.
>>
>> Fixes: 5355f4439e2e ("ethdev: introduce generic IP/UDP tunnel checksum and TSO")
>>
>> Cc: xuemingl@mellanox.com
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: stable@dpdk.org
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-12 17:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-06 12:01 [dpdk-dev] [PATCH] ethdev: fix missing names in Tx offload name array Dekel Peled
2018-09-10 9:09 ` Andrew Rybchenko
2018-09-12 8:28 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2018-09-12 8:33 ` Andrew Rybchenko
2018-09-12 17:20 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).