From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id F21A91B39C for ; Mon, 1 Oct 2018 17:59:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 08:59:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,328,1534834800"; d="scan'208";a="95482956" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga001.jf.intel.com with ESMTP; 01 Oct 2018 08:59:54 -0700 To: Gagandeep Singh , dev@dpdk.org Cc: pankaj.chauhan@nxp.com References: <20180928051647.32341-1-g.singh@nxp.com> <20180928074601.4287-1-g.singh@nxp.com> <20180928074601.4287-3-g.singh@nxp.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <5e573435-742b-e3e6-cef2-b83d21c1d93d@intel.com> Date: Mon, 1 Oct 2018 16:59:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180928074601.4287-3-g.singh@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/enetc: enable Rx and Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 15:59:57 -0000 On 9/28/2018 8:45 AM, Gagandeep Singh wrote: > Add RX and TX queue setup, datapath functions > > Signed-off-by: Gagandeep Singh <...> > @@ -104,16 +104,19 @@ enum enetc_bdr_type {TX, RX}; > #define ETH_ADDR_LEN 6 > > /* general register accessors */ > -#define enetc_rd_reg(reg) rte_read32((reg)) > -#define enetc_wr_reg(reg, val) rte_write32((val), (reg)) > -#define enetc_rd(hw, off) enetc_rd_reg((hw)->reg + (off)) > -#define enetc_wr(hw, off, val) enetc_wr_reg((hw)->reg + (off), val) > +#define enetc_rd_reg(reg) rte_read32((void *)(reg)) > +#define enetc_wr_reg(reg, val) rte_write32((val), (void *)(reg)) > +#define enetc_rd(hw, off) enetc_rd_reg((size_t)(hw)->reg + (off)) > +#define enetc_wr(hw, off, val) enetc_wr_reg((size_t)(hw)->reg + (off), val) > /* port register accessors - PF only */ > -#define enetc_port_rd(hw, off) enetc_rd_reg((hw)->port + (off)) > -#define enetc_port_wr(hw, off, val) enetc_wr_reg((hw)->port + (off), val) > +#define enetc_port_rd(hw, off) enetc_rd_reg((size_t)(hw)->port + (off)) > +#define enetc_port_wr(hw, off, val) \ > + enetc_wr_reg((size_t)(hw)->port + (off), val) > /* global register accessors - PF only */ > -#define enetc_global_rd(hw, off) enetc_rd_reg((hw)->global + (off)) > -#define enetc_global_wr(hw, off, val) enetc_wr_reg((hw)->global + (off), val) > +#define enetc_global_rd(hw, off) \ > + enetc_rd_reg((size_t)(hw)->global + (off)) > +#define enetc_global_wr(hw, off, val) \ > + enetc_wr_reg((size_t)(hw)->global + (off), val) Is there any reason to not add these functions as updated version at first plane at previous patch? > /* BDR register accessors, see ENETC_BDR() */ > #define enetc_bdr_rd(hw, t, n, off) \ > enetc_rd(hw, ENETC_BDR(t, n, off)) > diff --git a/drivers/net/enetc/enetc.h b/drivers/net/enetc/enetc.h > index 9fa7c726c..140daf0dd 100644 > --- a/drivers/net/enetc/enetc.h > +++ b/drivers/net/enetc/enetc.h > @@ -18,7 +18,11 @@ > #define MAX_RX_RINGS 1 > > /* Max BD counts per Ring. */ > -#define MAX_BD_COUNT 256 > +#define MAX_BD_COUNT 64000 Same here, is there a reason this has not been defined as 64000 in prev patch at first place. Or if this variable not used in prev patch at all, why not introduce here. <...> > @@ -37,6 +46,10 @@ static const struct eth_dev_ops enetc_ops = { > .dev_close = enetc_dev_close, > .link_update = enetc_link_update, > .dev_infos_get = enetc_dev_infos_get, > + .rx_queue_setup = enetc_rx_queue_setup, > + .rx_queue_release = enetc_rx_queue_release, > + .tx_queue_setup = enetc_tx_queue_setup, > + .tx_queue_release = enetc_tx_queue_release, It is not very explicit in API doc but generally PMDs clean all queue related resources in dev_close() too, can you please implement it.