From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2095DA04B5; Wed, 30 Sep 2020 14:22:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2E171D58B; Wed, 30 Sep 2020 14:22:35 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B94511D587 for ; Wed, 30 Sep 2020 14:22:33 +0200 (CEST) IronPort-SDR: qUWtZ1MdtEYPk7D3RkEozs1JMzn6sSwlsil7I+QWgkU1TChX/Vv+hJoQhvzv6PwrBYL5xOWPWJ FYHcRYZgSCTA== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="180593313" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="180593313" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 05:22:31 -0700 IronPort-SDR: tf0P7qD99eKeK4jHvvxwzxv3oaP7vBmV1Vcu07ZnOV9v0vOvlS7+7My3omo4L1Ea8C+l4qBdBk QsFIam9AGnxQ== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="497304355" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.186]) ([10.213.251.186]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 05:22:30 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: arybchenko@solarflare.com References: <20200913220711.3768597-1-thomas@monjalon.net> <20200928231437.414489-1-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <5e9223d8-e437-3602-3634-69dea83eacc8@intel.com> Date: Wed, 30 Sep 2020 13:22:28 +0100 MIME-Version: 1.0 In-Reply-To: <20200928231437.414489-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 00/29] cleanup ethdev close operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2020 12:14 AM, Thomas Monjalon wrote: > This is the end of a process started two years ago, > to have a close which reliably releases an ethdev port > without the need of removing the device (which can have more ports). > > Unfortunately, some drivers might be broken because did not follow > the migration recommendations. We cannot wait more, > this should be merged before the 20.11-rc1 release. > > > v3: > - integrate NXP patches for dpaa, dpaa2, enetc and pfe > - fix crash in rte_eth_dev_release_port() because of early memset 0 > > v2 (big thanks to Ferruh for the reviews): > - rebase on top of cxgbe updates > - integrate updated patches for tap, bnx2x, qede > - return 0 in atlantic PMD > - fix failsafe mutex free > - remove useless check in pcap > - fix testpmd port state transition > - add primary process check > - reset more pointers in rte_eth_dev_release_port() > - remove dev_started reset in rte_eth_dev_close() > - return int from rte_eth_dev_close() > > Note for future: fix old memory leak when releasing port, > i.e. free callbacks link_intr_cbs, post_rx_burst_cbs, pre_tx_burst_cbs. > > The last 3 patches are optional changes to ethdev close/release > which were requested by Ferruh but may take longer to be accepted: > - memset 0 > - keep start state > - int return > > > Rasesh Mody (2): > net/bnx2x: release port upon close > net/qede: release port upon close > > Sachin Saxena (4): > net/dpaa: release port upon close > net/dpaa2: release port upon close > net/enetc: release port upon close > net/pfe: release port upon close > > Thomas Monjalon (22): > ethdev: reset device and interrupt pointers on release > ethdev: allow drivers to return error on close > net/af_packet: release port upon close > net/atlantic: release port upon close > net/axgbe: release port upon close > net/bonding: release port upon close > net/failsafe: release port upon close > net/mlx4: release port upon close > net/null: release port upon close > net/octeontx: release port upon close > net/pcap: release port upon close > net/ring: release port upon close > net/softnic: release port upon close > ethdev: remove old close behaviour > drivers/net: accept removing device without any port > drivers/net: check process type in close operation > drivers/net: remove redundant MAC addresses freeing > app/testpmd: reset port status on close notification > app/testpmd: align behaviour of multi-port detach > ethdev: remove forcing stopped state upon close > ethdev: reset all when releasing a port > ethdev: allow close function to return an error > > Yunjian Wang (1): > net/tap: release port upon close > Since some discussions going on them last three patches not merged, they can be sent separately. Except from last three patches, 27/29, 28/29, 29/29, Series applied to dpdk-next-net/main, thanks.