From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F788A00E6 for ; Thu, 11 Jul 2019 11:17:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E2397CBC; Thu, 11 Jul 2019 11:17:21 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6D9E74C8E for ; Thu, 11 Jul 2019 11:17:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 02:17:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,478,1557212400"; d="scan'208";a="364755944" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.82]) ([10.237.220.82]) by fmsmga005.fm.intel.com with ESMTP; 11 Jul 2019 02:17:17 -0700 To: Takeshi Yoshimura , dev@dpdk.org Cc: Thomas Monjalon , David Christensen References: <20190711022235.2958-1-tyos@jp.ibm.com> From: "Burakov, Anatoly" Message-ID: <5ea05b05-8054-6c9b-af73-d8bc106aa5af@intel.com> Date: Thu, 11 Jul 2019 10:17:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190711022235.2958-1-tyos@jp.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vfio: fix build errors on old Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11-Jul-19 3:22 AM, Takeshi Yoshimura wrote: > The commit db90b4969e2e ("vfio: retry creating sPAPR DMA window") > introduced a build breakage on old Linux. Linux <4.2 does not define ddw in > struct vfio_iommu_spapr_tce_info. Without ddw, we cannot change window size > and so should give up the creation. I just exculuded the retrying code if > ddw is not supported. > > Fixes: db90b4969e2e ("vfio: retry creating sPAPR DMA window") > > Signed-off-by: Takeshi Yoshimura > --- Tested-by: Anatoly Burakov -- Thanks, Anatoly