DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gaoxiang Liu" <gaoxiangliu0@163.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	 "dev@dpdk.org" <dev@dpdk.org>,
	 "liugaoxiang@huawei.com" <liugaoxiang@huawei.com>,
	 "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: add log print of socket path on adding connection
Date: Tue, 7 Sep 2021 08:47:41 +0800 (CST)	[thread overview]
Message-ID: <5ea1fd96.667.17bbdb99661.Coremail.gaoxiangliu0@163.com> (raw)
In-Reply-To: <MN2PR11MB406346C5E34BEC64F66FBF549CD29@MN2PR11MB4063.namprd11.prod.outlook.com>

Hi chenbo,
I will fix the issues in [PATCH v2].


Thanks.
Gaoxiang.

At 2021-09-06 13:35:23, "Xia, Chenbo" <chenbo.xia@intel.com> wrote:
>Hi Gaoxiang,
>
>> -----Original Message-----
>> From: Gaoxiang Liu <gaoxiangliu0@163.com>
>> Sent: Saturday, September 4, 2021 10:28 PM
>> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
>> Cc: dev@dpdk.org; liugaoxiang@huawei.com; Gaoxiang Liu <gaoxiangliu0@163.com>;
>> stable@dpdk.org
>> Subject: [PATCH] vhost: add log print of socket path on adding connection
>> 
>> Add log print of socket path in vhost_user_add_connection.
>> It's useful when adding a mass of socket connections,
>> because the information of every connection is more clearer.
>
>More clearer -> clearer
>
>> 
>> Fixes: a277c7159876 ("vhost: refactor code structure")
>
>I think it should be this commit:
>
>8f972312b8f4 ("vhost: support vhost-user")
>
>> Cc: stable@dpdk.org
>> 
>> Signed-off-by: Gaoxiang Liu <liugaoxiang@huawei.com>
>
>Do you have issue sending with this email address? If not, please use
>the same for one commit.
>
>And please use 'Plain Text' when replying comments. I noticed you are
>using HTML for other patches, which is not suggested.
>
>Thanks,
>Chenbo
>
>> ---
>>  lib/vhost/socket.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
>> index d6f9414c4..c6548608a 100644
>> --- a/lib/vhost/socket.c
>> +++ b/lib/vhost/socket.c
>> @@ -243,7 +243,7 @@ vhost_user_add_connection(int fd, struct vhost_user_socket
>> *vsocket)
>>  			dev->async_copy = 1;
>>  	}
>> 
>> -	VHOST_LOG_CONFIG(INFO, "new device, handle is %d\n", vid);
>> +	VHOST_LOG_CONFIG(INFO, "new device, handle is %d, path is %s\n", vid,
>> vsocket->path);
>> 
>>  	if (vsocket->notify_ops->new_connection) {
>>  		ret = vsocket->notify_ops->new_connection(vid);
>> --
>> 2.32.0
>> 
>

  reply	other threads:[~2021-09-07  0:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-04 14:28 Gaoxiang Liu
2021-09-06  5:35 ` Xia, Chenbo
2021-09-07  0:47   ` Gaoxiang Liu [this message]
2021-09-07  0:51 ` [dpdk-dev] [PATCH v2] " Gaoxiang Liu
2021-09-07  1:35   ` Xia, Chenbo
2021-09-14 11:30   ` Maxime Coquelin
2021-09-16 12:28     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-09-16 12:33       ` Maxime Coquelin
2021-09-16 12:37         ` Xia, Chenbo
2021-09-16 12:57           ` Ferruh Yigit
2021-09-16 13:16             ` Xia, Chenbo
2021-09-16 13:36               ` Gaoxiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ea1fd96.667.17bbdb99661.Coremail.gaoxiangliu0@163.com \
    --to=gaoxiangliu0@163.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=liugaoxiang@huawei.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).