From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B8CEA0553; Thu, 20 Oct 2022 16:39:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F09C42D53; Thu, 20 Oct 2022 16:39:35 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2052.outbound.protection.outlook.com [40.107.102.52]) by mails.dpdk.org (Postfix) with ESMTP id DB25E42C61 for <dev@dpdk.org>; Thu, 20 Oct 2022 16:39:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FBE32rvybgEW9IXsPug3c6FMLYL+A3eh+jFMk6YDZvUW9YG/YDbIoUuX6YYFVhgwnkWdLQbxG1CY4R1Zwln3NtkdRhTukPw/AIMiUGi606YIT3ljHfYpxbdnYEJIVnEIKevEc0xmC063YGyJH1Yd2JG738UaAIjijn8MfHRlNWoZWVRZ0v5W5cLrZ03m7vgX+9F+xr7IfdeW0t8XxCDPD1R8Q6tBmfjmZy2tvEJeq60T3CmUCo1NOp7GEb8aNkphOUYps3tj1ZN40myA8isXFtYpWlFFq7mhL3xhWRoixU+qDxFselHXk8vpgIIpFnjRu7xzUvQDw1QcMf+QBE7tGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iMX0nDHmNn9I2PwPhH+zZPabTE7CJ7BdBhgpuadHSJQ=; b=N1Wm1qc50/TDTq0yBjuUUTNVq7GxwC6UPrAga372V3+g6NXsnyxJrRP9z0Hbdc7V4rDYdE6JR6ThIKeaIAKjtBdGlYhkwnBDREh1GV7tIzRG54pmdeMuu1k4vXoOCQe6IW5x10hPHNRfxYQLw+tWDDWG8zx7Zpnpto237ieP7Q20HyLtwz/tBLBa6cMX3zt/MlqcyqDow2K/Wk2ClyeeksCLvqc3/e4pCyFbwa64+bcObViSTfTaHwQwN4GSPRi8AXbgiZWftTYN6AJ15rYygD2mOWNOxJL6NVOhDjeM3IW7g946cIskLwJUukQ0zDB2A0tMr6PrsZ1t5Hk+Z34bVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMX0nDHmNn9I2PwPhH+zZPabTE7CJ7BdBhgpuadHSJQ=; b=Sg1X9EqySln1nU+VcivWzXGERiiuEitFC5/i74Mw5/hirncnz/ZUvT0r2z8ohhoRuOtvpBdsfGAuB/W3E4sqEBPS4XVG/bAMwvHKz1ggiKTANri6SwQWfFp3jV6J1ztf9uqvG0xD7aQnU/Xdp+qleUUjzgDE0uBoPraQ8Qe8LRs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by MN2PR12MB4063.namprd12.prod.outlook.com (2603:10b6:208:1dc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct 2022 14:39:29 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 14:39:29 +0000 Message-ID: <5ea5a786-42e2-a3d0-59d5-adc7a4998010@amd.com> Date: Thu, 20 Oct 2022 15:39:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v6 1/8] net/gve/base: introduce GVE PMD base code Content-Language: en-US To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, Xiaoyun Li <xiaoyun.li@intel.com> Cc: dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, stephen@networkplumber.org, chenbo.xia@intel.com, helin.zhang@intel.com, Haiyue Wang <haiyue.wang@intel.com> References: <20221010101757.878317-2-junfeng.guo@intel.com> <20221020103656.1068036-1-junfeng.guo@intel.com> <20221020103656.1068036-2-junfeng.guo@intel.com> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20221020103656.1068036-2-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0380.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::7) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|MN2PR12MB4063:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fa193c4-d68e-46d6-3a06-08dab2a8e471 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1lqoxICD0sp2X0SInRyO/Nko3q9dYzxCyZS2hz/qkpO8wHu6JGkVgU2AvHCD5xyaInP1Gx4AgilGLOxz9U8kOxaPlnffpPqTcrPojVNEG2iY8KtFlul+nH6nEKEUwbIhAO0OYr8hKYKM1tiDX+H2L0e6/EtktH4MJ2ZIRWHcEyIo3ocAaOfiVGjiyigrR0xAeUmQlb/dS+d9XV5FJ7YbpIC9c1y0m2SC9DMNA+XxwxVEUuzYCmedOFJ8X5HvdROvEBRPYqQE6M4qN7JwOUdvkh/UNaA7jYALnS7wjRPQh9vohJ2DVB0pnNjmyHTWIg4CEu8Wn0vkBC/SVnsZqA9PCkd+hh5ciQSiR3gJVzNl4btwbp83XRDiELxfGsxR3F6RJKl+lWNVs/3TLuOH6wXLZiD0elSsjrrz7t8Q5WCqVFtLFrLul3pZF0pyf56APZTWLOdxUaXlvGy6uhtgX4uBQQ1JVVPUrqjN6fC4M3E/iZGCiAjzDCtHoPm8DGbjLzghysNzb/CLprQk/oJuYQSrqT8FntYyewvSDBFS3PJtiUB/UaMxZrzRGKA5NcjcpyiUVe38nHy7tKOE2LL6YIbs25pKLR1omvetO/aWNWJ1oALB6BExUBK28ARVBOx23nBiIniyCSFMSyzRunCshal2C6dexr0M+hjet2vO/KO21dJI0FmIaGZ8D1LtaahanW6RPYoSPJi563O6HGTNN+RhtXjV14DXNa0sev0Z2SbA13xgrcCtr4DBt4Ub/m7b49VO6eIIdUSyj41vlBEG7TQpeojy4fIy89r+5Skuv2CrYzk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(136003)(366004)(376002)(396003)(451199015)(4326008)(66476007)(66556008)(66946007)(110136005)(8676002)(7416002)(316002)(4744005)(38100700002)(2906002)(36756003)(44832011)(5660300002)(41300700001)(6506007)(8936002)(6486002)(6666004)(53546011)(186003)(2616005)(6512007)(26005)(31696002)(31686004)(86362001)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3hhd256Wnc4eHVGRG5mNnA5UjN4L1ozR0dUdm05c1BNUDdFRnJWSVF3ZUwv?= =?utf-8?B?TU9OS3BjRHJRbmFnZ3l6aE1MaC9PSk1xaFhMZkNkM3lnRDVyRmZRb3hPaHZ6?= =?utf-8?B?UU1IY2xnM1hlOU5HY1lwOWNacFhxeEE1ZUZvNzhiWFdEY2drNWZDbHdKWXEx?= =?utf-8?B?S1BVRFpGdWJhL1crYW5IQ0VkVnpadlBXenl1ZFFRU3FCWmtZUjBnejBZcytY?= =?utf-8?B?Nk5MOHBXT3RqOUdUci9nMHoyK2NXQVRBV08xY0tkaFJraU1ZR3hkUEtqMFdn?= =?utf-8?B?bWZaeW5WZE9Selgrai9TSnE1NGl6eDdsMmZlQkV1eXBzRHVxRUk2cU1RWnpy?= =?utf-8?B?Rld4ejJhbWxWbE1GSEs2MWlWWUtNeVQ3YlprUndRWlY1RkgwcEpBMDh3dld2?= =?utf-8?B?eWUvOVM1YTNCRGRKVTBvbERIZGppNndCMnVjSzJaR0h0eXh1bjVCdHJQYmIw?= =?utf-8?B?eHhuWlp4SmVVK0xBanl6VS93ZmtURkIrMUp4aXZVUFp3Y2xCM3AzemV3UkV5?= =?utf-8?B?czJXaCsxUWtWOTl6SWIvdnptczh6ZmtwV1VTbUsxdm14SmRUTEJGVDk1b3dP?= =?utf-8?B?N3lYeG1NTDFTMkc5dHRvYStjb3dyNFNTMVkraUg1UmRoVTVwRlJONmpDZEJG?= =?utf-8?B?M0lmKzVrS2QxdkcvaWJBMFNXUWN6b1lma1RkalZMR201VjZzODNiS09xQUIv?= =?utf-8?B?OGpKaU0yeDlLeS9qekRCcXFQMmc1Uy95ZXVGYjd1OVV1ck1lZXpYUVlyS0N5?= =?utf-8?B?d1FJVXhsRkJCNlMzQlFnZEo1aUFCc0MvTERDOElnVTBLRy85SzZBa1RDZElQ?= =?utf-8?B?VytiWXpmbExySjhOa2ROOTRzdUhJTXhDcnZ1RlAwMVozWW1LS0QybU9XRUVU?= =?utf-8?B?Nyt1YTN5ang4RmN2ZFlHbUZQeHpIOUR3WVVydzVnNkcvRThJdytuMFM5MHNZ?= =?utf-8?B?MTRkajh1YjJUbnRLUEtVNXF0SEVzdXB0WmF0M3NWWWdicjVtREp5dk1MYXVs?= =?utf-8?B?VTlmN2xTR2NaQXhmRlcyajVWUytsaGE3a25rdXQ4RlpPYUQ2YXBDbjlGRWtj?= =?utf-8?B?UGpGS2FCK0NZT1dPVzErdFcrRGdKMmtIdjVRRiticTVzL2YrOUJJTlRlcGNk?= =?utf-8?B?dFk0VGJGa2pFVXpxdFdQdXU3RnkxMEZxdHZMTHYvQXJQaDlkQi9xTUpLR1hN?= =?utf-8?B?TTA3L3JPSXVwQjVFdTF3dGU1WVc3d3NGckpqWGhiaGN1WUpvTGlSUS9Ga3J3?= =?utf-8?B?ckk0aDllQk4vTGYxNks5c0xoS0p4SCtmenphd1g5eFFnM1QwaTRycVhyWWJt?= =?utf-8?B?M08zOC9UQ01ZQ0MrTTJhcit2L244OFpHVDlBOEQyZmNRSGk0UkxjMjh1NjRk?= =?utf-8?B?eDlQQWZucEZrWk5XQ0lOeHprLysvd3FPNDh4WXZkeWsxOU1yTTM1MmoyTDlo?= =?utf-8?B?Qm1UQmNnK0VsN2tWS0JHMnh4RjhKak96NlpjQjV5NmpMYzJ5aXZOd1BqWm10?= =?utf-8?B?VFR1RmppWXJTYjZoWVBTWWNkWS91c0MxdEt4QWtocWhETW9oQ1VpUmNDVm5y?= =?utf-8?B?S0VOWXFqL3lJUTNaZzN3c3VsOU1GWXdpZ3I5c09vMWdPSTZxdUhTOFM1WXpC?= =?utf-8?B?a2xGNURYYktPMnNjNFZRYkNpSmN5REhiRXg4UFE3aW9IZWhNc21rQklpQkF1?= =?utf-8?B?VGdPYUN4Zy92cWN0TFpwaEx5Vmc5eHFjSUliQVM5M0NjTjY0a2s0ZXhLMFZT?= =?utf-8?B?QldFeUlvdjF6dzZCMzc2U1pVVnRnZ2hCT1lqQm83czVIZ1AxQyt4UGx4QzhD?= =?utf-8?B?TnpIWUJMRTMzR3FHMnJVT3p1bk5CUUZ1RTFYMVZoTFpSNVk3TzdrQ0RKeWg1?= =?utf-8?B?ak5TeVFHMkl3WGpQMnpxWGFmQzVBeFpIWUpEKy9lbFZQdUFCMzJremRSMGM1?= =?utf-8?B?TmdhNUQ2WTJSRTFvOERWR2VOU1NvTldabitsSllTc1hyVnlUbHlzaCt3Y1J4?= =?utf-8?B?STJOUkZiY0FHQXE3c3FrekxMbjFnYW12d2RDRDRXN3gyTm00OWowR1BrMW8v?= =?utf-8?B?RFhFSk5RZU85dFIwbStCOW5Jc0FjQ09EKzgvR2NDMWcxenoyS0kwYi94ZDIz?= =?utf-8?Q?T3yelFpRInH0uR00ztaf+6l/S?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa193c4-d68e-46d6-3a06-08dab2a8e471 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 14:39:29.1189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q8R7JE2H/Zd3Riq1ahdljlNcMCm/dKki6HhmYp+ZQrX6WvYqY+nBKRoWbruo2W6Q X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4063 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 10/20/2022 11:36 AM, Junfeng Guo wrote: > diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h > new file mode 100644 > index 0000000000..1b0d59b639 > --- /dev/null > +++ b/drivers/net/gve/base/gve.h > @@ -0,0 +1,58 @@ > +/* SPDX-License-Identifier: MIT > + * Google Virtual Ethernet (gve) driver > + * Version: 1.3.0 [1] > + * Copyright (C) 2015-2022 Google, Inc. > + * Copyright(C) 2022 Intel Corporation [2] > + */ > + > +#ifndef_GVE_H_ > +#define_GVE_H_ > + > +#include "gve_desc.h" > + > +#define GVE_VERSION "1.3.0" > +#define GVE_VERSION_PREFIX "GVE-" > + Is it clarified/decided to keep version in the file comment [1] and keep Intel copyright [2], or is this just not addressed yet?