From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50088.outbound.protection.outlook.com [40.107.5.88]) by dpdk.org (Postfix) with ESMTP id C79BF8E81 for ; Tue, 17 Apr 2018 16:18:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2zQenSMlPi7TWLuoOb4wDj26BpQHIePKZS8y6leXpoM=; b=Gev8iC0VjigGAylKRbgAtxLllQ7kZ2WoXCmBwwA4Kx+iGlz94WioAeVGM2a0iRt4tPpWTywEXSOq71KWsu9kNin3oeZ3oeYYBTmJyrwEUrrd92BndIhnHfH6KADREx8EaZdM8N7727+xr/nhQx9Z+dDwvPp6+JX/1P4cR17Sd/g= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [IPv6:2402:3a80:9d2:4991:d854:84e3:2b1a:aa5f] (2402:3a80:9d2:4991:d854:84e3:2b1a:aa5f) by DB5PR04MB1383.eurprd04.prod.outlook.com (2a01:111:e400:58da::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Tue, 17 Apr 2018 14:18:49 +0000 To: Abhinandan Gujjar , jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, dev@dpdk.org References: <1522824999-61614-1-git-send-email-abhinandan.gujjar@intel.com> Cc: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com, narender.vangati@intel.com, nikhil.rao@intel.com, Gage Eads From: Akhil Goyal Message-ID: <5ea61576-9124-266a-00e6-cb9f22a37f59@nxp.com> Date: Tue, 17 Apr 2018 19:48:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1522824999-61614-1-git-send-email-abhinandan.gujjar@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2402:3a80:9d2:4991:d854:84e3:2b1a:aa5f] X-ClientProxiedBy: BM1PR01CA0100.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::16) To DB5PR04MB1383.eurprd04.prod.outlook.com (2a01:111:e400:58da::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB5PR04MB1383; X-Microsoft-Exchange-Diagnostics: 1; DB5PR04MB1383; 3:X157BFvXs/b/nK2cD5E/jjjO6sh9o1kuWBBFgjsg82jZIHCfpNP8WKVtWEnEoOpeumGelIfN1ZNa40vxJUgb3ac+R9hK55Ahl12rYsOKzNqobdbXHoESXzLxj3yNiJ/6Cx9e1K47Iq91T6MKOSOJAzvR5E7SgKb0g0oR/nyFH6Jt38ngGwZA+boQq2SejzzBsKU5u+F4SbSXIzsaSpD1CNGiSEbuSKJzPKwp1jhnZ+kZKPeaO2MAAvOIugIoCTMv; 25:UepxZ6+Y51NFtP1808XCShw4wkjht7sWdJwg+8tcR0y2aOVAjqFgeDaRcl44Kefwb+UvSyS5bdCzm265o3VjtZhQ8fV2PzuAlsJFGdPeDixYRpxfKvEdjKiNRZd/aCcBHm8A36E54+3K09XYLC5puynLchBPKII1jy4Sjakqn68jvpeoPyNL+8yKDagb6pN13WslVB8oDNdUk+brzBy3x0TZodwphRMzQxsox7yDYloriNsoDrneFbngA164AyHGyOd/hGEoV954k884CRKHbWBn3RdCf1ZHb+wTMP3p5kwgnDKg+yvQhCZKr3yELZFZRmtfs8WwxJ0Da8Dc06hmKw==; 31:8LGhPGagCrF9JnGg4/2DLGCYoMRpgR36mdc5cbiIOZBWhI3qUBGjsKjQyEvF6M668V9VsR6bk7XG4it8G7w2h6vv901SFtCSAMjkyxVQDlFGcqFPhWPHgtJ675lc3z20qkDRfSpFSsDLa3Fu1CW8IVLqpCA7R136GAcc8Fm+dSvYJ3YzfkXmvylxS+mxF0aDqNhTHyGWJ6fWOWYFpQDB2Y5JrmJzuZr70ETrc9OyDnM= X-MS-TrafficTypeDiagnostic: DB5PR04MB1383: X-Microsoft-Exchange-Diagnostics: 1; DB5PR04MB1383; 20:lPqiye4K2SBxOPt5lcSaaqRrfdTYWBjwF52BmCCdMCCPqXsJ4CRfmivPJsbGdz3nYrxfaWxTc8Y1KPVZgxaPaKYYOij7aG7RpEzlvjQbXVf3WtPX0thgBC1I1JUlQip7oN3LX9AUrfy0BPUJ6HFRAhPMKilq+1xNEWPPNDYRKbMqyDVFODSiq/KAV9mSw5HcxRPmM9BqfIV8w9kfKcC2UEn0ZwIhZrTfUYNc7Jt4d4PUC64tUY9YSJ7rq1ff2Nj0sZpvjyMFZHl88g+t9IRo8VNPMZ6Qk4ECW6NyZRmunBPaEn/pK3TYpAib8Ro4L/pqx9EDkoaufKOXryEuqOtQ0LMg/a+Ytv0iuY78Lp5o4Jb6iCW7Sz+zDY8wXe4I5zNWYVz1KLxDbOU72g4O8UZb7vSfdGyjdMPoZBXpplMEneg1LVN2/hyxiNxd5VVSnPPHZmGX7J9xcKc82OeOUnXr0V5nzhChmWkR+ZInjYXZYOJwNLZHIuzHqETN4RlwBy2E; 4:UVQSXoyHPwBB67b9hl1WkYPdUzu16gS3G293F54jBrVWQKR0DzEtMfbhEe3OfFHW2+twHMoUw+WXNKFia7cKiJa0BJncbKzOWPfRp2mCbamnZu4M0iVhqoD8AcxyFgwI3GJmC4QbJvHMLGyq+Qx8s0eKjscswDgTY5bpZsWhnFuQdwnomjEw6DuZFaRPvU0D3AC+UPjApRnmvHcZkvH8LiR6Qq7r8jlFu5kM95NpviY/Gw2n8W9c7xjgUzfizCwj+7Z4rrjfa7w9g0IfKlU8Qril5c3kKMWATQjsPDhYgjxYfg6t7K2CmQGr3TDW+5l6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231232)(944501327)(52105095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:DB5PR04MB1383; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB1383; X-Forefront-PRVS: 0645BEB7AA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(39380400002)(346002)(366004)(396003)(189003)(199004)(23746002)(25786009)(36756003)(4326008)(105586002)(52396003)(3260700006)(76176011)(229853002)(68736007)(230700001)(6486002)(6116002)(446003)(5660300001)(11346002)(65826007)(7736002)(478600001)(386003)(50466002)(97736004)(186003)(53546011)(16526019)(52116002)(44832011)(31686004)(305945005)(2906002)(316002)(46003)(81166006)(8676002)(81156014)(31696002)(58126008)(6246003)(2616005)(106356001)(476003)(65956001)(64126003)(65806001)(1706002)(8936002)(86362001)(53936002)(486006)(6666003)(5890100001)(47776003)(67846002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1383; H:[IPv6:2402:3a80:9d2:4991:d854:84e3:2b1a:aa5f]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DB5PR04MB1383; 23:eaQwNatQi6FyS46yFOJQoGDJ6Fb1ygnXLf/ZS?= =?Windows-1252?Q?rSEr5P+rU9PkTJDPAGs+WUTGGZjaGs/b+wZgY/zBJs/TZWdXlGOYsd/g?= =?Windows-1252?Q?QModWkbMpeNNhWAfs7fqCgmZGbKmQh5yRk5jVibEv4vVTqqqPXKM3nW5?= =?Windows-1252?Q?hzqvwhJeGYNLWej6dakNsNlCMIwbt7SwsooEznegfWKrvbCNmROfUJs+?= =?Windows-1252?Q?EPNIuKbxJxjk2oOJroZ40kXfvrtetNlXVzTrOnGGjDGnzFKg82Bsmq2d?= =?Windows-1252?Q?aNJGOKk4k9Kg1LrZj06/jBEGJhJE0eXeKLAV/k2pEIjBvf4iWfOHn05b?= =?Windows-1252?Q?YtHMD3vMKva7YF3Uo0fyhc6r5wu/pI9VVC5+8L1ntKaDKnHHqnWJFGRF?= =?Windows-1252?Q?O7OmIyavYxg6hA2RqCbLZuEffBef2sfnSQTQRhGXVzhdguREOSCjdkpi?= =?Windows-1252?Q?1FPjXclEQ9ZvuzIW545fvk72KKDTr91ji5RUCPD17o+ewNZzz+4QeKcE?= =?Windows-1252?Q?DSKQ4CkV3npOJvuN9bKfYDWT5WTXDih9AFolqw6djyUNi/qqVJTnZX9/?= =?Windows-1252?Q?m4VxAjM4KCEDXTCP7mVCSGq71ZZapVXWA0wX8TKotpIYjqFH3qHNzFCX?= =?Windows-1252?Q?/pX8+fSuGJ5vgbfY3ynh25WHsaFjm7N3M0qLoaJFX+J/puSEigUpCgcV?= =?Windows-1252?Q?OVv+12CdpCn7zc09NexYZFsm38uiBT6r29tlV+J+EBPcg1A3TaaQ4ee2?= =?Windows-1252?Q?oOFSYdwwpE+sknrK/PTJ10m1s/amE43cP7y6s8dvAe3JlUaqd6hQsZdZ?= =?Windows-1252?Q?F/DXxIuDWtwIAIN914dOhuEBVZFBdoHxCBqWx+Jf9onEmKvhlw24PR7z?= =?Windows-1252?Q?vCJo1hgbmhrhHEqcjqOdrguBewXr10oidwUOA2KXo+a6tju0GVntXUcG?= =?Windows-1252?Q?+II6cCHA/y7Pcio0SG6rX9nPa9/i/GLk24arKBuoeMIgRg1Gf+V7yEQq?= =?Windows-1252?Q?ENjSvDdqjA6wzKDV+7OtBeawYfz9ARrQ1PN47aOtw1UHRaD1P2oypjPo?= =?Windows-1252?Q?SNQi5qANdfayIgfIWz+SZ110xmVCVNdIcTIJHWDuWKcPMgLv4KiVAAwz?= =?Windows-1252?Q?GKBOP7sKMNmIjI3cBFVGMz6eoFO3dMdAAMSwV53R9Glx3QbnQUxhymXJ?= =?Windows-1252?Q?q5a5Wo9L1RVDwyr6ukM7CSFb6v8UvzJFEYNidZ2gGzxNA6gIQchBVmAY?= =?Windows-1252?Q?joQVqUyjUOwf2hknI56BtKGfCeud71jAD57hn6eMnEjy/P+44riX2IJj?= =?Windows-1252?Q?fg18FgHGTPwiUluBwj8sfjeAOvu8M3QVqHJylomwIfN96pjB8FaezZit?= =?Windows-1252?Q?jPgXfLW6+KOMgIgfAbVg+NFFa0sYGsA7T/ibgpzKV/pzaVewYSykCXQd?= =?Windows-1252?Q?RLUIOg+XpyPBFbWepE7sV0wk3OeV0nPuIglYvQ7R9S1Azmdyw+6cGIHb?= =?Windows-1252?Q?SXd93o=3D?= X-Microsoft-Antispam-Message-Info: UKjJzlc5bhbKOJjN35twoSc8mcx76+2krKfseyww6TOE2TYAiIEFryd/FxPR1Pef4bLaeyT6rOEJ5cbiop1wc/mSQm+wtYgC7QDi0nLV54d7afnf2lCzxG6X1uBuBKNOa3j5Z1LuFvHUCwGhMTqz5HOdWNp71c5WdSQYEB8CVtxd/KVeBIOsgQGqsk+Rgcnj X-Microsoft-Exchange-Diagnostics: 1; DB5PR04MB1383; 6:rMFAi9/9hpwHpga2slWgqQMtBIEUXNj4EVjXmiioZxAbAoAH4nOKlkEjj5No/z8X1GFvBnmk3RjxnMNWfKWAgQ4duT8gMOQ1QpP8MSgJQhU3cHTQk39HayUqpMKTInT/iOANz62DmM6w7N09ZK9Y8gywNAthaqLQcmqtcozOAPpuhIQyUcbp7OsJDIoexT9fJb72dJhH+PVCoH2HrlP15ZFCryqs0E/3YHqlZ9nOUYtGXVuD7iKkxKcuF6Koq0btQJsA6z4OWpY+ny6D2PX9CRy306I1wEG3qZpZAMY0nLH7koSso0VtkrwsDG2hSXHMpx1roFhFANkr+Kc0KjBiDu6a+h0hM++JAPYZshoylMlsNCqqxKcilSwVcNsF87cLLidv2EOcDl7CmQPocNBsTgckC9tYQ8/inVXUjWeyYzJOvt5tOYiGSZjp0MLQaDycRb/aFTcyDYGrNWVcD/8l3A==; 5:q2g7fKojYRMc8UwOEuU9dX1Y4pcy41dMBcl21T39loDnvCNNBUwDrU02DHkpf7WQr6a78DoSriT9RpdHxzFd3ukOQ7gP2+H6cJtAltuI5k0BzjAKKCXHFpgjJWOjxL9Yjw3vQFYxaEEssz5Mu2pew3y4ZRS2DGZmf6okqpUjZBI=; 24:4WjMDvrH/AEF1SGY3SDoUkQtpxfEaO+JrhwxL9dzHnEgMnSPa1cHCkBfj125KcuUv2iDWpPIYKMkHN4ebLHhRJQTdky3m2osIfM1FGafPlQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB5PR04MB1383; 7:w8q94QUVe3n+JyIQTQ+Wja6/Mfg8mJErJsvvWZxYlqU0c3mhMKjL1rrRtnmFQM46/VHs5/kW2WT7kpq6V7ck8a/XdGAn/gp5j3IufJblDRZQ1p2oh08Iu3YuzCtgjl/WCiSesjX7RGB5awHXTbJt8qgQKstrJcotKHw4zR5jwO/1FX/tGpOp4zZm+LJ+K0qfYEQMBOixGcaJ0YNnVfRzkslCViQVLKcYTFiFP3/9ZTE4aEqrlnYZ5LOWZdonY7yd X-MS-Office365-Filtering-Correlation-Id: dfbbb22e-ebb5-460c-dfb6-08d5a46e2535 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2018 14:18:49.5906 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfbbb22e-ebb5-460c-dfb6-08d5a46e2535 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1383 Subject: Re: [dpdk-dev] [dpdk-dev, v1, 2/5] eventdev: add crypto adapter implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 14:18:54 -0000 Hi Abhinandan, I have not reviewed the patch completely. But I have below query for further review. On 4/4/2018 12:26 PM, Abhinandan Gujjar wrote: > Signed-off-by: Abhinandan Gujjar > Signed-off-by: Nikhil Rao > Signed-off-by: Gage Eads > --- [..snip..] > + > +int __rte_experimental > +rte_event_crypto_adapter_queue_pair_add(uint8_t id, > + uint8_t cdev_id, > + int32_t queue_pair_id) > +{ > + struct rte_event_crypto_adapter *adapter; > + struct rte_eventdev *dev; > + struct crypto_device_info *dev_info; > + uint32_t cap; > + int ret; > + > + RTE_EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); > + > + if (!rte_cryptodev_pmd_is_valid_dev(cdev_id)) { > + RTE_EDEV_LOG_ERR("Invalid dev_id=%" PRIu8, cdev_id); > + return -EINVAL; > + } > + > + adapter = eca_id_to_adapter(id); > + if (adapter == NULL) > + return -EINVAL; > + > + dev = &rte_eventdevs[adapter->eventdev_id]; > + ret = rte_event_crypto_adapter_caps_get(adapter->eventdev_id, > + cdev_id, > + &cap); > + if (ret) { > + RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %" PRIu8 > + "cdev %" PRIu8, id, cdev_id); > + return ret; > + } > + > + dev_info = &adapter->cdevs[cdev_id]; > + > + if (queue_pair_id != -1 && > + (uint16_t)queue_pair_id >= dev_info->dev->data->nb_queue_pairs) { > + RTE_EDEV_LOG_ERR("Invalid queue_pair_id %" PRIu16, > + (uint16_t)queue_pair_id); > + return -EINVAL; > + } > + > + if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT) { > + RTE_FUNC_PTR_OR_ERR_RET( > + *dev->dev_ops->crypto_adapter_queue_pair_add, > + -ENOTSUP); > + if (dev_info->qpairs == NULL) { > + dev_info->qpairs = > + rte_zmalloc_socket(adapter->mem_name, > + dev_info->dev->data->nb_queue_pairs * > + sizeof(struct crypto_queue_pair_info), > + 0, adapter->socket_id); > + if (dev_info->qpairs == NULL) > + return -ENOMEM; > + } > + > + ret = (*dev->dev_ops->crypto_adapter_queue_pair_add)(dev, > + dev_info->dev, > + queue_pair_id); crypto_adapter_queue_pair_add is supposed to attach a queue (queue_pair_id) of cryptodev(dev_info->dev) to event device (dev). But how will the underlying implementation attach it to event device without knowing the eventdev queue_id. This information was coming in the RFC patches with the parameter (rte_event_crypto_queue_pair_conf). Why is this removed and if removed how will the driver attach the queue. I can see that rte_event is passed in the session private data but how can we attach the crypto queue with event dev queue? Regards, Akhil