From: "Kinsella, Ray" <mdr@ashroe.eu>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, bruce.richardson@intel.com,
Neil Horman <nhorman@tuxdriver.com>,
Rosen Xu <rosen.xu@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH] build: fix version map file references in documentation
Date: Thu, 22 Oct 2020 08:52:37 +0100 [thread overview]
Message-ID: <5ea9876c-6d1b-2817-2f98-4069ca74723d@ashroe.eu> (raw)
In-Reply-To: <20201022074704.16111-1-david.marchand@redhat.com>
On 22/10/2020 08:47, David Marchand wrote:
> Fixes: 63b3907833d8 ("build: remove library name from version map file name")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Note: we might want to update the ABI version in the examples shown in
> the documentation. I can send a followup patch.
I was thinking similar, I can do it also.
> ---
> doc/guides/contributing/abi_versioning.rst | 14 +++++++-------
> lib/librte_eal/include/rte_function_versioning.h | 2 +-
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst
> index 7a771dba10..b8b35761e2 100644
> --- a/doc/guides/contributing/abi_versioning.rst
> +++ b/doc/guides/contributing/abi_versioning.rst
> @@ -58,12 +58,12 @@ persists over multiple releases.
>
> .. code-block:: none
>
> - $ head ./lib/librte_acl/rte_acl_version.map
> + $ head ./lib/librte_acl/version.map
> DPDK_20 {
> global:
> ...
>
> - $ head ./lib/librte_eal/rte_eal_version.map
> + $ head ./lib/librte_eal/version.map
> DPDK_20 {
> global:
> ...
> @@ -77,7 +77,7 @@ that library.
>
> .. code-block:: none
>
> - $ head ./lib/librte_acl/rte_acl_version.map
> + $ head ./lib/librte_acl/version.map
> DPDK_20 {
> global:
> ...
> @@ -88,7 +88,7 @@ that library.
> } DPDK_20;
> ...
>
> - $ head ./lib/librte_eal/rte_eal_version.map
> + $ head ./lib/librte_eal/version.map
> DPDK_20 {
> global:
> ...
> @@ -100,12 +100,12 @@ how this may be done.
>
> .. code-block:: none
>
> - $ head ./lib/librte_acl/rte_acl_version.map
> + $ head ./lib/librte_acl/version.map
> DPDK_21 {
> global:
> ...
>
> - $ head ./lib/librte_eal/rte_eal_version.map
> + $ head ./lib/librte_eal/version.map
> DPDK_21 {
> global:
> ...
> @@ -134,7 +134,7 @@ linked to the DPDK.
>
> To support backward compatibility the ``rte_function_versioning.h``
> header file provides macros to use when updating exported functions. These
> -macros are used in conjunction with the ``rte_<library>_version.map`` file for
> +macros are used in conjunction with the ``version.map`` file for
> a given library to allow multiple versions of a symbol to exist in a shared
> library so that older binaries need not be immediately recompiled.
>
> diff --git a/lib/librte_eal/include/rte_function_versioning.h b/lib/librte_eal/include/rte_function_versioning.h
> index f588f2643b..746a1e1992 100644
> --- a/lib/librte_eal/include/rte_function_versioning.h
> +++ b/lib/librte_eal/include/rte_function_versioning.h
> @@ -22,7 +22,7 @@
> * allow for backwards compatibility for a time with older binaries that are
> * dynamically linked to the dpdk. To support that, the __vsym and
> * VERSION_SYMBOL macros are created. They, in conjunction with the
> - * <library>_version.map file for a given library allow for multiple versions of
> + * version.map file for a given library allow for multiple versions of
> * a symbol to exist in a shared library so that older binaries need not be
> * immediately recompiled.
> *
>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
next prev parent reply other threads:[~2020-10-22 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 7:47 David Marchand
2020-10-22 7:52 ` Kinsella, Ray [this message]
2020-10-22 8:19 ` Bruce Richardson
2020-10-22 12:11 ` David Marchand
2020-10-22 14:24 ` Kinsella, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea9876c-6d1b-2817-2f98-4069ca74723d@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=rosen.xu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).