From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 412ADA0546;
	Wed,  7 Apr 2021 10:15:47 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CB99F14106C;
	Wed,  7 Apr 2021 10:15:46 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by mails.dpdk.org (Postfix) with ESMTP id 8FC39407FF
 for <dev@dpdk.org>; Wed,  7 Apr 2021 10:15:45 +0200 (CEST)
IronPort-SDR: SBx1TKSovUZd8X9g50wHltdZHhHLorciCCfSBsFUf2rQx1EtMkTIZb9bgQh4SR+ssSsFQ9fiV7
 yIbOSqONBm6Q==
X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="191091260"
X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="191091260"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Apr 2021 01:15:44 -0700
IronPort-SDR: fZ61+GIFUHLAr96IsEM6NdoIiAaOF3zGYeroexYPiETXgjX3bTjQs5GhuRWRSoeH6T88h6veg9
 5RZtgunJGzXA==
X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="379735929"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.202.196])
 ([10.213.202.196])
 by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 07 Apr 2021 01:15:42 -0700
To: =?UTF-8?Q?Micha=c5=82_Krawczyk?= <mk@semihalf.com>,
 David Harton <dharton@cisco.com>
Cc: Marcin Wojtas <mw@semihalf.com>, "Tzalik, Guy" <gtzalik@amazon.com>,
 "Schmeilin, Evgeny" <evgenys@amazon.com>, "Chauskin, Igor"
 <igorch@amazon.com>, dev <dev@dpdk.org>
References: <20210406002719.2556501-1-dharton@cisco.com>
 <CAJMMOfPKEQKJCUB6ZTpXciw2coUM9U+YEoMW-2DNz=U_sNuS_g@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <5eb92c99-7564-b3f5-bc4b-8b35657b6d74@intel.com>
Date: Wed, 7 Apr 2021 09:15:38 +0100
MIME-Version: 1.0
In-Reply-To: <CAJMMOfPKEQKJCUB6ZTpXciw2coUM9U+YEoMW-2DNz=U_sNuS_g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/ena: fix releasing Tx ring mbufs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/6/2021 6:25 AM, Michał Krawczyk wrote:
> wt., 6 kwi 2021 o 02:27 David Harton <dharton@cisco.com> napisał(a):
>>
>> When ena_tx_queue_release_bufs() frees the mbufs it does not clear
>> the mbuf pointers.  So, when the device starts and stops multiple
>> times it can cause the application to receive duplicate mbufs for
>> two different packets.  Fix the issue by clearing the mbuf pointer.
>>
>> Also, while tracking down the "double free" issue the ena calls to
>> allocate and free mbufs in bulk were migrated to the mbuf based APIs
>> so the common mbuf alloc/free routines are exercised.
>>
>> Fixes: 79405ee17585 ("net/ena: fix out of order completion")
>> Fixes: 1173fca25af9 ("ena: add polling-mode driver")
>>
>> Signed-off-by: David Harton <dharton@cisco.com>
> Acked-by: Michal Krawczyk <mk@semihalf.com>

Applied to dpdk-next-net/main, thanks.