From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DBC341BEB; Mon, 6 Feb 2023 12:32:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E23F140FAE; Mon, 6 Feb 2023 12:32:25 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 6DC7540A7A for ; Mon, 6 Feb 2023 12:32:24 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P9PFr729FzJsCv; Mon, 6 Feb 2023 19:30:40 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 6 Feb 2023 19:32:20 +0800 Subject: Re: [PATCH v8 5/5] eal: add lcore usage telemetry endpoint To: Robin Jarry , CC: Kevin Laatz References: <20221123102612.1688865-1-rjarry@redhat.com> <20230202134329.539625-1-rjarry@redhat.com> <20230202134329.539625-6-rjarry@redhat.com> From: fengchengwen Message-ID: <5ebac9a3-3e0c-0c9c-2a0e-c417d6b04e6b@huawei.com> Date: Mon, 6 Feb 2023 19:32:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/2/6 16:24, Robin Jarry wrote: > fengchengwen, Feb 06, 2023 at 04:27: >> The telemetry should be human-readable also. >> >> so why not "/eal/lcore/usage": { >>     "lcore_4" : { >>         "total_cycles" : xxx >>         "busy_cycles" : xxx >>         "busy/total ratio" : "xx%" >>     }, >>     "lcore_5" : { >>         "total_cycles" : yyy >>         "busy_cycles" : yyy >>         "busy/total ratio" : "yy%" >>     }, >> } > > The raw data is exposed and can be rendered any way you like. This should be left to external monitoring tools, such as grafana & al. It's a small step in programming, but it's more user friendly. Once done, user who use telemetry could be benefiting. And it's also be render by monitoring tools because there's no data loss. > > > .