From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 891BFA0545; Fri, 27 May 2022 18:04:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B5CE410DC; Fri, 27 May 2022 18:04:59 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id DF2CA40E78 for <dev@dpdk.org>; Fri, 27 May 2022 18:04:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653667497; x=1685203497; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=RPi9/gtDALMTfb3Ryt4Fm6p9PCjARF8vZJs4bfcaemg=; b=jrY8E/sotY1h3mbJCWKj4AvOdpjl372Drnu/K6ZzSG2UZrnGudreY+fM 06AksV16Bxxnw2hMhgs1MradHad3Q2KJaYU42QCJesot7Nryl5TVavYEa VLZj03Cp036vI4wezxwt3AgHMomuOR6rY4D1kpdUOln19znutVcPjzIV1 6MagSDgf/4RvKxCwKizMyoKNa3LmWxSfP2DSG4d4AI16ShFawuptaChiH 43DCiT0xe3GdF6H3kghBSswGmPYNhwsSWX1qd0AIAZ9WTJpxiXruFSgFP Ki6iYsGAMOT5IJPQlJ8SsIOBA8BW6YqVmq8IAAUoH1AQnf7aL4xV5ot1S A==; X-IronPort-AV: E=McAfee;i="6400,9594,10360"; a="299859715" X-IronPort-AV: E=Sophos;i="5.91,256,1647327600"; d="scan'208";a="299859715" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2022 09:04:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,256,1647327600"; d="scan'208";a="603965135" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 27 May 2022 09:04:28 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 27 May 2022 09:04:28 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 27 May 2022 09:04:27 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 27 May 2022 09:04:27 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 27 May 2022 09:04:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkMdROXrmXO0GFNMiesBVbx2E03OXqi9e/DSjoNWEw/etVy9EWLalegObDSoBr1VY6v3J6cI5a9vDe6peWJbwmD53Lzz+BikUxnCJX9Gl1PJiZe08nN7BMz1WXc/jIt756YIVJnCRQhX1fu6bJ7RKOVNL6u1LH+0FK25qjcukgxyJUgTGTMuEyMdOhhli7BdoYUu291j0yickSfK4Rs/6cmjEX3c87PW3cHdYnG7sh+zbc2bVz9pPQgRznewEfQdM0qBtLVwyLfmWA8Kt3gVaNzfDILdTybcNqLXdug+4vvGquexU1U44jjb/kQ6xjDV7vADsXw8PXBIlhBFBrHMOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2axL6wyojd2GI8yykhwSTavFck2tOUlAZ+qoeyOeQUY=; b=PUvUxyaiiwxO4caqjy8BY1+KGw0wWKOpIyzp+byNLVrteHDxCL3GF9Z6hV/YTXgU4C9v68D2TqUhKvvprAEPWEQfLWdHgtRwS2A3DIMIbIpRQ8BaXm7reNQo4fTPW5uiFBG0Qz2nqQ1v2T2N3KFJoXaQsTIpdTyrBL8e+ksH7z2K59L3NRLf2o1CwjogzVQ+wW5C61wGblABcRztzBFx/tOfIJ5t7BpWsFtdkN8rSDsZuioxJmRGy20UgtcMP847fDgDlt1mrI+KFEGrUQDPOBw3BeRsHX4SQA9WYZZHYvTRK5taEp1U3iEwNHVTnbRFRfQSbTdBpS+eMQjH9xctDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BN6PR11MB1251.namprd11.prod.outlook.com (2603:10b6:404:48::10) by BN6PR11MB4097.namprd11.prod.outlook.com (2603:10b6:405:7e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 16:04:25 +0000 Received: from BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::5877:3176:59f4:11]) by BN6PR11MB1251.namprd11.prod.outlook.com ([fe80::5877:3176:59f4:11%11]) with mapi id 15.20.5293.013; Fri, 27 May 2022 16:04:25 +0000 Message-ID: <5ed1034f-9470-7a07-036a-4cdf9e47657d@intel.com> Date: Fri, 27 May 2022 17:04:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH v4 0/4] Add APIs for configurable power options Content-Language: en-US To: Kevin Laatz <kevin.laatz@intel.com>, <dev@dpdk.org> References: <20220408140847.1319312-1-kevin.laatz@intel.com> <20220524131407.423609-1-kevin.laatz@intel.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> In-Reply-To: <20220524131407.423609-1-kevin.laatz@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0093.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::8) To BN6PR11MB1251.namprd11.prod.outlook.com (2603:10b6:404:48::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ab0ec26-732f-46f6-7bda-08da3ffa91dc X-MS-TrafficTypeDiagnostic: BN6PR11MB4097:EE_ X-Microsoft-Antispam-PRVS: <BN6PR11MB4097CE853E233ADF14F8CF81F7D89@BN6PR11MB4097.namprd11.prod.outlook.com> X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C3xKSO17tXr5vYOMXJK8JFpe9MrMzy/2219nwEABAJgVp/9eWZLrrtHwuadpr8BZPf1Io3+OpGnagal2XlkoTjRQiuP25t6iZVLNYnJSLqlIWmw33vm+CKtvGCK3EK3vbZeKFbQ2l9idL/htNFuBHq38S/B6esNO2lgzuwFRyOKxaVLCfekLo0+/t7OBUrZPIYWGzVmdwnWgiaar5Rf0RLutoXlcooqlLXmKdcGWdtTSt9xdtkmwD9OG1L723/FNLzBaw5O86dh7ZodezgdbvOrbHxGRxTTi3tnAe+ZY5eeK8SlvIgKWSfLVnb/gwZQT9mIb+Q7gJXLpOeikeZvrJL/d3dcc/3IYGCgB7dRSV/bLHPdAXsNXYgT8zAyb2hQIfoRaVMPi/ZrQSHQ8UWBLRplsMW4Xgn7E6APon4pvNxWWsDfxBBpaQtjS8XihGoEVNQRUA4PWciv+wG/ZY9uLSH7uKNLCj86SV9dRGS3MJ3G1Xpew9867o2QPBiTdOwAkCM3kNGBZV0dDG4FUMoOYne3RuKgueqHrhsTcp4eUtRVXM2dJv/0hUaQYj5fc8rRbxEe5LoZKwJiYLn+eob0hHsuLiMqNz2VMcoscXAHCpM0rkdnUh7/2lgv0yJlul4lv0DKo0dpLlSQrrm6JV4ySSv8gD+1LhMsaQTNdY5ksfMuGCL1lS1qmZK+QgVrpaqkzGQBMoPZm806dKOBBD2DPvAXMwqfIjpSXBozFISI6CiA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1251.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(5660300002)(66556008)(66476007)(66946007)(26005)(6512007)(86362001)(2906002)(2616005)(31696002)(82960400001)(508600001)(6506007)(6486002)(6666004)(53546011)(8936002)(186003)(38100700002)(36756003)(83380400001)(31686004)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWNqZTlrT2F6djNVUXhwMmlFY1ZrYzBVOWVqTFpaL3lhL0UwWkVxSEM2Uk9F?= =?utf-8?B?Z2N1SVJGUGMvL0NuaE5iQXNNU2RoOU44ZE1ZOVBjQTA4OU5qWjQ5bXpqS056?= =?utf-8?B?VnhaMnBXc3VjMllZWUZWU2R6Uk94b3dueVJOeUpxYmtHZHgxN3ZKL3JIREsr?= =?utf-8?B?emMvc2VTRGhQVWhFZWdCcmx4YkY1OUMzRDk1WWVFRjFBcEozcitCekJCZkhy?= =?utf-8?B?UGlIaWYyS2tQMlRLU0pUazg3M1RCYVlRNkk2eTNYYnVCbFdEWDRDejdGbnNW?= =?utf-8?B?cmZXMmUzQW5WVGRyaTJhNlFlSW1mQWpzKzl2WnE4Q3JvMWlrWFRNbFFlQVZV?= =?utf-8?B?a3hRcHlTVHh5S3dlQUVBZUlzQmNMMzRQM1M4R0tSalBwZXBFQVVpazFZQldM?= =?utf-8?B?M0ZPNWl5WHNPSER5cHhjVG9tbXhWT1JJcUgxZ29xajRheThrQjJSVW5sMnJR?= =?utf-8?B?N25weG1PckJTeUMwMTBlUXZPV0dXeEZxZFB1SWhYZzBUM0lMKzFsNXZDK0d1?= =?utf-8?B?dlFTVldvTk0xcXlwaTlNczMwY2NCRXdyZm9qdlBvY0gxaUZVaEtkaVdodCtP?= =?utf-8?B?QkhVWk85MDBtY0VNa3l1RHYwMS9TYmhhS1E0eUNmS2QxOTJ3aWI1VFgveUZ3?= =?utf-8?B?aGtmVEZtS3RTVzdWRVMvWWJDTzdtMjRTbWxKMjcyc1pQZUZta1hBRFRvbFl2?= =?utf-8?B?TG81TjVxMml4d2FzUk1YamMwSUJJN1pFYjdtQ0VpckhPdVdJWFAybTVnd2pz?= =?utf-8?B?TEY0TlJlNW1TZ3FZSXZtYjVSUnBOTitVVXViODZJZFI4RmY5cEY4WndRT0d2?= =?utf-8?B?NnJIWU5GRkRndXVQd01rRnkvdTR3VUNoVnRPa0p3ajNwNHpacmJTSUdoTHc0?= =?utf-8?B?ZHZjK0JVc0QxekUwL1I3MWNRalRXK1JEZVFEM24yYjlOemp0djlkVnBBSHhE?= =?utf-8?B?T1FJYU5COWRjVlpUWDFLYkVGSHNaT2JmWW8yY2V6cTN6ZjdIKzI4RlQzcFJp?= =?utf-8?B?VzNDQko3clIrenozZnkyN0pmTHRFUmpJOVkzd2p4VWNIWVUxMHJUMkRyTHlu?= =?utf-8?B?aEp3azlLNWRrcWZMdk1rUXNSZVZoMDV3Q1ZnUnoremVjRkFKalJmWUNwR1lI?= =?utf-8?B?Y3ZQbjJXZStXTmRFaUVEQkd0M3MraC9OL2NDTjFYRXlSanQ4KzgvRkRDM2k4?= =?utf-8?B?RktENFVMYmJMMFFrSFNLanZyRVZ6VnVBMGx0UkdsdnVWVlFhUE9lVDJoQmhG?= =?utf-8?B?SStJQ2N6N0dVUHowMlA1MUU1UlczRlFCR2Q3R2YwNU9waXBEQk1EajlRVVU3?= =?utf-8?B?OFU2enRPK2wyN25sSklodjZWdnNRaHpqczVFaEFCT05XdSsyak1STzRncjJs?= =?utf-8?B?QnJ0dEkwWG9CZVZ4U1BMNWJpL2FyQ205QkVPWnhZT05RcEU4UkczSGhIWXAx?= =?utf-8?B?OEtwOEEzM1loRUY2U2tvSDAwcXVqaFNPYjJFbDhZTk5ZY2R1cTlTY2ZFK3Ny?= =?utf-8?B?VlVTZE53NGoyZjg4LzdFdEdRUVF2UXRLU1RkS3RNazRTcG1BdlFCZG9jRjkr?= =?utf-8?B?V2N3RTlCUE1iOXlPTmkrb3JBNUlybTIxMDc1eWIwYVhiR283eUdEZ3U4S09V?= =?utf-8?B?WEx4bENDdU5zck1XcE9qUWNVb0wxc0tiZW04ZXF1dVRTMDlUY2RJbU5CYkRl?= =?utf-8?B?MlZjWGtPdGRaVGxEbEJMZExPRm92UXVGK3NzakhDTitsZGtydzg4eS9TVmNO?= =?utf-8?B?aldLM080R0xvWGxIc3R4dG4vVUdmbDU4Y2g2elFMbWdoeDlEZGxoazVtejQ4?= =?utf-8?B?bWovV2dFYnh0RWE1TW94QldQVXc3anRtNEY1VnZvNFY2SkJxYndTcmppMEdo?= =?utf-8?B?cWtGbFAxOEREd1IxKzZhMkNoRE10VDhiZVlkc01jcjlaeWhodmxYNWxqYWZF?= =?utf-8?B?cnllQzkvRU1WRXhYVEVVM242UThuWW5xdDBtRmNlTWlNNFpNMWdDTHZoSU1P?= =?utf-8?B?SDBOTkwrcFR4dkt6WUttT2wyVnFtdVZoU0FtME5KRHkvRnEzQ21BSHhrL2hk?= =?utf-8?B?aENxRjBGa2p6L3FnSE8wRWRER3d6ZTk3TEFjQ0R5UGVGV3ZqUE5EakVYU0t0?= =?utf-8?B?NW1UcmNOaFIyZll5Z21KN1psTmVDcURlZWZuQ2ZteWRaVEpWK1VXWVhEaUQ5?= =?utf-8?B?RHkyblVkV2FybFN2R2NmeGVNSVYwbXlwcVdKa2F6VU8rR1EvZVdyaFJ3MEtT?= =?utf-8?B?ZlNleXlTcUNCc21TM3FWZDNqZW5ySjNzYzUwWEErYWpFNkxOWm1wYTN2UUxT?= =?utf-8?B?QlNUZ3lSTVB2a0VPN0ZvVmNCa0Rzb250azJXSEtoOTl4QkRGVmVrNmVRYUV5?= =?utf-8?Q?5i6CRKDZTYPgQ+uQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2ab0ec26-732f-46f6-7bda-08da3ffa91dc X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1251.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 16:04:25.0366 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bwhIHaWivhj8MP72FEFiq6y3a0PgwvyjoNlNTUgpfi/NvSzX/HY1BZwft83AA/dn8C3lQ5t83uP5O3bOD6Ev8cgFPSAnQNd3z8WGZQ0P4JQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4097 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 24-May-22 2:14 PM, Kevin Laatz wrote: > The power library contains some variables which are currently set by > defines, hard-coded values or set using sysfs values. In order to > configure these, code changes and recompiles are required, making > configuring these variables tedious. > > This patchset introduces some new get/set APIs which allow users and > applications to configure there settings to suit their use-cases. > In addition, CLI options have been added to l3fwd_power to demonstrate > how an application could use these APIs to expose the options to users > without needing code changes to configure them. > > --- > v4: > * fix return value when scaling_freq_max is not set > * fix mismatching comments > > v3: > * move setters from arg parse function to init > * consider 0 as 'not set' for scaling_freq_max > * other minor fixes > > v2: > * add doc update for l3fwd-power > * order version.map additions alphabetically > > Kevin Laatz (4): > lib/power: add get and set API for emptypoll max > lib/power: add get and set API for pause duration > lib/power: add get and set API for scaling freq min and max with > pstate mode > examples/l3fwd_power: add cli for configurable options > > .../sample_app_ug/l3_forward_power_man.rst | 8 + > examples/l3fwd-power/main.c | 86 ++++++++++- > lib/power/power_pstate_cpufreq.c | 24 ++- > lib/power/rte_power_pmd_mgmt.c | 123 +++++++++++++++- > lib/power/rte_power_pmd_mgmt.h | 139 ++++++++++++++++++ > lib/power/version.map | 10 ++ > 6 files changed, 379 insertions(+), 11 deletions(-) > Hi Kevin, We also have documentation for this library under `doc/guides/prog_guide/power_man.rst`, which documents methods exposed by the PMD power management. That document needs to be updated with the new additions :) -- Thanks, Anatoly