* [dpdk-dev] [PATCH] net/nfp: avoid unplug if multiport
@ 2017-10-31 11:04 Alejandro Lucero
2017-10-31 17:23 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Alejandro Lucero @ 2017-10-31 11:04 UTC (permalink / raw)
To: dev; +Cc: gaetan.rivet
PF multiport support has some limitations like not allowing plugging or
unplugging of single ports as they all belong to same PCI device.
A previous patch for removing detachable flag introduced a wrong check.
Fixes: 00a3d8104ac5 ("ethdev: remove detachable device flag")
Cc: gaetan.rivet@6wind.com
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 8c1c1f0..05f26bc 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -3029,7 +3029,7 @@ static int eth_nfp_pci_remove(struct rte_pci_device *pci_dev)
hw = NFP_NET_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
}
/* hotplug is not possible with multiport PF */
- if (!hw->pf_multiport_enabled)
+ if (hw->pf_multiport_enabled)
return -ENOTSUP;
return rte_eth_dev_pci_generic_remove(pci_dev, NULL);
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/nfp: avoid unplug if multiport
2017-10-31 11:04 [dpdk-dev] [PATCH] net/nfp: avoid unplug if multiport Alejandro Lucero
@ 2017-10-31 17:23 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-10-31 17:23 UTC (permalink / raw)
To: Alejandro Lucero, dev; +Cc: gaetan.rivet
On 10/31/2017 4:04 AM, Alejandro Lucero wrote:
> PF multiport support has some limitations like not allowing plugging or
> unplugging of single ports as they all belong to same PCI device.
>
> A previous patch for removing detachable flag introduced a wrong check.
>
> Fixes: 00a3d8104ac5 ("ethdev: remove detachable device flag")
> Cc: gaetan.rivet@6wind.com
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-31 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 11:04 [dpdk-dev] [PATCH] net/nfp: avoid unplug if multiport Alejandro Lucero
2017-10-31 17:23 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).