From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CE8C2201 for ; Mon, 1 Oct 2018 09:51:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 00:51:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,327,1534834800"; d="scan'208";a="84750041" Received: from pmurugan-mobl1.ger.corp.intel.com (HELO [10.252.22.216]) ([10.252.22.216]) by FMSMGA003.fm.intel.com with ESMTP; 01 Oct 2018 00:51:17 -0700 To: Jeff Guo , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1534503091-31910-5-git-send-email-jia.guo@intel.com> <89a8c22b-b96a-4b93-f457-2d5a2db01b87@intel.com> From: "Burakov, Anatoly" Message-ID: <5f51ed2c-a938-a006-74e2-d0673039f69a@intel.com> Date: Mon, 1 Oct 2018 08:51:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <89a8c22b-b96a-4b93-f457-2d5a2db01b87@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 4/5] pci: add req handler field to generic pci device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 07:51:57 -0000 On 29-Sep-18 7:15 AM, Jeff Guo wrote: > > On 9/26/2018 8:22 PM, Burakov, Anatoly wrote: >> On 17-Aug-18 11:51 AM, Jeff Guo wrote: >>> There are some extended interrupt types in vfio pci device except >>> from the >>> existing interrupts, such as err and req notifier, it could be useful >>> for >>> device error monitoring. And these corresponding interrupt handler is >>> different from the other interrupt handler that register in PMDs, so >>> a new >>> interrupt handler should be added. This patch will add specific req >>> handler >>> in generic pci device. >>> >>> Signed-off-by: Jeff Guo >>> --- >>>   drivers/bus/pci/rte_bus_pci.h | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/bus/pci/rte_bus_pci.h >>> b/drivers/bus/pci/rte_bus_pci.h >>> index 0d1955f..c45a820 100644 >>> --- a/drivers/bus/pci/rte_bus_pci.h >>> +++ b/drivers/bus/pci/rte_bus_pci.h >>> @@ -66,6 +66,7 @@ struct rte_pci_device { >>>       uint16_t max_vfs;                   /**< sriov enable if not >>> zero */ >>>       enum rte_kernel_driver kdrv;        /**< Kernel driver >>> passthrough */ >>>       char name[PCI_PRI_STR_SIZE+1];      /**< PCI location (ASCII) */ >>> +    struct rte_intr_handle req_notifier_handler;/**< Req notifier >>> handle */ >>>   }; >>>     /** >>> >> >> Does this break ABI? >> > > If add a variable in struct would break ABI, it does. > > Then it probably does. So, should probably bump PCI driver ABI version? -- Thanks, Anatoly