From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4FC823B5 for ; Tue, 21 Mar 2017 14:02:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490101322; x=1521637322; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=s5JQOX3EJoeku+ASo6WxjxQVH0ZojoP7xuAUvND/E48=; b=RdfdAIItcUVeCa2+IFqx4Z8koVrv0FlQbJZ50iM5QHFY6woFDyvLHlqy PYO+y1DVQZD0q6pJ0/56PRgEHi2lxg==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2017 06:02:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="837008974" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 21 Mar 2017 06:01:58 -0700 To: Shijith Thotton References: <1487669225-30091-1-git-send-email-shijith.thotton@caviumnetworks.com> <1488454371-3342-1-git-send-email-shijith.thotton@caviumnetworks.com> <1488454371-3342-37-git-send-email-shijith.thotton@caviumnetworks.com> <9a8d31ce-8590-25f3-eab8-6a34e4a645a2@intel.com> <20170321125321.GA13113@localhost.localdomain> Cc: dev@dpdk.org, Jerin Jacob , Derek Chickles , Venkat Koppula , Srisivasubramanian S , Mallesham Jatharakonda From: Ferruh Yigit Message-ID: <5f7890d7-4714-9ceb-50b2-b548903fee9d@intel.com> Date: Tue, 21 Mar 2017 13:01:58 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170321125321.GA13113@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 36/46] net/liquidio: add API to set MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 13:02:02 -0000 On 3/21/2017 12:53 PM, Shijith Thotton wrote: > On Tue, Mar 21, 2017 at 12:24:49PM +0000, Ferruh Yigit wrote: >> On 3/2/2017 11:32 AM, Shijith Thotton wrote: >>> Signed-off-by: Shijith Thotton >>> Signed-off-by: Jerin Jacob >>> Signed-off-by: Derek Chickles >>> Signed-off-by: Venkat Koppula >>> Signed-off-by: Srisivasubramanian S >>> Signed-off-by: Mallesham Jatharakonda >> >> <...> >> >>> >>> static int >>> +lio_dev_change_vf_mtu(struct rte_eth_dev *eth_dev, uint16_t new_mtu) >>> +{ >>> + struct lio_device *lio_dev = LIO_DEV(eth_dev); >>> + >>> + PMD_INIT_FUNC_TRACE(); >>> + >>> + if (!lio_dev->intf_open) { >>> + lio_dev_err(lio_dev, "Port %d down, can't change MTU\n", >>> + lio_dev->port_id); >>> + return -EINVAL; >>> + } >>> + >>> + /* Limit the MTU to make sure the ethernet packets are between >>> + * ETHER_MIN_MTU bytes and PF's MTU >>> + */ >>> + if ((new_mtu < ETHER_MIN_MTU) || >>> + (new_mtu > lio_dev->linfo.link.s.mtu)) { >>> + lio_dev_err(lio_dev, "Invalid MTU: %d\n", new_mtu); >>> + lio_dev_err(lio_dev, "Valid range %d and %d\n", >>> + ETHER_MIN_MTU, lio_dev->linfo.link.s.mtu); >>> + return -EINVAL; >>> + } >>> + >>> + return 0; >>> +} >> >> Is this really sets the MTU? >> "new_mtu" seems not used, except limit check, an lio_send_ctrl_pkt() >> required perhaps? > > It won't set MTU for hardware and is possible only by PF. So > lio_send_ctrl_pkt is not required. VF MTU is limited by PF MTU and is > mentioned under limitations in driver documentation. Here we are > allowing upper layer to set MTU up to the value configured by PF. I see, but lio_dev_change_vf_mtu() does not set anything at all. If it is not modifying anything at all, why you claim "MTU update" supported? And following logic seems wrong for this case: ... if (lio_dev->linfo.link.s.mtu != mtu) { ret = lio_dev_change_vf_mtu(eth_dev, mtu); ... Should this functions set lio_dev->linfo.link.s.mtu at least, perhaps? > > Shijith >