From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93BE8A0548; Fri, 9 Jul 2021 16:42:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B1E8416AD; Fri, 9 Jul 2021 16:42:31 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E49B64014D for ; Fri, 9 Jul 2021 16:42:29 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="295349670" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="295349670" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 07:42:24 -0700 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="499206341" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.241.5]) ([10.213.241.5]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2021 07:42:23 -0700 To: David Marchand , Thomas Monjalon , Andrew Rybchenko , "Yigit, Ferruh" Cc: dev , David Hunt , Ciara Loftus , "Ananyev, Konstantin" References: From: "Burakov, Anatoly" Message-ID: <5f985052-10ff-97fe-e20e-e3f146f7f46a@intel.com> Date: Fri, 9 Jul 2021 15:42:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 5/7] power: support callbacks for multiple Rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09-Jul-21 3:24 PM, David Marchand wrote: > On Thu, Jul 8, 2021 at 4:14 PM Anatoly Burakov > wrote: >> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst >> index 403c2b03a3..a96e12d155 100644 >> --- a/doc/guides/nics/features.rst >> +++ b/doc/guides/nics/features.rst >> @@ -912,6 +912,16 @@ Supports to get Rx/Tx packet burst mode information. >> * **[implements] eth_dev_ops**: ``rx_burst_mode_get``, ``tx_burst_mode_get``. >> * **[related] API**: ``rte_eth_rx_burst_mode_get()``, ``rte_eth_tx_burst_mode_get()``. >> >> +.. _nic_features_get_monitor_addr: >> + >> +PMD power management using monitor addresses >> +-------------------------------------------- >> + >> +Supports getting a monitoring condition to use together with Ethernet PMD power >> +management (see :doc:`../prog_guide/power_man` for more details). >> + >> +* **[implements] eth_dev_ops**: ``get_monitor_addr`` >> + > > - This new ethdev feature deserves its own commit. > > - Adding ethdev maintainers. > > We are missing a doc/guides/nics/features/default.ini. > The name of the features proposed here is rather long. > As far as I can see, features should be shorter than: > doc/guides/conf.py:feature_str_len = 30 > I am not really inspired.. "Power mgmt address monitor"? > > - pmd supporting this feature must have their .ini updated. > > >> .. _nic_features_other: >> >> Other dev ops not represented by a Feature > > > You'd have to walk me through/translate whatever it is that you just said as i have no idea what any of that means :D -- Thanks, Anatoly