From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 583F7454A9; Wed, 19 Jun 2024 14:49:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47FB940289; Wed, 19 Jun 2024 14:49:32 +0200 (CEST) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mails.dpdk.org (Postfix) with ESMTP id 057894021D for ; Wed, 19 Jun 2024 14:49:31 +0200 (CEST) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a6f176c5c10so803598866b.2 for ; Wed, 19 Jun 2024 05:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1718801370; x=1719406170; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y2MEfgfH+91OyZ9oahQvc9JjrTpAZt2fbGSTi7JhGEI=; b=YA3J5l4FMeMFWaY9f6UXj3TVi/NM9X7NXxdxxEqGoQkqi+WH+BV9ZBqtbv7WmjdOjg o5Rbz2vx4y2u2KyqzANvMAP7HNS7R5k+OoBk+quG4Gwoxt75AVVTRMFKIl+3iATtfqE4 MDU1QOPVDZOYS+4z21eArp9DObGZq937AZ6wSaMsdJGK+JPrGqkTnw6XukHq5avMPTbr iW0cAjuw0GSK1FgNHgoV5OwVdoQIg3XtPSAs74wbU8Dsp/Iu3HcqJMp68UfoetquJYpP lEmuzFGHE5RZSpG7TWpHS5P01vlRlDonC1UJdafOHlUErMM4w30coU387tprb70mMnuJ LLxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718801370; x=1719406170; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y2MEfgfH+91OyZ9oahQvc9JjrTpAZt2fbGSTi7JhGEI=; b=HPA7xX1xNsNaJafiGjfbSHUO1ruOrm6IwUfylsWci1HqgPFwIIA0UYGVp8XBhL53xz YYI1WELK66kDNH0E5C9sB+qTZjisWwWLlHAi13OuMR7aFCfUZ02BonZpX9LyhVPXJl7/ HtWbE+arY75yiMxxaMk+9CL0IxSvjDgseqjuCPZFeyjMSYScvnVKejzsA0gwkM97kUXx I4guH9Ok58Tx+MMnC0fT1Sa2u3oGig5cL0jR/2euamu6ngvld0tjAXFoYd/XNcOn7dEb HLOEfJP254eQZgKcwjZosyhwzLnolWyUzCMKMguwoH5WeKT838fU1JrnQlHCKuC4OcOP 9Mqw== X-Forwarded-Encrypted: i=1; AJvYcCUgiS1vrnY06zlwRg7wEZIqvEtlYwRNA8hCjjLU30pq+PrG0uVbNtb80kQM3QJRLFNGQWFADRL35OgfKlo= X-Gm-Message-State: AOJu0YxH7EnLj7MV8IJIpiOn2Iq0Ryvd9wYeuqA4xg37L/tiqev7r3h8 YaL1pFq6O6uLn0ddm5VJbTTSAVmrHh9rCdUz5Wz75dKHmjT41tH72o3/GcNSjG4= X-Google-Smtp-Source: AGHT+IGReQHej68YCKwjV8emuRsYRSuFud1X6v9nN5rb9Bzk1ef+zr5PumFVPoowuME5IN+MaZYdxw== X-Received: by 2002:a17:906:e0a:b0:a6f:5b9a:4a70 with SMTP id a640c23a62f3a-a6fab7d0433mr140017066b.67.1718801370456; Wed, 19 Jun 2024 05:49:30 -0700 (PDT) Received: from [192.168.1.113] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56f988c2sm660724466b.199.2024.06.19.05.49.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 05:49:30 -0700 (PDT) Message-ID: <5fa084a0-ec07-42d7-8b60-08eb9f0fa6ba@pantheon.tech> Date: Wed, 19 Jun 2024 14:49:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] dts: rework interactive shells To: Luca Vizzarro , dev@dpdk.org Cc: Jeremy Spewock , Paul Szczepanek References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240619102329.250263-1-luca.vizzarro@arm.com> <20240619102329.250263-8-luca.vizzarro@arm.com> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240619102329.250263-8-luca.vizzarro@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 19. 6. 2024 12:23, Luca Vizzarro wrote: > The way nodes and interactive shells interact makes it difficult to > develop for static type checking and hinting. The current system relies > on a top-down approach, attempting to give a generic interface to the > test developer, hiding the interaction of concrete shell classes as much > as possible. When working with strong typing this approach is not ideal, > as Python's implementation of generics is still rudimentary. > > This rework reverses the tests interaction to a bottom-up approach, > allowing the test developer to call concrete shell classes directly, > and let them ingest nodes independently. While also re-enforcing type > checking and making the code easier to read. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš