From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 5B0AE5A6A for ; Thu, 1 Jun 2017 14:28:18 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2017 05:28:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,279,1493708400"; d="scan'208";a="93609913" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 01 Jun 2017 05:28:15 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: Stephen Hurd References: <5d0e287f-dfe9-3a41-695e-9af0d57d37c1@intel.com> <20170601030232.38677-1-ajit.khaparde@broadcom.com> <20170601030232.38677-23-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <5fac4171-de91-8953-2df3-b78b0708c439@intel.com> Date: Thu, 1 Jun 2017 13:28:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170601030232.38677-23-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 22/26] net/bnxt: add code to determine the Rx status of VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 12:28:18 -0000 Hi Ajit, On 6/1/2017 4:02 AM, Ajit Khaparde wrote: > This patch adds code to determine the Rx status of a VF. > It adds the rte_pmd_bnxt_get_vf_rx_status call, which calculates > the VNIC count of the function to get the Rx status. > > Signed-off-by: Stephen Hurd > Signed-off-by: Ajit Khaparde <...> > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count) > +{ > + struct rte_eth_dev *dev; > + struct rte_eth_dev_info dev_info; > + struct bnxt *bp; > + > + dev = &rte_eth_devices[port]; > + if (!is_bnxt_supported(dev)) > + return -ENOTSUP; > + > + rte_eth_dev_info_get(port, &dev_info); > + bp = (struct bnxt *)dev->data->dev_private; > + > + return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count); > +} I guess there is rebasing error here, this function left here and causing a build error [1]. (or function tries to sneak in within another patch :) [1] .../drivers/net/bnxt/rte_pmd_bnxt.c:639:5: error: no previous prototype for function 'rte_pmd_bnxt_get_tx_drop_count' [-Werror,-Wmissing-prototypes] int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count) ^