From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Patrick Fu <patrick.fu@intel.com>, dev@dpdk.org, chenbo.xia@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] vhost: fix guest/host physical address conversion
Date: Wed, 28 Oct 2020 12:16:08 +0100 [thread overview]
Message-ID: <5fad8f96-7101-82e1-fd66-fc567689b37d@redhat.com> (raw)
In-Reply-To: <20201027020608.4103145-1-patrick.fu@intel.com>
On 10/27/20 3:06 AM, Patrick Fu wrote:
> gpa_to_hpa() function almost always fails due to the wrong setup of
> the binary tree search key. Since there has already been a similar
> function gpa_to_first_hpa() available in the vhost, instead of fixing
> the issue in its original logic, gpa_to_hpa() function is rewritten to
> be a wrapper of the gpa_to_first_hpa() to avoid code redundancy.
>
> Fixes: e246896178e6 ("vhost: get guest/host physical address mappings")
> Fixes: faa9867c4da2 ("vhost: use binary search in address conversion")
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> v2:
> - minor rewordings on commit message & title
>
> lib/librte_vhost/vhost.h | 43 ++++++++++------------------------------
> 1 file changed, 11 insertions(+), 32 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-10-28 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 10:10 [dpdk-dev] [PATCH v1] vhost: fix gpa to hpa conversion Patrick Fu
2020-10-27 2:06 ` [dpdk-dev] [PATCH v1] vhost: fix guest/host physical address conversion Patrick Fu
2020-10-28 11:16 ` Maxime Coquelin [this message]
2020-10-29 8:28 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fad8f96-7101-82e1-fd66-fc567689b37d@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=patrick.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).