From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 384B6A00BE; Wed, 27 May 2020 22:59:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCE6F1DADD; Wed, 27 May 2020 22:59:16 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 700E41DAD2 for ; Wed, 27 May 2020 22:59:14 +0200 (CEST) IronPort-SDR: HhiGOVT0tVpq6+TxYmXze224oFk/BDinLOPFC3TOtaG7V0K3OuZdLs1lV1Tw/it3lDnYjbRhu/ f9bOwi9mUyBA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2020 13:59:13 -0700 IronPort-SDR: QozE0pv4XIlq4R8HQFmzaFsmFluo9Xhy6LGtWViMQgiOoCt4gURpmq9AWQEd5GkoCqZLzMhE68 o9/ND5ijl/4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,442,1583222400"; d="scan'208";a="442672595" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga005.jf.intel.com with ESMTP; 27 May 2020 13:59:13 -0700 Received: from [10.166.30.253] (10.166.30.253) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 May 2020 13:59:13 -0700 To: Fady Bader , CC: , , , , , , , References: <'20200520093444.14904-1-fady@mellanox.com'> <20200527082425.8188-1-fady@mellanox.com> From: Ranjit Menon Message-ID: <5fb576d7-c8a8-8625-940f-3c965a309a5a@intel.com> Date: Wed, 27 May 2020 13:59:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200527082425.8188-1-fady@mellanox.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.166.30.253] Subject: Re: [dpdk-dev] [PATCH v4] eal/windows: ring build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/27/2020 1:24 AM, Fady Bader wrote: > Exported per_lcore__rte_errno function to compile ring for windows. > > compilation error logs: > librte_ring_rte_ring.c.obj : error LNK2019: unresolved > external symbol per_lcore__rte_errno referenced in > function rte_ring_lookup > > The cause was that per_lcore__rte_errno function wasn't included > in the export list. > To solve this per_lcore__rte_errno was added to the Windows export > list. > > Signed-off-by: Fady Bader > --- > Depends-on: series-9374 ("Windows basic memory management") > > v4: rebase on "Windows basic memory management" v5. > > v3: Fix style issues. > > v2: Fix style issues. > --- > lib/librte_eal/rte_eal_exports.def | 1 + > lib/librte_eal/rte_eal_version.map | 1 + > lib/meson.build | 6 +++++- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index 854b83bcd..cbb6b8cfe 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -1,5 +1,6 @@ > EXPORTS > __rte_panic > + per_lcore__rte_errno > rte_calloc > rte_calloc_socket > rte_eal_get_configuration > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index dff51b13d..8937bdfea 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -392,4 +392,5 @@ EXPERIMENTAL { > rte_mem_lock; > rte_mem_map; > rte_mem_unmap; > + __emutls_v.per_lcore__rte_errno; > }; > diff --git a/lib/meson.build b/lib/meson.build > index d190d84ef..30ed9e05e 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -36,7 +36,11 @@ libraries = [ > 'flow_classify', 'bpf', 'graph', 'node'] > > if is_windows > - libraries = ['kvargs','eal'] # only supported libraries for windows > + libraries = [ > + 'kvargs', > + 'eal', > + 'ring' Add a trailing comma here (as in 'ring',). This will ensure that future updates don't have to modify this line to add more libraries. > + ] # only supported libraries for windows > endif > > default_cflags = machine_args ranjit m.