From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anand.rawat@intel.com> Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 90E005323 for <dev@dpdk.org>; Mon, 1 Apr 2019 19:06:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 10:06:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="219535119" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2019 10:06:18 -0700 To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, thomas@monjalon.net References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-2-anand.rawat@intel.com> <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> From: Anand Rawat <anand.rawat@intel.com> Message-ID: <5fb81910-aa83-83cd-b86c-fd50a7b41d33@intel.com> Date: Mon, 1 Apr 2019 10:06:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 01 Apr 2019 17:06:22 -0000 On 4/1/2019 9:34 AM, Bruce Richardson wrote: > On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: >> config/meson.build | 23 ++++++++++++------ >> config/x86/meson.build | 14 ++++++----- >> lib/librte_eal/meson.build | 6 ++++- >> lib/librte_eal/windows/eal/eal.c | 14 +++++++++++ >> lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++ >> lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++ >> lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++ >> lib/librte_eal/windows/eal/meson.build | 10 ++++++++ > > I'm a little uncertain behind putting the stub files and the meson.build > changes in the one patch, since the result doesn't build anyway. However, > you can get meson to successfully configure the project on windows by > adding in an empty file called meson.build to the kernel/windows directory. > > /Bruce > Thanks Bruce, libm is a part of V8 fixes. kernel/windows directory is the patch 8/8 as I thought of it as a temporary workaround. I'll move it to another patch along with meson changes here. -- Anand Rawat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A857AA0679 for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 19:06:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2630548B; Mon, 1 Apr 2019 19:06:22 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 90E005323 for <dev@dpdk.org>; Mon, 1 Apr 2019 19:06:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 10:06:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="219535119" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by orsmga001.jf.intel.com with ESMTP; 01 Apr 2019 10:06:18 -0700 To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, thomas@monjalon.net References: <20190306041634.12976-1-anand.rawat@intel.com> <20190328232451.16988-1-anand.rawat@intel.com> <20190328232451.16988-2-anand.rawat@intel.com> <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> From: Anand Rawat <anand.rawat@intel.com> Message-ID: <5fb81910-aa83-83cd-b86c-fd50a7b41d33@intel.com> Date: Mon, 1 Apr 2019 10:06:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190401163425.GB1457@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 1/8] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190401170618.MY3EDOs4em_80JaVV-i_vXow9KQXCkxt4y6juMt4NUk@z> On 4/1/2019 9:34 AM, Bruce Richardson wrote: > On Thu, Mar 28, 2019 at 04:24:44PM -0700, Anand Rawat wrote: >> config/meson.build | 23 ++++++++++++------ >> config/x86/meson.build | 14 ++++++----- >> lib/librte_eal/meson.build | 6 ++++- >> lib/librte_eal/windows/eal/eal.c | 14 +++++++++++ >> lib/librte_eal/windows/eal/eal_debug.c | 15 ++++++++++++ >> lib/librte_eal/windows/eal/eal_lcore.c | 32 +++++++++++++++++++++++++ >> lib/librte_eal/windows/eal/eal_thread.c | 18 ++++++++++++++ >> lib/librte_eal/windows/eal/meson.build | 10 ++++++++ > > I'm a little uncertain behind putting the stub files and the meson.build > changes in the one patch, since the result doesn't build anyway. However, > you can get meson to successfully configure the project on windows by > adding in an empty file called meson.build to the kernel/windows directory. > > /Bruce > Thanks Bruce, libm is a part of V8 fixes. kernel/windows directory is the patch 8/8 as I thought of it as a temporary workaround. I'll move it to another patch along with meson changes here. -- Anand Rawat