From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6DABA0C41; Wed, 17 Nov 2021 11:19:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB80D4111C; Wed, 17 Nov 2021 11:19:19 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id E9AA241104 for ; Wed, 17 Nov 2021 11:19:17 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="214639974" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208,217";a="214639974" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 02:18:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208,217";a="735764042" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 17 Nov 2021 02:18:30 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 02:18:30 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 17 Nov 2021 02:18:30 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 17 Nov 2021 02:18:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=emyVcBrQRlQWZojq5tE1feGHbVPCOLFilu8potGqMtgvd9u5xM9IT7VNHS7MVvuxYB8EK3M+QjkkZ774HSGlP6ZLHHjolekJ2K+gEcB0/yS8p+MwVlT7SJM9I6AqBOGRcvCZ0+xmjLYkRhKzR/i6oiKizlKEkUdcNIdCP50G9VI81QBQMp4AwUbrIRJ8HRDc8LXVMAB6xUw1pT5EMb/xNb05s45E/Xa5iTenvxU09tZANTmhn9oYry0d1OmJfrs3nEb4HFym6aqDArY4X7QaUIMb13/go5c5+m3k+VCg6PJ+ZlrJqiAUBK+iE1r4ZbTZfbP0EHRdEYEjim3fPXOoJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uQoR66w+LVwmIReARic0/wMyasuXnlM9iHmfZnJxZks=; b=j+U8kGaeebwSu+N3o4jlmS9NBZub1Sn9q4Q8zM7mh1xeK8lLYa1n0M0czLgln0s3wfYQXqbxpqtxIcglrstEp6FcsxloPMZnXatMSynN2mCCLS9teKwCZSvoILTSWV3x6gX5myNpkkZE8Z9h3osPBJSTI0TGSglfFnY5PDK3WPdmghJNX6XejwSXCQAblBiAgzJCs0xkIcv/601eyzyjZroPtvtNTFJg7f8tjTUkqRH6NFS8R68uEbvt5mhwyNA7JxgfKLwg7vx3bQpAYcjSwiLfcKXuPNtPnEn3xcxFp4h+USLOw+c1BtrfFkTyRm8JUtQQdIBiJJZsEkopM5Ap9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uQoR66w+LVwmIReARic0/wMyasuXnlM9iHmfZnJxZks=; b=e29wpJtwbryhgLjZ6wFS6Y4PKdavKnhTevrn7oX1PIql1WSCJ7xyW/bO7TSKgd11lGPB5u8VVFotxQiHiPsb8PE74KeFyLjLkm6V+e42CY9B7Xbiq+YSxapGmHJ9XZhGGwTxqc2lfVtWezTEtFnvqNEkeUrZemxRXdQSVqbLjzI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by MWHPR11MB2013.namprd11.prod.outlook.com (2603:10b6:300:24::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Wed, 17 Nov 2021 10:18:23 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8ded:1b78:a4ab:1505]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::8ded:1b78:a4ab:1505%3]) with mapi id 15.20.4669.022; Wed, 17 Nov 2021 10:18:22 +0000 Content-Type: multipart/alternative; boundary="------------5YoV20Rjfm0qtPCM8ZjGN5Nv" Message-ID: <5fd4a27b-c6a4-e7f9-825f-74de6201238c@intel.com> Date: Wed, 17 Nov 2021 15:48:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.0 Subject: Re: [PATCH] app/testpmd: fix tunnel offload validation To: Ferruh Yigit , Gregory Etelson , "dev@dpdk.org" , Ori Kam , Viacheslav Ovsiienko CC: Matan Azrad , Raslan Darawsheh , NBU-Contact-Thomas Monjalon References: <20211102122421.4190-1-getelson@nvidia.com> <6725b879-c2fd-3902-eee0-2b5ea284562b@intel.com> From: "Singh, Aman Deep" In-Reply-To: <6725b879-c2fd-3902-eee0-2b5ea284562b@intel.com> X-ClientProxiedBy: PN2PR01CA0100.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:27::15) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 Received: from [192.168.1.18] (223.178.210.106) by PN2PR01CA0100.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:27::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend Transport; Wed, 17 Nov 2021 10:18:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4e36b194-7642-4a8b-5aa2-08d9a9b395a7 X-MS-TrafficTypeDiagnostic: MWHPR11MB2013: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LKManZ1qoe/4PKo8TaN5O22QGa5hu4+03MIANNBoBfLOJTrla5EEr3AGTp1ON5SC6qgcAl52CTrZyTZgkHLmTbQ1iEpAhpWLt1CE8VkejNg9BHMJZeYg1qkro8NQ68pdwQzIVuu+cWAzXVbH2qHsyYSKUDpk8Zh3Y9EiZx+cyM8NBksJpiHxtY/ps6UOdzagqFxyMsHF/T4PN92SavMwhkQr5s10pGINz5cwT6c8Bq31+SxaHQYP3vfPe3fbcBbnOEwvSzqNk907h5exBl1nSugZc5MPCsaEffAHhJaGbutc2IQ1ZcV+/xLy3mrq5UvXcNvQGguffgK1pZfrsO/Gp6FJsmxmDK7tV66XRD0pVQsbFeP/Xr/scJjmqL14sWQAy5FaWTSKmtsQc6TYjEQZyqjetUJTlgftpFrFHvKbPGU0fKgEhrnB4+A8cOPTySg0miJnxPWc4yBxDTCB7YRD6IlhM+uAKJiZ039ig9g9VLxgqRyTLlNCoIPxtsu9zBLrYPUGpc8JEBloS+rXX7YmkIO2EjVaFEvYAWk7gmgDAq9WeTH0FV4w5XVZcJIDdn13n7qgjjX+toR8nPnnNa7VHOWr7e21YDGV6uX2n+iySZhx5dpHtosESg9jrExmiC39JEStnvs3w4shP4r3jKkYFFF0f5Cwa+UgYcNrqx/vG3vw/79LsAfUK+SIFzG8Wvqvf8+M/IXAnTbpKeGZjEr7bcYPONHvMuMU9x+xWHohCA8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(54906003)(110136005)(508600001)(8676002)(186003)(26005)(33964004)(53546011)(8936002)(316002)(66946007)(66556008)(16576012)(66476007)(6486002)(2906002)(83380400001)(38100700002)(31696002)(36756003)(31686004)(4326008)(956004)(2616005)(5660300002)(6666004)(86362001)(82960400001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWV1UGJLaUh0R3FEdjU1UnpOalF5aDdlQXk4L0szWXFRZlZLdGNaWDlFbnlO?= =?utf-8?B?SmRCUyt5cy9MbHU3bURzM1RYc3RYVU5lblpsK1Bna1d2eUFlaUZ3S3NpaXNF?= =?utf-8?B?SXUxb2drcGF1MGxkZlM2K2w2Vm9ZSVBwZkNmZHRPUTZEK2U5UUNlVThVakdX?= =?utf-8?B?TmpWOU91WFFoMmREejJYbU5VTk1xRkFOanJkSlR4NjI3dUZHaExpWFRpVlc5?= =?utf-8?B?MFdYb3VjQmp1cDBRb2lpUjhYQlphODNPUjNtZzhKRG5DRWpHY1VGeklqM1VI?= =?utf-8?B?dFNZekVvazRiSzVmOG4za0Jpa0Y2VGMvUW4yWVI2bU1Ub2VWVmVUbFhaU0M4?= =?utf-8?B?MXZkdXdTeTROMXhEb3JnQ2FMWlc3SVRLVnZHVnh4Y1ZQUUs3aEVHbHNZaUFp?= =?utf-8?B?aTBhY1ZCbXRZYm0vSWlRUGh2SjRPWXBWM2NncTlFVDJFc0VDVFJzaUdzbDBM?= =?utf-8?B?UVF5NEd1clAyMjJLcXJNV1R2UmtnUnVxNnZSVUp4bFhwajhsM3I0QjNEUmhr?= =?utf-8?B?WGo5bG5xMDhPZVhyRXR3dU5mdHlsRHEzaUQwWjlHWUo1SHpjZ3VhdXFrWm1o?= =?utf-8?B?NnBNQXhpa2ZVNjNGY2hhWG1zTTZ2WWZwaU1YL3pTZVpuWDZuUmJmQWwrdjNn?= =?utf-8?B?L2Y0T29XMmtqYVpBbVhDVEMvQ2tXRy93aGc0VTNPMVhxZ2JtaEpZTHo4UFAz?= =?utf-8?B?STRyenBVVitPMFg2OFBvQTFrVklXcmE3ZzVhZ25QbzMwelAzb1NzK2JjUDNy?= =?utf-8?B?MEpFUGJLMFVDZklreTluaHhDOW5sR25WTGRaN2JCZE1QemNPa1p2TlZ3Vnkv?= =?utf-8?B?OE5xOE45d3dINkZIbjROVStoNG8xckRpMTFYanIyRlRtVWdXN0JsRndjQWE2?= =?utf-8?B?djVpeTFHT2FTMjJObTJHSkNVdmw0WEJBYS9VS3B0WStYZTVpQkdkcW8ySVlR?= =?utf-8?B?QzJ0VWpMVk5XNXp2QXJDU2dJUGRyb2lkbEpFK2NCVHNSZ2xEdko3cldMSkN3?= =?utf-8?B?c2oyMUdIVGZmYURpQXh5SWxBTnNHYWNGUUltRWlwSFVrNTUxakl2MXFwL0ZS?= =?utf-8?B?YTg0U3EvbW5kQVdnY2JtQmJQL0hNZGFIWkI0SmNWWnRVUzY4L0QySmorMjAx?= =?utf-8?B?THFZZDI4RkRUTFd4ckdmaDIwR0NUZThnOFFMWmZHYzFyU2pUdU9qNmlEcXlL?= =?utf-8?B?cTZzaGcwbWZmL1R2Z0ZsYWRJQmp6MHY0WmY5R0dPbjY4WDFMclFjcDVOQUtw?= =?utf-8?B?WllEOTNzMnFhQW1rN2QrNW1leTdCSWlTRXNWNnJDcVM3bktzQ2c3WENpcXhu?= =?utf-8?B?RS9hTXI5QkhWSklJWnk0SUcrNk5ZSkdIdTIxQmlpd0k1aGtKRnNVclRGS01H?= =?utf-8?B?VU40UjBkTHkyRW1iVkljb0J2aERPcDkrN2lxaHZKWE1sOU5oV3pSR2tEb0sv?= =?utf-8?B?MFVnVjFoUEtLL3V4Z1hhQnA4V2cyYTNpSnJha2d6OCtTeW1UUnNySHNnTit6?= =?utf-8?B?NWZDYXNOcy9wY2h0aVl4VGpHL0syREx0VHRxMnZyYzdBWGhmc0JrcC9OLzl6?= =?utf-8?B?NnFPV1lYS2RLaElIVzBxT0FpZDEzaWpxNExqaER4RWlWenp3LzBZbndBUGtG?= =?utf-8?B?ekRJZ3B0Y0dOWlNQVW1HRi9kcXUzVi94Qmxrb1RCelFhTytQTldGMk1FcnI1?= =?utf-8?B?Y3BBSkZyWUdIUEl0RVczMXRFMnRnS3orUE1GdHZEQzdVVHdkMWs5MGcvQ3gr?= =?utf-8?B?eUV4b0g1QTgwVVNJeXM3REZmY1dZaWltd05vWStqWFVudnVzQzNVNFo5cXV0?= =?utf-8?B?aFNLUDFuTVpYelp5dEpxejZmTEVrSm85bVM1OEUvSDNrQVdHd0NoemxsU1BW?= =?utf-8?B?OTdnMnZhWGFBcnBiZVc1ZUlHeHdKU2RUT3BydUp3U1grS2dDZHplOGRDRFFX?= =?utf-8?B?VHdaeXgxMHlVVWQ3aGsybEI3S0ZNYjJGU0IwNHF5MmJWaVdyWkx0MDF1ZVVk?= =?utf-8?B?V2crMXhCUXNsWDdBZ3VpYWdwRVNjVFRrWlZQSkdqaDllYVliSjJLM1lBK280?= =?utf-8?B?N1dlNW5XbEV3Z0xFZmJKTWp5NlREcGh1US8zYTM2QzJhVTlucjVLckJYSkVh?= =?utf-8?B?NmE1L3JsQjlhUzUzWHVpMnRoSVk2dm9DSG8wOWJEbXRzOVNXSFJWVWNYZTZY?= =?utf-8?B?amJSS0g2YmthUThUNXVRY1ovVXhreVZpb0lrTkRGL2hJTEY4WnJqUHJMR1Iz?= =?utf-8?Q?auMCghv+ir+c3PuCWbNlqaifhLEMvppnsMKF9hAQyA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4e36b194-7642-4a8b-5aa2-08d9a9b395a7 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 10:18:22.8626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F4PsPyWBRwQ+3GH61P9WhtxKZswWkE+Jv2HxtReFonawuccRXYC1ZzUb8pwfXxVSRfxU2socQ2amoZli78IaSXbKBfZwhQtA2yGw8PycJXw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2013 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------5YoV20Rjfm0qtPCM8ZjGN5Nv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/17/2021 3:39 PM, Ferruh Yigit wrote: > On 11/17/2021 8:57 AM, Gregory Etelson wrote: >> Hello Ferruh, >> >> Can you estimate when this patch will be merged into 21.11 ? >> > > Hi Gregory, > > It is not merged because it is missing review. > > Ori, Slava, can you please help with the review? > > >> Thank you. >> >> Regards, >> Gregory >> >>> -----Original Message----- >>> From: Gregory Etelson >>> Sent: Tuesday, November 2, 2021 14:24 >>> To: dev@dpdk.org; Gregory Etelson >>> >>> Cc: Matan Azrad ; Raslan >>> Darawsheh ; >>> stable@dpdk.org; Xiaoyun Li >>> >>> Subject: [PATCH] app/testpmd: fix tunnel offload >>> validation >>> >>> Tunnel offload API allows application to restore >>> packet to >>> its original form if chain of flows missed after >>> DECAP action. >>> The main idea of the tunnel offload API was to >>> query port PMD >>> to provide flow elements - actions or items. >>> Flow elements supplied by PMD are merged with >>> original flow rule >>> elements provided by testpmd operator to >>> create a new flow rule, >>> optimal for PMD, to implement the tunnel >>> offload API. >>> That flow rule transformation is hidden form >>> testpmd operator and uses >>> internal testpmd resources. >>> >>> Current testpmd did not release tunnel offload >>> resources if flow rule >>> validation failed. >>> >>> The patch always releases tunnel offload >>> resources after flow rule >>> validation returns. >>> >>> Cc: stable@dpdk.org >>> >>> Fixes: 1b9f274623b8 ("app/testpmd: add >>> commands for tunnel offload") >>> >>> Signed-off-by: Gregory Etelson >>> >>> --- >>>   app/test-pmd/config.c | 6 ++++-- >>>   1 file changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/app/test-pmd/config.c b/app/test- >>> pmd/config.c >>> index a18871d461..4870aaeba6 100644 >>> --- a/app/test-pmd/config.c >>> +++ b/app/test-pmd/config.c >>> @@ -2011,6 +2011,7 @@ >>> port_flow_validate(portid_t port_id, >>>       struct rte_flow_error error; >>>       struct port_flow_tunnel *pft = NULL; >>>       struct rte_port *port; >>> +    int ret; >>> >>>       if (port_id_is_invalid(port_id, >>> ENABLED_WARN) || >>>           port_id == (portid_t)RTE_PORT_ALL) >>> @@ -2037,10 +2038,11 @@ >>> port_flow_validate(portid_t port_id, >>>           if (pft->actions) >>>               actions = pft->actions; >>>       } >>> -    if (rte_flow_validate(port_id, attr, >>> pattern, actions, &error)) >>> -        return >>> port_flow_complain(&error); >>> +    ret = rte_flow_validate(port_id, attr, >>> pattern, actions, &error); >>>       if (tunnel_ops->enabled) >>> >>>     port_flow_tunnel_offload_cmd_release( >>> port_id, tunnel_ops, pft); >>> +    if (ret) >>> +        return >>> port_flow_complain(&error); >>>       printf("Flow rule validated\n"); >>>       return 0; >>>   } >>> -- >>> 2.33.1 >> > > Acked-by: Aman Deep Singh --------------5YoV20Rjfm0qtPCM8ZjGN5Nv Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 11/17/2021 3:39 PM, Ferruh Yigit wrote:
On 11/17/2021 8:57 AM, Gregory Etelson wrote:
Hello Ferruh,

Can you estimate when this patch will be merged into 21.11 ?


Hi Gregory,

It is not merged because it is missing review.

Ori, Slava, can you please help with the review?


Thank you.

Regards,
Gregory

-----Original Message-----
From: Gregory Etelson <getelson@nvidia.com>
Sent: Tuesday, November 2, 2021 14:24
To: dev@dpdk.org; Gregory Etelson
<getelson@nvidia.com>
Cc: Matan Azrad <matan@nvidia.com>; Raslan
Darawsheh <rasland@nvidia.com>;
stable@dpdk.org; Xiaoyun Li
<xiaoyun.li@intel.com>
Subject: [PATCH] app/testpmd: fix tunnel offload
validation

Tunnel offload API allows application to restore
packet to
its original form if chain of flows missed after
DECAP action.
The main idea of the tunnel offload API was to
query port PMD
to provide flow elements - actions or items.
Flow elements supplied by PMD are merged with
original flow rule
elements provided by testpmd operator to
create a new flow rule,
optimal for PMD, to implement the tunnel
offload API.
That flow rule transformation is hidden form
testpmd operator and uses
internal testpmd resources.

Current testpmd did not release tunnel offload
resources if flow rule
validation failed.

The patch always releases tunnel offload
resources after flow rule
validation returns.

Cc: stable@dpdk.org

Fixes: 1b9f274623b8 ("app/testpmd: add
commands for tunnel offload")

Signed-off-by: Gregory Etelson
<getelson@nvidia.com>
---
  app/test-pmd/config.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-
pmd/config.c
index a18871d461..4870aaeba6 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2011,6 +2011,7 @@
port_flow_validate(portid_t port_id,
      struct rte_flow_error error;
      struct port_flow_tunnel *pft = NULL;
      struct rte_port *port;
+    int ret;

      if (port_id_is_invalid(port_id,
ENABLED_WARN) ||
          port_id == (portid_t)RTE_PORT_ALL)
@@ -2037,10 +2038,11 @@
port_flow_validate(portid_t port_id,
          if (pft->actions)
              actions = pft->actions;
      }
-    if (rte_flow_validate(port_id, attr,
pattern, actions, &error))
-        return
port_flow_complain(&error);
+    ret = rte_flow_validate(port_id, attr,
pattern, actions, &error);
      if (tunnel_ops->enabled)

    port_flow_tunnel_offload_cmd_release(
port_id, tunnel_ops, pft);
+    if (ret)
+        return
port_flow_complain(&error);
      printf("Flow rule validated\n");
      return 0;
  }
--
2.33.1 


Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
--------------5YoV20Rjfm0qtPCM8ZjGN5Nv--