From: Ivan Malov <Ivan.Malov@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix prefix in struct member names
Date: Mon, 2 Nov 2020 15:03:41 +0300 [thread overview]
Message-ID: <5fd80c59-8e99-ac40-944f-a3cbf1f50a6b@oktetlabs.ru> (raw)
In-Reply-To: <916bc2c1-eb71-11bd-b07c-d50a82101358@intel.com>
On 02/11/2020 14:18, Ferruh Yigit wrote:
> On 11/2/2020 10:45 AM, Ferruh Yigit wrote:
>> On 11/2/2020 9:22 AM, Ivan Malov wrote:
>>> Hi Ferruh,
>>>
>>> Many thanks for your help.
>>>
>>> It looks like I forgot to add the line
>>> Fixes: 0902ed140fcf("common/sfc_efx/base: add MAE action set
>>> provisioning APIs")
>>> to the commit log of the patch.
>>>
>>> Currently, the said commit has old suffix used in it:
>>>
>>> drivers/common/sfc_efx/base/efx_mae.c:927:
>>> MAE_ACTION_SET_ALLOC_IN_DELIVER, spec->emass_deliver_mport.sel);
>>>
>>> The point at which this wrong line is fixed to "emass -> ema" is
>>> 0f41b86eff7e ("common/sfc_efx/base: support adding FLAG action to set")
>>> that is, an irrelevant patch.
>>>
>>
>> Thanks for catching it, fixing it now.
>>
>
> Done, can you please check again the next-net/main?
Brilliant! Many-many thanks to you for applying the fix.
--
Ivan M
prev parent reply other threads:[~2020-11-02 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 7:39 Andrew Rybchenko
2020-10-30 14:20 ` Ferruh Yigit
2020-11-02 9:22 ` Ivan Malov
2020-11-02 10:45 ` Ferruh Yigit
2020-11-02 11:18 ` Ferruh Yigit
2020-11-02 12:03 ` Ivan Malov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fd80c59-8e99-ac40-944f-a3cbf1f50a6b@oktetlabs.ru \
--to=ivan.malov@oktetlabs.ru \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).