From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1739454B7; Fri, 21 Jun 2024 14:31:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9A474026A; Fri, 21 Jun 2024 14:31:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 73A1440265 for ; Fri, 21 Jun 2024 14:31:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718973083; x=1750509083; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ndYtR8TSmrs8M/YusJYCGpxYStNDKYOmUVmWHUXBamc=; b=ZR/WkWJBTlj24ZNEcrwVWL83La9E1pCSa1bGBHLTYJQTgo2Bx6hOEspK 4NodA3I4Mk5RL68a7dgSG/wgh+lkvdyS00a7m9h5D0sw+Z5iRRqxF80Yj 9PwCVw6H7wszOf74j5LMXCVJqF7yqrJTR5MENGUXHJ9v6D9mdmSiD4E9W m6xCPJIG/31974nRAQd0dEm+2zo1+kZNyX0Z6JO7+yFIpqin7cS5egiUN epEZXNqCmz2LZhJStUfxD5VcXV0yoBqMI2bQyXVDc3cDSsdrWagRuZdXC s70X1QuqdWwBvmE7PVF3WJoTrCP7Vwt2P5vf6QM5b/CMovB66OitPS34E w==; X-CSE-ConnectionGUID: 47RyqzdsSsaP+RM7VkzsFQ== X-CSE-MsgGUID: a8xiTq/SSceZd/U3o0RGPQ== X-IronPort-AV: E=McAfee;i="6700,10204,11109"; a="19777556" X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="19777556" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 05:31:21 -0700 X-CSE-ConnectionGUID: Qf/laN2oTmygjIEJF4/uug== X-CSE-MsgGUID: fik++tW3TaGbgCY7tCJI9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,254,1712646000"; d="scan'208";a="47491917" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Jun 2024 05:31:22 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 21 Jun 2024 05:31:20 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 21 Jun 2024 05:31:20 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 21 Jun 2024 05:31:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQmdFdrlp78JNNY58BwveLgfuAZY+xrcnz6qhIL1A+T9GGZOXqM1jFVGDi+vTiJ5fGuEJ2oTVE/c4CRLXWQRMXP7YK2XW2z32WOA5jBl2vIpA+5WXGEyViohGK2hcInfXi5RPXuPa6uUaxpPlitgy9yZaxsvCJ39WVc4miUgbNt8WZ6ZQJr+FMFapDbVYsjrhaHM32DjvUTgLLaO2ALgfOvFB1x7xJ7jLI4fVJa6Wut0Z6zzolCgtZPwd/F/1JcA8i2PF6dvXzBqpLwCxp92VHbJeAyUtTRYE/gAqS8+xE2pIVyBvLO0/gxZT2p7H+Rgg/qes1/a8jFEY2CIW4jC/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xEd1h/4ReSLJLIZ0yEKP/h9Jcy5cokeM1fYXWbsF73k=; b=jjk6ppoArYpfyJVau6QWkS5+oGEvk9AzCnmljhPSGOvLoEtCgtGTsxbQfe0ZqfZmcUFOhJtX2Pfa5hRcVtiTHWIyxAr4dnLhssanzWoWJVHJkjSKc3CeRQ4QnLv1DDcKp30oIM/DHkvhNtFUtdlkx7202U5YWQduR0xgy/iKOysPWscJWt/RQqGOm+Y2hordkwwQU0kKp437jRLvYLaJaMMAjqqjxvSsUzR1735RBiFhfIfb8wUfCIE1bcH/KtoLxsz++3K3clq+u7U0c+SrI/UXdD/Y4yGp7CYzNFz4XKErasGQ11f0z8GSjDW7G6oBc2kXclrPmRhSl2xbRSqNvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by PH7PR11MB7026.namprd11.prod.outlook.com (2603:10b6:510:209::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.19; Fri, 21 Jun 2024 12:31:17 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%2]) with mapi id 15.20.7698.017; Fri, 21 Jun 2024 12:31:17 +0000 Message-ID: <5fe00885-fc4c-495b-8d55-511365f75028@intel.com> Date: Fri, 21 Jun 2024 14:31:11 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 012/148] net/ice/base: clean up __ice_aq_get_set_rss_lut() To: Przemek Kitszel , CC: Ian Stokes , References: <20240430154014.1026-1-ian.stokes@intel.com> <5cebb15c-f54d-43ae-8890-2b2a10b8f78c@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <5cebb15c-f54d-43ae-8890-2b2a10b8f78c@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0185.eurprd04.prod.outlook.com (2603:10a6:10:28d::10) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|PH7PR11MB7026:EE_ X-MS-Office365-Filtering-Correlation-Id: 26224c2b-19f3-417e-d6e2-08dc91ee0c51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|366013|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Qkd6YjJxRG4zcThoaTNkRytFemNLbkJuYm9tYmt2UENBTGQ5amt1cnR5TnNU?= =?utf-8?B?bENBZi84OUpKS1ZQcUlWWXd3a0IwR3VnQktKajJkcktwaEEveVZnNG1VbHpj?= =?utf-8?B?VWFKdWd6TGo5QkZOQlYwOC93T0p4RTlQdDdTMG5kNHVPRUtCWUZ5WmlYSDQx?= =?utf-8?B?a2F4SU1xTTd1L0V1NHY4R1NjMDdRS1ZkOVZXbVVsS1h1aFZmeVJpRHdqaEhm?= =?utf-8?B?VHBVOS9DeXcrZXdpNGRWcmFqZXBvN1A1TlE4dHNjb3l3NERoRHZ0U29qOGVz?= =?utf-8?B?ZytlY0w0UzhPcDhsNVFHb043ZUxiYWlpOFk4OHM3SHJQZ0l6M0F4bk5YK0Jk?= =?utf-8?B?T2tTYUI2ZFdtT3ZRVGtoZWRHdmhtd1lya3B3ZEpuNk5rTUlLaEV6dUxNRHhI?= =?utf-8?B?Z2hoSDh3Ry9iUlRZUFpKeGpXVHFNYnNsb0ZTcXZoOGVmSEV2Unk0U1F4d1Ev?= =?utf-8?B?S1kxTXlCVHdCTHQ0VmN5YURmLytjYUxGR0FhWEhISnhrV3d5SEFNbHBsb3Jr?= =?utf-8?B?ZWtuc3JBU2p5SUxSdVo0Y2hCNVB5cjRkRkdZbW5aeXhiZEJMUG9vSnlkd2Qy?= =?utf-8?B?eCtrV3VUTEN5RHBxNGlZdlVudUpKdFFZVTNMUmZWTkNNTmRuWTg1L3hzWjBW?= =?utf-8?B?VTFMNWsrK2FUb0pQNmo1bWpaQ3hKcWhGZVZDOE1GOXpvVEJteGsrMUU2K1Ry?= =?utf-8?B?Vm5aQUY1NUNaYmJRcXk4QmhLSzJHVmp0Y29pNjlqcEZOZGRidTBXY2hBR2lJ?= =?utf-8?B?YWh6NGtDRmFJaE9pL3BFSTh5VDFnUFZsdjRzdXhIcEZsWm5mWk5kOXdKeHdl?= =?utf-8?B?dU9MbldKbDVxRkMyVnNHdXgvR1lNYXR4clg0cDg0YmZyQnhwQ2Q1MFVscHNW?= =?utf-8?B?M1dYQnhpdUEzek5Qd2crMm9BZlRhSGE0Q3c0MFdJRmY4QTNYak5mbUNmbElP?= =?utf-8?B?cUJ1N2RGY3Qva29RT09aSTBLaW1UU2JGVXBSbGZva0R6Q2J4clNicUU2bDVE?= =?utf-8?B?cnFRWEZMQWlmcHJydlNwSXlJTlZpdmM2UUVYZHZENlR6bkVVd29UbG03Rmlw?= =?utf-8?B?eHRSaFVWVDFrWndvSUhpdUNjaGwyTUx1dTdxOHUrRjRjWHRPT2dVZHJNQ1Za?= =?utf-8?B?M1JVOWF2VGlIOStmY2M5MndnWHVyQitxSEZXWVlkRWNRdEYvYTJkQ25KT0pt?= =?utf-8?B?VThubWUxekoxY085UEVXSStYbVY0YXpzQmRyZEZhLzlXUFMwaUt6OSs1dkJF?= =?utf-8?B?YkhFZW9uc2ZjSnExejNVditibktEYXZpN2NQM0RwWktTTHllYTBhZnRRdkxi?= =?utf-8?B?RkNabElwT1hkSnNwUDJPMzNHcHNFTEJXUm5RSGhib2xsdE9UMzZaZTQ2Szdu?= =?utf-8?B?N3Z5Yk9XUTJCVzYxM1NGNDJNUjlsbFVURUc0Q012OFl3MHRXNXFoT3hIMVdQ?= =?utf-8?B?ajB3cGE4a0J1cUxjK2J0NDJSVmtUMkt3NklvY2xuSnRUVXFNKzBFN1h5bzg1?= =?utf-8?B?MU5ta2RhWHVjaFErL1VGR29jK0k1dWpyMU5hSHIwLzQ2NkZVSGo2cHY1bWEz?= =?utf-8?B?bWlycmRxdGczTk9jREZxQWg0bjF6eDhiMVM0TVFQK3RuQ0xSak12b2dwWGxn?= =?utf-8?B?WEVVSWl4VjhGODJBT0pyZEtFbExQMktYL3NFWE5NalQzeDhwZ1BwVm85OEpx?= =?utf-8?B?NnJPbCsyUUk0K01yRWRjY0tSRDQwSUhRZHpSN0ZrNXovUW04TEhRMmVFaVky?= =?utf-8?Q?HnkVlrxdJ34/iGc1n07S+wwB1JgkDs1li6OSV3t?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(376011)(366013)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWNYbUxPTXVXNXR0SFdiRlJlSlVmL0RmQ0JXb1JNSEZSdWM5TkxLNmRudkpS?= =?utf-8?B?QlBxNE02Wk1XYmpvMUVpbmlqV21GUWNpM3kyRk0yUEEyY05PNGVaOHFoZUt6?= =?utf-8?B?YkF3MGZkY0NkeTJ3WDZIVzVWTlBacTJoSFk3SFMybkJNdlFrdGJEdVRaeTQ4?= =?utf-8?B?NW1OeERVMjdHZWtsRjJKelN5akpkMGpVSmVHblVIeTI0cncyUVRPRHUreWJO?= =?utf-8?B?cWllU29wV08yaUpOczlXeE1GN0YzalIwS01uaHVlK3NpekZEcWk1ZTJwU0tE?= =?utf-8?B?WVN5cG8wL2FSMFZtWUlONnRXQ21FUTgrZTh4aWlyZm9RR1hwUGFiaWVtek1Q?= =?utf-8?B?L01FN3o1UTQrNDdORXltaVRMR1E1aVJTVnlPVlVOOC8zaktJdEhYeWY3VE9Z?= =?utf-8?B?LytTVXNod014ajRZeXN3dlpjSU5NRjVKYTc4VGdUK25DVitYa0dDbzBUMitI?= =?utf-8?B?blJ0YmNkVk5TbzU2N1BFZFV1dno4Ri9UOCtLYUorSkdWWHBJQVd5QkovT2xr?= =?utf-8?B?cS9QOGRGaEdCSng3MldPY0pwbEhuU0dUZTY3SC9WcjJCZTM0RUVBdkJTZ0VV?= =?utf-8?B?WHN6M0JLZzB3Mm8rOUN1U3Y3VzFoSkFiSHNaOWliSTZaZkE2S2FwNnMwd2hW?= =?utf-8?B?VUlHK1VjUjYvL2txbTk5TjJwRzdwMUFoSC85VXl0ZjB6MnluUlExbEt5NG5r?= =?utf-8?B?UE5lSGp0V0JwL3VFK2Mya1oxU0dWa0JHdVRnaVFWczJHQWRKcGVkR1gzbW9M?= =?utf-8?B?QWVnUlloQldLNytsbnZjNndhQTlDNmQ3emV1Ym93TWNVZkwzSlFHeXEyRjF3?= =?utf-8?B?N1NjRUhBVFBiWCtVTGpVTTVSc1R0TmxWVDdBaTdRemtsTTNDeGNYMUg5cmFt?= =?utf-8?B?L0FIUlgrc3JvN1M4dU5xamkrclFkemp5SkpqWTh3UFVPbmVTZURvK3dJWjUy?= =?utf-8?B?WlNxWlNwMGVEUjBLZ25xZVpPYTJGRm5wckhtQlNwWDFDaS9jTFhGMU05cWFR?= =?utf-8?B?eVp2YUwzM0krVUp3THptaVdNTVlxYjF4cXQyQVovT0oyVE52N245RjVPOHl2?= =?utf-8?B?OFRhWkZRWDltVVV1YkJ1cnlMMk9XYnhpV1VoRVhHdXdtZEdNRHhOWi94cEdo?= =?utf-8?B?RG1qMjh2clAzbFV6RjN4Vzd3Zis1aUxwVEVXRFRxNmRMWnBhV09tRG5WK3di?= =?utf-8?B?VSt5a1U5K2FyTk84dlhWRHAzTUw4RjZDZG5MdFNSU2xDNzlLRFcxSG05aUFn?= =?utf-8?B?MXhyakhzU2xTY1FaVFcwWDhZcXhkVWI4WUpsVFhOcFFodmF6b1VpWFZkNHgv?= =?utf-8?B?eG96OTJNZnhvY0s4bFl5d3ZNNURtQi8yWlFLNVB6TXdPWTBUenVEN056V3R3?= =?utf-8?B?WGN5ank5UndhZHcrZlVVYnpDdEptRTJxSzBSZ0x6QXpvTzNKMVI1eFd2ckQ2?= =?utf-8?B?TTArUWpBNlorcHVLc21ZZVZZSURqTi8wRGppakd2c084RlhEL1ZIcmFQSXlY?= =?utf-8?B?TktIdUJJM0dyUmVVNS96WTF4VkZzOWQwdjViNmZCRjB5YkY5NTErVnhwb0xn?= =?utf-8?B?S2FqM3owS0Z4TUJaR2gyNjBlM1g4dmNZcmJvZktpVFZxeTgySVpHUTJRY05l?= =?utf-8?B?M0EzRXBwZFVOM0dTNDNnWVdxQXEwM3c1azVVaTVSdUx5SkxkZlZCYm1PbWlt?= =?utf-8?B?ZHpTM0ZBTmNiZm15WWpRamJRaFgwN0syVytDQWlYU0tReWlDUFk4ME5OUEh0?= =?utf-8?B?V2lJbFFTalA5NU9aWnRTbUtXMHEvUWxvc1ZPUHRmWnNpYk9PWEc3dTU0WUM3?= =?utf-8?B?bnNLOFVlYlRSelZJM0syNmFRVHpKYjEyTlZZc3dtZGNEOVhUd3ZNYm05cGN6?= =?utf-8?B?eUVPVFdocklhM0gyMHJ2V2RUZjE3amZ0bDY1WlZxK1htN09CZlZyODNVSVp0?= =?utf-8?B?Y1NPK2J1RDB5bWorVkhrQU01NjJNODh5a2dJTWMyRTZSRXpaZ3NnRllDQWw0?= =?utf-8?B?U0dPREkxVElzZXpaQVJhd0x0ZHFLRDBkcGlpWUxBbGUra3doekNNRHdYYmYx?= =?utf-8?B?VmlIY1hmVUpSc2ozbFB5Q1lZSU9YRzZWNTNrejlZVTRuVzlvSFNtQ0RITVhj?= =?utf-8?B?MGZEN0tvVzFPamYvYTl6eUIvbDlteFhPZTdzSTF3YlR5UW8ybkVRSWxTUU91?= =?utf-8?B?Mnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 26224c2b-19f3-417e-d6e2-08dc91ee0c51 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2024 12:31:17.6865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: On8poosWnO8/qfUWDdOQV5uCplyjMq4ZSh4DscSUw/xkqKGd7rxgidvvwB65XhZrqV2saKySOR3rf9E8Abb6HzOrsCUnO4+p8f6VjvMqWr4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7026 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/13/2024 8:17 AM, Przemek Kitszel wrote: > On 6/12/24 17:00, Anatoly Burakov wrote: >> From: Ian Stokes >> >> Refactor __ice_aq_get_set_rss_lut(): >> get: >>   - make use params->lut_size only as a size of params->lut; >>   - return LUT size via params->lut_size; >> set: >>   - remove option to set RSS LUT smaller than available >>     (eg forbid PF LUT sized 512); >> both: >>   - clean up code. >> >> Signed-off-by: Przemek Kitszel >> Signed-off-by: Ian Stokes > > I have not much interest in DPDK, but when you CC me on code authored by > me, it would be nice to also apply proper authorship (the From: line). > Hi, Yes, apologies for that, it's an artifact of the process we were using to create these patches. Will be addressed for all patches in next revisions. -- Thanks, Anatoly