From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B4D9A04B6; Thu, 17 Sep 2020 12:53:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23CB01D5EE; Thu, 17 Sep 2020 12:53:39 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150050.outbound.protection.outlook.com [40.107.15.50]) by dpdk.org (Postfix) with ESMTP id BF9421D5ED for ; Thu, 17 Sep 2020 12:53:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uju6dy3PPgXY/7HPDJPu/dpAzjs85PDT/h4sp1mrol8dSdSE5VWUFRDx9VWzpH214gGbrKfNIPqrmlvYehBOe3P1pa2J1nFqc83IEJ1VwpedC8puR6mIV4Z4wsin+okzKGkE6ZdYHKAKWHPX+wMPk4jWSNKNUJc44BJ5MZw3LPbjGYs4SeCb2OhV8xuP/Sg1MD2d2970qOJ/TmKf9ky93gOGRATfD3LwhvfEMSf1uwPYcfcZOMgbtIEeON66ogW5+QaUKlaMGxoWmiMAkNKeSUeTpfkpj98qQsl/GpaRD4NkS4I9/LKD7igLVil4TtgrzNepBT8Tw05tzqge4GEnDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4CAHN0sRjaWQ538kny98QQU6Gu8sr92WGKLat7bnv4k=; b=LirGr90pVqWwAFSFB+QhBs6a6405kQTh79D27SsNNxRc4BGt09QKtBIOEPQ0r/FvCto2BpruRxZ4fpRUwRd5tr0ERceemq2js99wsrL4vgRDfVvnBqHCjmFseNhZL6VPQWn8vx4R5x1QYN/jLOa1uL4dXs9iaO6WlGERJ228HEZ4eJQMAzg1OiMB+cNXeMsg8MMr7r1wWfHeHB4PDzx5M6WpwUH8SaAY4nDa69srQIsb58Ob+HlKS926A2tyCI9S/AaVYGDWCZ01cd5eqM1CNgGDGBcGnp7foieW9wv99oP9kw2Mmp/Ivfi8bgniJS5jXx9b+zkRvGltBruDlolYQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4CAHN0sRjaWQ538kny98QQU6Gu8sr92WGKLat7bnv4k=; b=fkD46hG4DxTGo7+RxzrHnB9Zumy/mCKTRCInklzne2b0h9OWHhk+i6qSteWZx1wSNsTc5phpbHZJ2KfG5oqPEsc9dJdFISGUJgUvnIwir3W1vj0lq4HvugtP6BwwCfUYAOjl62aahxrjUV8JcZpnxSA8KjUHtP4z1Hp6IzM9Yk0= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com; Received: from AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) by AM5PR0402MB2897.eurprd04.prod.outlook.com (2603:10a6:203:95::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 17 Sep 2020 10:53:36 +0000 Received: from AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::e024:2be5:29c3:31b0]) by AM6PR04MB4456.eurprd04.prod.outlook.com ([fe80::e024:2be5:29c3:31b0%7]) with mapi id 15.20.3391.014; Thu, 17 Sep 2020 10:53:36 +0000 To: dev@dpdk.org References: <20200914161801.572174-1-thomas@monjalon.net> <20200917104133.6186-1-thomas@monjalon.net> <20200917104133.6186-2-thomas@monjalon.net> From: Hemant Agrawal Message-ID: <60029109-d44d-bbfe-acb6-4c5a35cc2051@oss.nxp.com> Date: Thu, 17 Sep 2020 16:23:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 In-Reply-To: <20200917104133.6186-2-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: SG2PR01CA0096.apcprd01.prod.exchangelabs.com (2603:1096:3:15::22) To AM6PR04MB4456.eurprd04.prod.outlook.com (2603:10a6:20b:22::25) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.2] (122.176.3.89) by SG2PR01CA0096.apcprd01.prod.exchangelabs.com (2603:1096:3:15::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Thu, 17 Sep 2020 10:53:35 +0000 X-Originating-IP: [122.176.3.89] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 39a813c0-8bbf-44d6-4507-08d85af7ed57 X-MS-TrafficTypeDiagnostic: AM5PR0402MB2897: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QrQcYmPnuzu8W9TTYoylKqI8djPa3Bj2YcZKYTOx6mp5iHKOg4aqZTuNQ6Ai3fLQDai0cbZrrcOWgANDp2ZTL+SlQdhl+vOMVBBNAwjbo/nlvfp4zFKICFcZ0DVJcl9IEYAFVljOR1oCSMdwz2eNv/ilZW0p6QD65FP0rQH/BCTnUEv26+CripcKbhYKLxfT8T4xipQHryAxC9W2YCcc2BKUWtAVOSi1ob/l9qQ7mxjrJxh/z9p1z8oLXEOsUy+Jm3Q+dilotlIj3WOkpTfY5lk9r89LDdbOECCUARG6vc+dZiNxhw+SoUuQ3EeRfZHU2vmlKFvIZ7wJ9h3M4m33jNX4fN+/fRPdiQJPReJZTsw7QTTnF/A4lyK6KcX33Ob1 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB4456.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(39850400004)(136003)(366004)(346002)(66476007)(66946007)(31686004)(86362001)(8936002)(5660300002)(6666004)(83380400001)(31696002)(478600001)(186003)(53546011)(6486002)(52116002)(66556008)(44832011)(16526019)(956004)(26005)(55236004)(8676002)(6916009)(16576012)(2616005)(316002)(2906002)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 63/IiQnQLYY0LEL+p2ZvSGrO84+P3AfDk+Sk1FAGdP2QHAhGPCzzz34M1//VPIU3qdyJet/N1+EAZHysMmzwepXIHDq5wLPJPeePjLdAFF1R1xIHn0PUTMp+4ZfGBbZyDP2vvHdG73ji2wztuFMOITnVQYlhlGIcCzjPp1/1DeRom+4lKGq2Is7xnz9Jj7+y8MRsLOedY2bYUJQGssR5ThGUje84ACW19P58tBlLcxqVmSjlHbXSBV4ZMrL4f9MQBQupmaFzNYodK9Z+P8xOgUsB0rHy5KGSFonGuutqbp8I/Ke/kGwnPAkFekUABGD9aAFdUhP7fr1whAip0rs0NLppD7UQqTeqlHJpWmTYC39jkcFaRNKfhIpOFUZIMn1idFMFNSG9gKeS1H/QwdlBBUV5tf0ivCmymeAold5kNUX8v5TzxdX56KpR49cBV++loRV/TPDVVYeYCseoIaMQyjfyTju+0VnzhPcpVXpXq0zH8zrXr/Z41PLkgmSbLCfpFFzyddigM6AE9F4Y7+68FC1CeuMV596CS+XWW0NPX5nDBUufANy90OFuSjIyGNC1e4Vas/fLgqzYZxK8pYS0CgDJoBCiOCBT4HbKhJezRCQYyiafpJXXwswPu3pxBMHX6krbgJWfwudO1jveH2sFHQ== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39a813c0-8bbf-44d6-4507-08d85af7ed57 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4456.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2020 10:53:36.1584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /Fsfwt1Ty3enPowNAqaxp4SBsYHD7rJYwvlu/+cXh4C24k8N7ZW1t/dgnnYT7h4CzHlBoe1aGRDcdll7JTjRHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2897 Subject: Re: [dpdk-dev] [PATCH v2 1/4] mem: remove physical address aliases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/17/2020 4:11 PM, Thomas Monjalon wrote: > Remove the deprecated unioned fields phys_addr > from the structures rte_memseg and rte_memzone. > They are replaced with the fields iova which are at the same offsets. > > Signed-off-by: Thomas Monjalon > Acked-by: Andrew Rybchenko > Acked-by: Anatoly Burakov > --- > doc/guides/rel_notes/release_20_11.rst | 4 ++++ > drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +- > drivers/common/dpaax/dpaax_iova_table.c | 2 +- > drivers/compress/qat/qat_comp.c | 2 +- > drivers/compress/qat/qat_comp_pmd.c | 2 +- > drivers/crypto/ccp/ccp_dev.c | 2 +- > drivers/crypto/octeontx/otx_cryptodev_hw_access.c | 2 +- > drivers/crypto/virtio/virtio_cryptodev.c | 6 +++--- > drivers/net/ice/base/ice_osdep.h | 2 +- > drivers/net/pfe/base/pfe.h | 2 +- > lib/librte_eal/include/rte_memory.h | 6 +----- > lib/librte_eal/include/rte_memzone.h | 6 +----- > lib/librte_kni/rte_kni.c | 14 +++++++------- > 13 files changed, 24 insertions(+), 28 deletions(-) > > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst > index b729bdf200..c49e612c43 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -84,6 +84,10 @@ API Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > +* mem: Removed the unioned field ``phys_addr`` from > + the structures ``rte_memseg`` and ``rte_memzone``. > + The field ``iova`` is remaining from the old unions. > + > * mbuf: Removed the unioned field ``refcnt_atomic`` from > the structures ``rte_mbuf`` and ``rte_mbuf_ext_shared_info``. > The field ``refcnt`` is remaining from the old unions. > diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h > index 35423df12b..2dd53c63ba 100644 > --- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h > +++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h > @@ -368,7 +368,7 @@ static phys_addr_t dpaa2_mem_vtop(uint64_t vaddr) > > memseg = rte_mem_virt2memseg((void *)(uintptr_t)vaddr, NULL); > if (memseg) > - return memseg->phys_addr + RTE_PTR_DIFF(vaddr, memseg->addr); > + return memseg->iova + RTE_PTR_DIFF(vaddr, memseg->addr); > return (size_t)NULL; > } > > diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c > index 5ba8ed1933..91bee65e7b 100644 > --- a/drivers/common/dpaax/dpaax_iova_table.c > +++ b/drivers/common/dpaax/dpaax_iova_table.c > @@ -440,7 +440,7 @@ dpaax_memevent_walk_memsegs(const struct rte_memseg_list *msl __rte_unused, > void *arg __rte_unused) > { > DPAAX_DEBUG("Walking for %p (pa=%"PRIu64") and len %zu", > - ms->addr, ms->phys_addr, len); > + ms->addr, ms->iova, len); > dpaax_iova_table_update(rte_mem_virt2phy(ms->addr), ms->addr, len); > return 0; > } Acked-by: Hemant Agrawal