From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CA41A0C46; Mon, 27 Sep 2021 19:10:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C986B410DC; Mon, 27 Sep 2021 19:10:22 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id E085E40E3C for <dev@dpdk.org>; Mon, 27 Sep 2021 19:10:20 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 4B3E5580AAE; Mon, 27 Sep 2021 13:10:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 27 Sep 2021 13:10:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= eT9F6Py5sP7Bhi2VSpPNOVBv8tzhb4Q3rXG2dYNkSC0=; b=Dar3xxpHad+kH9zl vWUsw/aj2yu1TUCbGe4U2Nsill6TY24n79WM20ePxNN8vydqd/9q6mmIkItHHTVS p7Mml8rWKSNdVPo0lMDP7ACeryl3fO7mGZSEZeLqdPR/CuZqjNDlxEMBHsgzwZij QDasMB94Vj5WnGXIN+3YGjhbXK+MX3KY2air+sNcy+Rdb12kKrvtZ/rMrKJ/VpXY ksQaBE4O+7d7XlcoAwXTWRZE2gZLOWDNj1ucynC7icat2GSUXMLn9LLg+M1ZsSUM hkE9eRtaRw51k8kien4XRjrGyzegZHOFjUPQQ2faQUc8uMY/IJeI+Jf4imyFYYeW 3jgp1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=eT9F6Py5sP7Bhi2VSpPNOVBv8tzhb4Q3rXG2dYNkS C0=; b=sz6Mx5AmuQwbB9JdjWxFn/00VcMWehWAoDadtrZw6ituAZuNGpd53ajSx sxCDciJ67imloDPjTTqV+APsJwdo7ewgoSb4pEqai8PR7tt3muV6s9gf5CtqhRBp wdXWNnAcdVM/0dvUEuS2FwPRv8/QwfHRerkdryH0gYMhHWWFc7sFLvwgVT0hAJXk Q51XubPNQrytzy+RiiGv6FNyKVkqFOONH6BbmkJcsP4Uh7zgBdkk0voyThsuHzqS oF3iLD2dqNHsRYGncg6sdsdnkJ1VvVSJqAlfqdOd2BDF5QXaue/p/swSc+BvM5ko V1iKyPiT21iW/KWynmcN5O7kmuh4A== X-ME-Sender: <xms:-vpRYdwXzPknkHcFk1Jah9_zWGcrL_pUPtCngDBBGtS_9NIiBGg_gQ> <xme:-vpRYdTsG8ioZK1FGakVLjugurUA1XQCbkD8XpiQndzbnNz5bx4SGzFPw4PmPnZx0 gTukIE489B52GnNRQ> X-ME-Received: <xmr:-vpRYXWmem36QVLJriDEfm1i6HZPfYBiWOd4RJY8Y_RZENbk2yrWdOPU_D7ud_BqvJrgxk4fbmclo7cDQbMXNDpmAA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudejkedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:-vpRYfhphf2QC51n10B2ogKtVC2Bb0pBBQdFF09Qog_sSTGUOCd18w> <xmx:-vpRYfCy5sv97eDVUdHcjuDgVJSxhCij_fH48NcYF__U7azo2kOCRQ> <xmx:-vpRYYJsJKwzvVFBXhVStp4qfuXySviA2i2fp4nOd3bKJW-NVQZCpQ> <xmx:-_pRYT6J5k0DYS-20PMbL_v4t-6InyTB_IDC6tK5yrU1QRrdy58-VQ> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Sep 2021 13:10:17 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: konstantin.ananyev@intel.com, jerinj@marvell.com, gakhil@marvell.com, Nithin Dabilpuram <ndabilpuram@marvell.com> Cc: roy.fan.zhang@intel.com, hemant.agrawal@nxp.com, matan@nvidia.com, dev@dpdk.org, ferruh.yigit@intel.com, radu.nicolau@intel.com, olivier.matz@6wind.com, g.singh@nxp.com, declan.doherty@intel.com, jiawenwu@trustnetic.com Date: Mon, 27 Sep 2021 19:10:15 +0200 Message-ID: <6005074.3AfhPUk8WP@thomas> In-Reply-To: <20210915163001.26859-3-ndabilpuram@marvell.com> References: <20210624102848.3878788-1-gakhil@marvell.com> <20210915163001.26859-1-ndabilpuram@marvell.com> <20210915163001.26859-3-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/3] security: add option for faster udata or mdata access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 15/09/2021 18:30, Nithin Dabilpuram: > Currently rte_security_set_pkt_metadata() and rte_security_get_userdata() > methods to set pkt metadata on Inline outbound and get userdata > after Inline inbound processing is always driver specific callbacks. > > For drivers that do not have much to do in the callbacks but just > to update metadata in rte_security dynamic field and get userdata > from rte_security dynamic field, having to just to PMD specific > callback is costly per packet operation. This patch provides > a mechanism to do the same in inline function and avoid function > pointer jump if a driver supports the same. > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > Acked-by: Akhil Goyal <gakhil@marvell.com> [...] > --- a/doc/guides/rel_notes/release_21_08.rst > +++ b/doc/guides/rel_notes/release_21_08.rst > @@ -223,6 +223,12 @@ ABI Changes > > * No ABI change that would break compatibility with 20.11. > > +* security: ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` > + routines used by Inline outbound and Inline inbound security processing are > + made inline and enhanced to do simple 64-bit set/get for PMD's that do not > + have much processing in PMD specific callbacks but just 64-bit set/get. > + This avoids a per pkt function pointer jump overhead for such PMD's. Please pay attention it is not the right release notes.