From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 24941803A for ; Thu, 4 Dec 2014 17:01:13 +0100 (CET) Received: by mail-wg0-f42.google.com with SMTP id z12so23052251wgg.1 for ; Thu, 04 Dec 2014 08:01:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vdUJD9RAOkB2Kl9b6ZR6ADkcSkOR8oxVgCXKEGr7ySA=; b=LKG9vPIgYR8twMtmZqtU9xQ856QY6Tpf9HuKzCOl+3QuRdGGUTr4FffnogUINbEc31 kKEIA6826nVByHawoxlv4s2IIwyFWNOyBqcGzZkBNH2xuVWl3nRHJPYZ0YLEv8kBcOuJ UMBFYRxFHlJ+0tuMz4Qzuz65KdLUlzy2KZ3/yJz+TSM3tBkYaE9p8FlJ22A4CLG7QoDD Bllw3LSis4IGVeey7KpgHrtioOH6jlLvqrm8fJFi2iQ+svKamVJIabzbD3zBOUZqCL1A KZLAvzU77zoymeWgmO4BL7ZIrpSYfUsewYvU4rg309Ez/2TlRAnya7CLIL2iP57xgTTe IMHQ== X-Gm-Message-State: ALoCoQkBemIoOJpXkLVmHaiJo/agmFyJLc4RlvNOlLniGXwgsGP/PI7Qd8xMoWVOh7gpZPCPG/jm X-Received: by 10.194.119.99 with SMTP id kt3mr17607774wjb.14.1417708872166; Thu, 04 Dec 2014 08:01:12 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id wx3sm41043767wjc.19.2014.12.04.08.01.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Dec 2014 08:01:11 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 04 Dec 2014 16:36:42 +0100 Message-ID: <6007845.LEvoKu9qPf@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141204140324.GA4828@bricha3-MOBL3> References: <1417625819-3024-1-git-send-email-bruce.richardson@intel.com> <1770523.OPzYA99vBi@xps13> <20141204140324.GA4828@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] examples: fix symmetric_mp, set NIC rx_drop_en bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 16:01:13 -0000 2014-12-04 14:03, Bruce Richardson: > On Thu, Dec 04, 2014 at 02:37:15PM +0100, Thomas Monjalon wrote: > > 2014-12-03 16:56, Bruce Richardson: > > > The symmetric_mp example app is set up to allow two processes to > > > share a NIC port, with each pulling packets from one queue. In order > > > to have the app continue working when one of the process dies, the > > > drop_en bit should be set in the NIC configuration. Without this bit > > > set, the NIC will stall once any queue fills. With the bit set, once > > > a queue fills, all subsequent packets for that queue are discarded > > > allowing other queues to continue operating as normal. > > > > > > This setting was missed when converting to use standardised defaults > > > in commit 81f7ecd9. > > > > I don't see rx_drop_en in commit 81f7ecd9. > > Why do you say it was missed? > > > This is the one app that needs the drop_en bit set, and the bit is not set in the > defaults. Therefore, when this app was converted to use the defaults from the > driver, the drop_en bit should have been explicitly set as in this patch. [The > fact of there being no drop_en bit in the commit is proof of its absense :-)]. So you agree this bit was never been set for this app? Therefore I should remove the last sentence of your commit log before applying? -- Thomas