From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C86FB2C36 for ; Tue, 2 Apr 2019 15:20:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 06:20:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,300,1549958400"; d="scan'208";a="334270873" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 02 Apr 2019 06:20:15 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 2 Apr 2019 06:20:13 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.142]) by FMSMSX125.amr.corp.intel.com ([169.254.2.4]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 06:20:06 -0700 From: "Wiles, Keith" To: Thomas Monjalon CC: Jerin Jacob , dpdk-dev , "Richardson, Bruce" , "Rawat, Anand" , "Menon, Ranjit" , "Yigit, Ferruh" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific Thread-Index: AQHU6VOmWFi9Sjhe30qLYTgkzLzt/KYpUEIA Date: Tue, 2 Apr 2019 13:20:05 +0000 Message-ID: <6014E7E9-DDA1-48EE-A9E3-C6D651DB11F4@intel.com> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> <30782747.pV0nTTKWH9@xps> <20171011143352.GA23500@jerin> <1935282.F1JuZfYupj@xps> In-Reply-To: <1935282.F1JuZfYupj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.102.28] Content-Type: text/plain; charset="us-ascii" Content-ID: <8245442675161C4A9AC4851E979D3C46@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 13:20:18 -0000 > On Apr 2, 2019, at 7:57 AM, Thomas Monjalon wrote: >=20 > 11/10/2017 16:33, Jerin Jacob: >> From: Thomas Monjalon >>> 07/08/2017 14:04, Jerin Jacob: >>>> baremetal execution environments may have a different >>>> method to enable RTE_INIT instead of using compiler >>>> constructor scheme. Move RTE_INIT* definition under >>>> exec-env to support different execution environments. >>>>=20 >>>> Signed-off-by: Jerin Jacob >>>> --- >>>> app/test-eventdev/evt_test.h | 2 +- >>>> lib/librte_eal/bsdapp/eal/Makefile | 2 +- >>>> .../bsdapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++= ++++++++ >=20 > I sent a patch to flatten the hierarchy, removing exec-env. > And I'm not sure about the file name rte_eal.h. > Please could you move it to lib/librte_eal//eal/include/rte_exec_env.= h > or another better name? Note that Windows is introducing rte_os.h. > PS: I'm not sure about the intent of rte_os.h. Should it be rte_libc.h? I agree here unless the rte_os.h or (rte_libc.h) is really a header to just= include rte_windows_libc.h, rte_linux_libc.h or rte__libc.h to simplif= y including OS specific headers and differences in libc designs. >=20 >>>> lib/librte_eal/common/eal_common_log.c | 2 + >>>> lib/librte_eal/common/include/rte_bus.h | 2 + >>>> lib/librte_eal/common/include/rte_eal.h | 6 --- >>>> lib/librte_eal/common/include/rte_tailq.h | 2 + >>>> lib/librte_eal/linuxapp/eal/Makefile | 2 +- >>>> .../linuxapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++= ++++++++ >>>=20 >>> I am not a big fan of duplicating code for Linux and BSD. >>>=20 >>> Maybe we should have different splits and include a common file >>> in Linux and BSD? >>=20 >> OK. This is doable. >=20 > After some thoughts about Windows port, I think we need to consider > a better split. > The constructors are the same for Linux, BSD and Windows, isn't it? > Is it related to splitting between POSIX libc and others? >=20 >=20 >=20 Regards, Keith From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6B253A0679 for ; Tue, 2 Apr 2019 15:20:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 850742E81; Tue, 2 Apr 2019 15:20:19 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C86FB2C36 for ; Tue, 2 Apr 2019 15:20:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 06:20:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,300,1549958400"; d="scan'208";a="334270873" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 02 Apr 2019 06:20:15 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 2 Apr 2019 06:20:13 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.142]) by FMSMSX125.amr.corp.intel.com ([169.254.2.4]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 06:20:06 -0700 From: "Wiles, Keith" To: Thomas Monjalon CC: Jerin Jacob , dpdk-dev , "Richardson, Bruce" , "Rawat, Anand" , "Menon, Ranjit" , "Yigit, Ferruh" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific Thread-Index: AQHU6VOmWFi9Sjhe30qLYTgkzLzt/KYpUEIA Date: Tue, 2 Apr 2019 13:20:05 +0000 Message-ID: <6014E7E9-DDA1-48EE-A9E3-C6D651DB11F4@intel.com> References: <20170807120408.21975-1-jerin.jacob@caviumnetworks.com> <30782747.pV0nTTKWH9@xps> <20171011143352.GA23500@jerin> <1935282.F1JuZfYupj@xps> In-Reply-To: <1935282.F1JuZfYupj@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.102.28] Content-Type: text/plain; charset="UTF-8" Content-ID: <8245442675161C4A9AC4851E979D3C46@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402132005.YLEEbvHBxjMRYR-HvlBqhsj89LiIYO8CcbWKZqNyxtU@z> > On Apr 2, 2019, at 7:57 AM, Thomas Monjalon wrote: >=20 > 11/10/2017 16:33, Jerin Jacob: >> From: Thomas Monjalon >>> 07/08/2017 14:04, Jerin Jacob: >>>> baremetal execution environments may have a different >>>> method to enable RTE_INIT instead of using compiler >>>> constructor scheme. Move RTE_INIT* definition under >>>> exec-env to support different execution environments. >>>>=20 >>>> Signed-off-by: Jerin Jacob >>>> --- >>>> app/test-eventdev/evt_test.h | 2 +- >>>> lib/librte_eal/bsdapp/eal/Makefile | 2 +- >>>> .../bsdapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++= ++++++++ >=20 > I sent a patch to flatten the hierarchy, removing exec-env. > And I'm not sure about the file name rte_eal.h. > Please could you move it to lib/librte_eal//eal/include/rte_exec_env.= h > or another better name? Note that Windows is introducing rte_os.h. > PS: I'm not sure about the intent of rte_os.h. Should it be rte_libc.h? I agree here unless the rte_os.h or (rte_libc.h) is really a header to just= include rte_windows_libc.h, rte_linux_libc.h or rte__libc.h to simplif= y including OS specific headers and differences in libc designs. >=20 >>>> lib/librte_eal/common/eal_common_log.c | 2 + >>>> lib/librte_eal/common/include/rte_bus.h | 2 + >>>> lib/librte_eal/common/include/rte_eal.h | 6 --- >>>> lib/librte_eal/common/include/rte_tailq.h | 2 + >>>> lib/librte_eal/linuxapp/eal/Makefile | 2 +- >>>> .../linuxapp/eal/include/exec-env/rte_eal.h | 51 ++++++++++++++= ++++++++ >>>=20 >>> I am not a big fan of duplicating code for Linux and BSD. >>>=20 >>> Maybe we should have different splits and include a common file >>> in Linux and BSD? >>=20 >> OK. This is doable. >=20 > After some thoughts about Windows port, I think we need to consider > a better split. > The constructors are the same for Linux, BSD and Windows, isn't it? > Is it related to splitting between POSIX libc and others? >=20 >=20 >=20 Regards, Keith