From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E15D5A00C2; Tue, 8 Mar 2022 10:40:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 888FD4068E; Tue, 8 Mar 2022 10:40:08 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 16CF54068B for <dev@dpdk.org>; Tue, 8 Mar 2022 10:40:06 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 948E75C0216; Tue, 8 Mar 2022 04:40:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 08 Mar 2022 04:40:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=aN1ADbTFSHYH4J h5FpYPEhGq9v59+yHOO5oJPS8hjJQ=; b=hFCiZf25PQeRCJYtvJUV2HRSpLm/W7 X3kiwG90IknbM2c8L7Qez9SAXEnfmgx6tGil0WwiKA4YDgIoVU+sTAIo8VM9dUWw u5NWj9m1bSQu5LY+fs0IvNtl6Yd9HIVm4DB9NNXHWet9D0CEkzdhnEGigFf+x5QK HEB/THUOpaKLPCdYH1Ihk+IFLNAa3n1PIzUMdWzEYvYEaASnz6SvjZ74dqECfwo9 jmXEymzDjUoXqmGy/K6wDgRbSk4YeeBvhwWOpNbM+Bm/ajKkwxFR+u/x0zNcLrJU NI/rGaQZej13xSDXrqjljjPkXQ4xNZf2+SaZu0OKrE+FcRem/kekwgAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aN1ADbTFSHYH4Jh5FpYPEhGq9v59+yHOO5oJPS8hj JQ=; b=StVgvb0kPj0HY04+O9Cc8Ao9ru41O5dgGI0NsZgKS8WirF27pdWvk+RoN SInKH1bbI4lvaQA/acQDNRl3QSvh89IA4QzbT3f46ra4E0eLS5DYNWthUe1NlxJH b8uU4jwJPlQcWK+dyvSStVl1flZujVTlx0y9O/I0L6PLG5qD1lqwhtxMbwPQ548H swG8813OR0U7LDB0Nz8/Ecy15xAqPlfcebmGmm6UD0hFznSPxXXFldKKA4eAPZuu qvGUFwVNqOC6PWihtl7wPbRsE7Xr/xNOL8EXwQMcDwxDMFCRnL9AM1uVAy7uOTDw dvs/PT0I28p4uwi4nUP+65Adwvk5g== X-ME-Sender: <xms:diQnYk1ejJJl47ZCrDiPXd9WU_8rS9m0fSadUCqWGdy7ezHuDePF4g> <xme:diQnYvFwb38tFJ8nvLE7fHpYRoNA_F4xAIfZQN-5HCubb_tKfSRHS_Xk7UEI4a5Tv KKGY9e5HGo67G3pzg> X-ME-Received: <xmr:diQnYs70d3Wgxt7oLhAaIMJFHayjUnYH703vLMTQ6Fx35a6JLpVRUd7eMrXxr2-0chA1R5tgK_ZYD7EkMoFVaOLgqQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:diQnYt27z2CkuE82oLj5POQJS8khlte0TxO0ZP7c8w8DjgvXJNPuWg> <xmx:diQnYnFPO-3A1J6pms7MfR8fe6epWHhHt0q14UMzdre6OK92WVrv1A> <xmx:diQnYm_1sgaDEzlgxspcIUMn6A6rog8YXamFoKMwFiBqFdeCDC5XjA> <xmx:diQnYs7wsZRVcpzzc4-L002ibmni7SnmjJatcynRAj5vaHWCuTz9Aw> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Mar 2022 04:40:05 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com>, Michael Baum <michaelba@nvidia.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Xiaoyun Li <xiaoyun.li@intel.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Matan Azrad <matan@nvidia.com>, asafp@nvidia.com Subject: Re: [PATCH 1/2] app/testpmd: add test for remote PD and CTX Date: Tue, 08 Mar 2022 10:40:04 +0100 Message-ID: <6015953.ZaRXLXkqSa@thomas> In-Reply-To: <DM5PR12MB4661C8AA4BAAC339A9FE3728CC089@DM5PR12MB4661.namprd12.prod.outlook.com> References: <20220301202615.4103972-1-michaelba@nvidia.com> <6d96be71-a21f-5413-36b8-e9771bf6fe9f@intel.com> <DM5PR12MB4661C8AA4BAAC339A9FE3728CC089@DM5PR12MB4661.namprd12.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 07/03/2022 17:07, Michael Baum: > On 3/3/2022 2:57 PM, Ferruh Yigit wrote: > > Hi Michael, > > > > This is too much mlx5 specific addition, and I don't think it is good to extend > > testpmd with PMD specific code. > > If we enable it, sure there will be other vendors willing to do the same, > > making testpmd even messier. > > Hi Ferruh, > > It is mlx5 PMD specific API, which enables to import device from remote process. > This extension is the way to test this API, you can see a lot of PMD specific APIs along testpmd files. > > If one day, other vendors want to import devargs from remote process, they will remove the mlx5 build time dependency and use it. > > > I don't know what those ``cmd_fd`` and ``pd_handle`` (that read from > > provided socket), but can they be read from some other script and feed to > > testpmd, like a python wrapper etc... I agree with Ferruh that it's a lot of code only for mlx5. Yes we are already calling other PMD-specific API in testpmd but we should try to keep it as small as possible. I propose to try a rework to make it easier to digest. As a consequence, we won't have this testpmd feature in 22.03, and we can work together for the next release.